New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , All
Pri: 1
Type: Bug

Blocking:
issue 544238
issue 604452
issue 617982
issue 618006
issue 618751



Sign in to add a comment

Determine if we need to build performance_browser_tests and sync_performance_tests

Project Member Reported by dtu@chromium.org, Jun 13 2016

Issue description

The data shows that these two perf testing binaries are really big and take a long time to build, tripling our binary size build time. Let's see if we can get rid of either of them.

Assigning to Annie to find out who owns them.

Data is in this sheet:
https://docs.google.com/spreadsheets/d/1pmk4QG7INaRiBra3ZFr1dkpb5CYgUgJmGMHaC8fLSPA/edit#gid=0
 

Comment 1 by dtu@chromium.org, Jun 13 2016

Blocking: 604452 544238
Cc: sh...@chromium.org
I made a copy of the sheet that I can edit:
https://docs.google.com/spreadsheets/d/1wz-urKaRWdhujdnKdOuDjMG-EQhVToRTdgp6oJflZvs/edit#gid=0

We definitely still need to run performance_browser_tests, miu and alancutter own those.

Shadi, do you what sync_performance_tests is? We haven't run this binary for multiple years, and it's slowing down our builds considerably. We intend to stop building this for chromium.perf waterfall.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1998b21312ef04fa328f3ec31fd4ca4f2d014dd6

commit 1998b21312ef04fa328f3ec31fd4ca4f2d014dd6
Author: dtu <dtu@chromium.org>
Date: Wed Jun 15 06:17:25 2016

[perf] Disable unused chromium_builder_perf build targets.

Some of these targets (sync_performance_tests) include a full copy of Chrome, and are costly in time and space to build and package.
The list of perf targets is in this sheet:
https://docs.google.com/spreadsheets/d/1wz-urKaRWdhujdnKdOuDjMG-EQhVToRTdgp6oJflZvs/edit#gid=0

BUG= 619626 

Review-Url: https://codereview.chromium.org/2066033002
Cr-Commit-Position: refs/heads/master@{#399851}

[modify] https://crrev.com/1998b21312ef04fa328f3ec31fd4ca4f2d014dd6/BUILD.gn
[modify] https://crrev.com/1998b21312ef04fa328f3ec31fd4ca4f2d014dd6/build/all.gyp

Status: Fixed (was: Assigned)
I think we did everything here?

Sign in to add a comment