Issue metadata
Sign in to add a comment
|
captureStream() from <video> and <audio>element |
||||||||||||||||||||||||||||||||||||||||||||
Issue description[Please do not remove the Launch-* labels. Email chrome-launch-review@ (for non-Chrome OS) or chromeos-launch-review@ (for Chrome OS) with any questions.] Feature description: https://w3c.github.io/mediacapture-fromelement/#html-media-element-media-capture-extensions. This API is already supported for <canvas> elements. Eng owner: niklase/mcasas Product owner:blum Blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/capturestream/blink-dev/ZuseXCSZY2U/p1gLNcCMAgAJ Implementation bug: https://bugs.chromium.org/p/chromium/issues/detail?id=569976 Finch/experimentation: If you plan on running an experiment or rolling out your feature using Finch, please list the histograms and user actions that you intend to analyze for this launch. Include the expected effect - both the directional shift in the metrics and, if possible, an estimated magnitude. You should also have a Finch ambassador. Go to https://g3doc.corp.google.com/analysis/uma/g3doc/finch/guide.md?cl=head #finch-ambassador to get a Finch ambassador and CC them on this bug. ################################################################# # Fill these surveys out as you are ready for various reviews. # ################################################################# Accessibility survey: The accessibility survey is included in a review bug that is automatically filed when you update this bug to Launch-Status- Review-Requested. Please answer all questions there. Legal survey: Email ctanaka@ (for non-Chrome OS) or scottgerwin@ and jlchen@ (for Chrome OS) to request a legal review. Privacy survey: The privacy survey is included in a review bug that is automatically filed when you update this bug to Launch-Status-Review- Requested. Please answer all questions there. <b>Security survey: <https://goto.google.com/chrome-security-questions></b> <b>Test survey: <https://goto.google.com/chrome-test-questions></b> UI survey: Email chrome-ui-review@ (for non-Chrome OS) or chromeos-ui- review@ (for Chrome OS) to request a UI review.
,
Jun 13 2016
,
Jun 16 2016
**Bulk edit** Feature freeze for M-53 is tomorrow, and we are trying to lock down the shipping set of features. To help clarifying what's shipping, we will change the milestone label for all Launch-Status=Pending issues to M-54 by Tuesday, 6/21 (since there appears to be no activity in review). If you still plan to ship for M-53, please transition to a review/request state now (Launch-Status=Review/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Jun 17 2016
Feature freeze and intent-to-ship not sent yet, moving to 54.
,
Aug 11 2016
**Bulk edit** Feature freeze for M-54 is tomorrow, and we are trying to lock down the shipping set of features. To help clarifying what's shipping, we will change the milestone label for all non-approved issues without Launch-Status=Review-requested or Launch-Status=Approval-requested to M-55 by Tuesday, 8/16 (since there appears to be no activity in review). If you still plan to ship for M-54, please transition to a review/request state now (Launch-Status=Review/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Aug 11 2016
Moving to 55 since spec discussion isn't final.
,
Sep 22 2016
**Bulk edit** Feature freeze for M-55 is tomorrow, and we are trying to lock down the shipping set of features. Your feature has either M=55 or Launch-M-Target=55-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-56 by Tuesday, 9/27 (since there appears to be no activity in review). If you still plan to ship for M-55, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Sep 27 2016
**Bulk edit** We are now past M-55 FF. Since you still haven't transitioned to a review state, we are assuming that you are not planning to launch in M-55. As such, we're updating the MStone to M-56. If you still intend to launch in M-55, feel free to change this back, but *please begin your xfnl reviews now*! Thanks for your help with ensuring a smooth process.
,
Sep 27 2016
,
Sep 27 2016
,
Nov 2 2016
**Bulk edit** Feature freeze for M-56 is tomorrow, and we are trying to lock down the shipping set of features. Your feature has either M=56 or Launch-M-Target=56-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-57 by Tuesday, 11/8 (since there appears to be no activity in review). If you still plan to ship for M-56, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Nov 9 2016
**Bulk edit** We are now past M-56 FF. Since you still haven't transitioned to a review state, we are assuming that you are not planning to launch in M-56. As such, we're updating the MStone to M-57. If you still intend to launch in M-65, feel free to change this back, but *please begin your xfnl reviews now*! Thanks for your help with ensuring a smooth process.
,
Jan 4 2017
**Bulk edit** Feature freeze for M-57 is on Friday 1/6, and we are trying to lock down the shipping set of features. Your feature has either M=57 or Launch-M-Target=57-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-57 by Wed, 1/11 (since there appears to be no activity in review). If you still plan to ship for M-57, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Jan 11 2017
**Bulk edit** We are now past M-57 FF. Since you still haven't transitioned to a review state, we are assuming that you are not planning to launch in M-57. As such, we're updating the MStone to M-58. If you still intend to launch in M-57, feel free to change this back, but *please begin your xfnl reviews now*! Thanks for your help with ensuring a smooth process.
,
Feb 21 2017
**Bulk edit** Feature freeze for M-58 was on Feb 17th, and we are trying to lock down the shipping set of features. Your feature has either M=58 or Launch-M-Target=58-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-59 by Fri, 2/24 (since there appears to be no activity in review). If you still plan to ship for M-58, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Mar 6 2017
,
Mar 6 2017
,
Mar 6 2017
,
Mar 7 2017
,
Mar 27 2017
**Bulk edit** Feature freeze for M-59 is on Friday March 31st, and we are trying to lock down the shipping set of features. Your feature has either M=59 or Launch-M-Target=59-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-60 by Weds April 5th (since there appears to be no activity in review). If you still plan to ship for M-59, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Apr 5 2017
**Bulk edit** We are now past M-59 FF. Since you still haven't transitioned to a review state, we are assuming that you are not planning to launch in M-59. As such, we're updating the MStone to M-60. If you still intend to launch in M-59, feel free to change this back, but *please begin your xfnl reviews now*! Thanks for your help with ensuring a smooth process.
,
May 12 2017
**Bulk edit** Feature freeze for M-60 is today!! (Friday May 12), and we are trying to lock down the shipping set of features. Your feature has either M=60 or Launch-M-Target=60-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-60 by Weds, 5/17 (since there appears to be no activity in review). If you still plan to ship for M-60, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
May 12 2017
,
May 12 2017
,
Jun 20 2017
**Bulk edit** Feature freeze for M-61 is Friday June 23, and we are trying to lock down the shipping set of features. Your feature has either M=61 or Launch-M-Target=61-Beta/Stable-Exp, but has not moved to a review requested state yet (Launch-M-Status=Review-Requested/Approval-Requested). To help clarify what's shipping, we will change the milestone label for your launch to M-62 by Tues, 6/27 (since there appears to be no activity in review). If you still plan to ship for M-61, please transition to a review/request state now (Launch-M-Status=Review-Requested/Approval-Requested). Thanks for your help in making our data set cleaner, it's a big help to the cross functional teams!
,
Jun 22 2017
,
Jun 22 2017
Unsetting the various launch labels as those are only for use on type=launch issues, not type=launch-owp issues The i2ship already got the necessary approvals in [1] and at this moment we're just catching up with the FF implementation. I also got pinged by developers willing to use this feature, so we should just ship it (I just hadn't got the time for it). [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SKLhE1LhjOg
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1674a85c4268a152fbf405b97e1c3082f8ec389f commit 1674a85c4268a152fbf405b97e1c3082f8ec389f Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Jul 14 04:49:28 2017 Capture from HTMLMediaElement: move LayoutTests to external/wpt This CL moves the three standard functionality LayoutTests for mediacapture-fromelement to the external/wpt folder, adapting them accordingly and adding the necessary webmfiles. Also removes the HTMLMediaElementCapture-*.html expectations. Bug: 619625 Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 Reviewed-on: https://chromium-review.googlesource.com/566151 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#486677} [modify] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService [rename] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/capture.html [rename] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/creation.html [rename] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/ended.html [add] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-a-128k-44100Hz-1ch.webm [add] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.webm [add] https://crrev.com/1674a85c4268a152fbf405b97e1c3082f8ec389f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-v-128k-320x240-24fps-8kfr.webm
,
Jul 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b684efb085619035166abe482afa01c4530b4b08 commit b684efb085619035166abe482afa01c4530b4b08 Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Fri Jul 14 19:08:43 2017 Revert "Capture from HTMLMediaElement: move LayoutTests to external/wpt" This reverts commit 1674a85c4268a152fbf405b97e1c3082f8ec389f. Reason for revert: results were unstable upstream: https://github.com/w3c/web-platform-tests/pull/6546 A provisional PR wasn't created for the CL so there's no way this could have been avoided. Original change's description: > Capture from HTMLMediaElement: move LayoutTests to external/wpt > > This CL moves the three standard functionality LayoutTests for > mediacapture-fromelement to the external/wpt folder, adapting > them accordingly and adding the necessary webmfiles. > > Also removes the HTMLMediaElementCapture-*.html expectations. > > Bug: 619625 > Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 > Reviewed-on: https://chromium-review.googlesource.com/566151 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486677} TBR=mcasas@chromium.org,emircan@chromium.org Change-Id: Id0c5e1a45f9d4e65929aede3a6f256eae3850a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 619625 Reviewed-on: https://chromium-review.googlesource.com/572087 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486829} [modify] https://crrev.com/b684efb085619035166abe482afa01c4530b4b08/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService [delete] https://crrev.com/11cce4c53c1ec0be708c55b7218979aba4091c7f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-a-128k-44100Hz-1ch.webm [delete] https://crrev.com/11cce4c53c1ec0be708c55b7218979aba4091c7f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.webm [delete] https://crrev.com/11cce4c53c1ec0be708c55b7218979aba4091c7f/third_party/WebKit/LayoutTests/external/wpt/mediacapture-fromelement/webm/test-v-128k-320x240-24fps-8kfr.webm [rename] https://crrev.com/b684efb085619035166abe482afa01c4530b4b08/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html [rename] https://crrev.com/b684efb085619035166abe482afa01c4530b4b08/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-creation.html [rename] https://crrev.com/b684efb085619035166abe482afa01c4530b4b08/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-ended.html
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/518e065e3341870945e618e70d0f8058061ba9a7 commit 518e065e3341870945e618e70d0f8058061ba9a7 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Jul 21 00:58:28 2017 Capture from HTMLMediaElement: remove duplicated layouttests This CL removes the LayoutTests from fast/mediacapturefromelement that are duplicated after the GitHub PR [1] got rolled in. N.B.: This CL is complemented by the PR [2] that cleans up a bit the path of the webm files in external/wpt/mediacapture-fromelement (but these two are orthogonal and should not interact). [1] https://github.com/w3c/web-platform-tests/pull/6559 [2] https://github.com/w3c/web-platform-tests/pull/6588 ** No new code, just shuffling things around ** Bug: 619625 Change-Id: Ie3540a57f03ed8ab34f048fa309d5ce1525b7f61 Reviewed-on: https://chromium-review.googlesource.com/576595 Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#488525} [modify] https://crrev.com/518e065e3341870945e618e70d0f8058061ba9a7/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService [delete] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html [delete] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-creation.html [delete] https://crrev.com/d24dbd55ffb4246c4dbd120e0954acc4d747a30c/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-ended.html
,
Jul 25 2017
,
Jul 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef commit c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Sat Jul 29 00:05:59 2017 Capture from HTMLMediaElement: flip flag to stable Flip CaptureFromVideo to stable. This allows e.g. <video>/<audio>.captureStream() Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SKLhE1LhjOg Bug: 619625 Change-Id: I19f06fc8d112b6aa9001195584dc3cd2aa5d2003 Reviewed-on: https://chromium-review.googlesource.com/544899 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#490548} [modify] https://crrev.com/c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt [modify] https://crrev.com/c0de80b0bfdf4e18bf35433ce963fcbcda0df9ef/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
,
Jul 29 2017
Fixed by #32
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d50bd43c0312f7323d2d5652af22fedda3a4d8a commit 5d50bd43c0312f7323d2d5652af22fedda3a4d8a Author: Eric Willigers <ericwilligers@chromium.org> Date: Mon Aug 06 13:08:47 2018 Retire MediaCaptureFromVideo runtime flag HTMLMediaElement.captureStream() shipped in M62 https://chromium-review.googlesource.com/544899 https://www.chromestatus.com/feature/5522768674160640 Also removed the TODO comment regarding captureStreamUntilEnded as this has been removed from the spec. BUG= 619625 Change-Id: I27a45e8d9eba5b3376efba3b1276cad6a299b2d3 Reviewed-on: https://chromium-review.googlesource.com/1163058 Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#580854} [modify] https://crrev.com/5d50bd43c0312f7323d2d5652af22fedda3a4d8a/third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.idl [modify] https://crrev.com/5d50bd43c0312f7323d2d5652af22fedda3a4d8a/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
|||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by niklase@chromium.org
, Jun 13 2016