New issue
Advanced search Search tips

Issue 619622 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jun 2016
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Tests Failure chrome_proxy.lo_fi.cache_lo_fi_disabled chrome_proxy.lo_fi.cache_proxy_disabled

Project Member Reported by mariakho...@chromium.org, Jun 13 2016 
I think https://codereview.chromium.org/2048233002 may have started causing chrome_proxy tests to fail.

From https://uberchromegw.corp.google.com/i/internal.client.clank/builders/chrome-proxy-tests/builds/4925/steps/chrome_proxy.lo_fi.cache_lo_fi_disabled/logs/stdio

(INFO) 2016-06-13 08:00:51,207 cmd_helper._ValidateAndLogCommand:153  [host]> /b/build/slave/chrome-proxy-tests/build/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 03b30820f0e944a4 shell '( ndc resolver flushdefaultif );echo %$?'
Traceback (most recent call last):
  File "/b/build/slave/chrome-proxy-tests/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/build/slave/chrome-proxy-tests/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 308, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/build/slave/chrome-proxy-tests/build/src/tools/chrome_proxy/common/chrome_proxy_measurements.py", line 109, in ValidateAndMeasurePage
    self.AddResults(tab, results)
  File "/b/build/slave/chrome-proxy-tests/build/src/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py", line 301, in AddResults
    self._metrics.AddResultsForLoFiCache(tab, results, self._is_lo_fi_enabled)
  File "/b/build/slave/chrome-proxy-tests/build/src/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py", line 280, in AddResultsForLoFiCache
    '' if is_lo_fi else 'not'))
ChromeProxyMetricException: http://check.googlezip.net/cacheable/image1.png: LoFi  expected in response header.

Comment 1 by tbansal@chromium.org, Jun 13 2016

Owner: tbansal@chromium.org
Status: Started (was: Assigned)

Comment 2 by tbansal@chromium.org, Jun 13 2016 

The testbot puts the Chrome in all the field trials specified in the json file, and runs the Chrome proxy integration tests. When Chrome is in the tamper detection field trial, it tells the Flywheel server to bypass all compression.  This field trial then obviously breaks tests that expect Flywheel to be enabled, and expect it to compress objects.

Comment 3 by mariakho...@chromium.org, Jun 13 2016 

Please ensure that tests turn on the required flywheel functionality for them to run correctly.

Comment 4 by tbansal@chromium.org, Jun 13 2016

Cc: bengr@chromium.org
I am working on this. Should be fixed today-ish.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55229da0bb74bc1a1abee81fd248fe1843448d1

commit c55229da0bb74bc1a1abee81fd248fe1843448d1
Author: tbansal <tbansal@chromium.org>
Date: Mon Jun 13 23:04:26 2016

Add a flag to disable server experiments in DRP

Use this flag to disable server experiments field trial when
running Lo-Fi integration tests.

BUG= 619622 

Review-Url: https://codereview.chromium.org/2062963003
Cr-Commit-Position: refs/heads/master@{#399592}

[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Comment 6 by tbansal@chromium.org, Jun 14 2016

Components: Internals>Network>DataProxy
Status: Fixed (was: Started)
Verified that the bot is green now: https://uberchromegw.corp.google.com/i/internal.client.clank/builders/chrome-proxy-tests/
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55229da0bb74bc1a1abee81fd248fe1843448d1

commit c55229da0bb74bc1a1abee81fd248fe1843448d1
Author: tbansal <tbansal@chromium.org>
Date: Mon Jun 13 23:04:26 2016

Add a flag to disable server experiments in DRP

Use this flag to disable server experiments field trial when
running Lo-Fi integration tests.

BUG= 619622 

Review-Url: https://codereview.chromium.org/2062963003
Cr-Commit-Position: refs/heads/master@{#399592}

[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
[modify] https://crrev.com/c55229da0bb74bc1a1abee81fd248fe1843448d1/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
►

Sign in to add a comment