New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619612 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Not on Chrome
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 618009
issue 621347
issue 621349



Sign in to add a comment

Enable MD History by default

Project Member Reported by tbuck...@chromium.org, Jun 13 2016

Issue description

Enable MD History by default for all users in M53. Supervised users should still see the old History page.
 

Comment 1 by battre@chromium.org, Jun 16 2016

Blockedon: 618009
Are you going to add  bug 621027 ,  bug 621033 , etc as blockers?
Blockedon: 621349
Blockedon: 621347
Cc: dbeam@chromium.org dpa...@chromium.org
Maybe I just have too many history entries, but MD History is basically unusable on my Windows box. It seems OK on Chrome OS, so maybe there was a regression between 2768 and 2772? Hard to tell without performance tests.

I wasn't even aware that this launched. It's important we keep track of what's launched so changes to common elements like https://codereview.chromium.org/2075453002 are properly tested.

Given the performance issues and usability issues (which may just be a result of poor performance causing the tab to hang) I'd like to revert this ASAP.
Update: When I said "Maybe I just have too many history entries" I didn't realize my Canary profile had visited crashsafari.com which adds thousands of long history entries. Sooo it's probably just that.
Labels: -M-53 M-54
We've decided to push MD History back to target M54. 

Given comment 6, it looks like there's no immediate need to disable the page, so we'll plan to give it most of this week in Canary/Dev to gather some feedback before reverting.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece56c695911ac53c59f883762a42a98f3f4fa5a

commit ece56c695911ac53c59f883762a42a98f3f4fa5a
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jun 24 05:42:31 2016

MD History: Disable by default

We are disabling the feature for now, and will proceed with a rollout in
M54 after remaining problems are fixed.

BUG= 619612 

Review-Url: https://codereview.chromium.org/2077283002
Cr-Commit-Position: refs/heads/master@{#401822}

[modify] https://crrev.com/ece56c695911ac53c59f883762a42a98f3f4fa5a/chrome/common/chrome_features.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12c7998901fcdb7d43284f4621ca95b859fc56e3

commit 12c7998901fcdb7d43284f4621ca95b859fc56e3
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jul 14 02:39:21 2016

MD History: Enable by default

BUG= 619612 

Review-Url: https://codereview.chromium.org/2136893002
Cr-Commit-Position: refs/heads/master@{#405407}

[modify] https://crrev.com/12c7998901fcdb7d43284f4621ca95b859fc56e3/chrome/common/chrome_features.cc

Cc: calamity@chromium.org
Owner: tsergeant@chromium.org
Status: Fixed (was: Assigned)
We're enabled by default and rolled through to Canary channel, so I guess this is fixed 🙌.
Status: Assigned (was: Fixed)
chrome://history still opens the old History page
Tested on ChromeOS 8932.0.0, 56.0.2899.0 dev-channel samus

Comment 12 by dbeam@chromium.org, Oct 25 2016

sdantuluri@: have you changed "enable-md-history" on chrome://flags or are you using grouped history (or a supervised user)?

Comment 13 by dbeam@chromium.org, Oct 25 2016

Labels: -M-54 M-55
I am on normal user account. Did not alter the "enable-md-history" flag.

From the bug title I supposed that chrome://history should now automatically open the MD History page
Status: Fixed (was: Assigned)
On Dev Channel you're probably in the Disable experiment that we ran to compare performance. I believe everything is working as expected.

The experiment will automagically end on the 5th Nov.
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.54.0, 55.0.2883.54 beta

Sign in to add a comment