Win x64 perf Builder Compile failed |
||||||
Issue descriptionBuild is broken: compile Revision range: chromium 399397 : 399397 Failing builders: Win x64 Builder: https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder Suspecting CL: https://codereview.chromium.org/2063483002 doing a speculative revert.
,
Jun 13 2016
,
Jun 13 2016
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7395734b45799a2bc04f54b8a932db259314faac commit 7395734b45799a2bc04f54b8a932db259314faac Author: fmeawad <fmeawad@chromium.org> Date: Mon Jun 13 16:02:27 2016 Revert of Make chrome/browser and .../ui static libraries. (patchset #2 id:20001 of https://codereview.chromium.org/2063483002/ ) Reason for revert: Breaking Win x64 Perf builder (official) Speculative. BUG= 619606 Original issue's description: > Make chrome/browser and .../ui static libraries. > > On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded. > > TBR=dpranke > (split off of https://codereview.chromium.org/2043873004/ which already has review) > BUG= 617837 > > Committed: https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31 > Cr-Commit-Position: refs/heads/master@{#399401} TBR=dpranke@google.com,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 617837 Review-Url: https://codereview.chromium.org/2061773002 Cr-Commit-Position: refs/heads/master@{#399462} [modify] https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac/chrome/browser/BUILD.gn [modify] https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac/chrome/browser/ui/BUILD.gn
,
Jun 13 2016
For future reference, please provide the actual error in the revert and in the bug. If the bot goes green again it can be very difficult for a patch author to actually find when the problem was. FAILED: obj/third_party/WebKit/Source/modules/blink_modules.lib C:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False lib.exe /nologo /ignore:4221 /LTCG /LTCG /LTCG /LTCG /OUT:obj/third_party/WebKit/Source/modules/blink_modules.lib @obj/third_party/WebKit/Source/modules/blink_modules.lib.rsp obj/third_party/WebKit/Source/modules/blink_modules.lib : fatal error LNK1248: image size (10061DC9A) exceeds maximum allowable size (FFFFFFFF)
,
Jun 13 2016
Also: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False lib.exe /nologo /ignore:4221 /LTCG /LTCG /LTCG /LTCG /OUT:obj/chrome/browser/browser.lib @obj/chrome/browser/browser.lib.rsp obj/chrome/browser/browser.lib : fatal error LNK1248: image size (10055EEB3) exceeds maximum allowable size (FFFFFFFF)
,
Jun 13 2016
,
Jun 13 2016
Fadi's revert didn't make the bot green: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9522 But now we have 2 different compile errors: 1. browser.lib link error (comment 6) first seen at https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9469 (reverted) 2. blink_modules.lib error (comment 5) first seen at https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9474 Both CLs come from brettw's change on the build file. I will go ahead to revert the CL causing the 2nd error now.
,
Jun 13 2016
Looks like to reverts worked. Thanks!
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7395734b45799a2bc04f54b8a932db259314faac commit 7395734b45799a2bc04f54b8a932db259314faac Author: fmeawad <fmeawad@chromium.org> Date: Mon Jun 13 16:02:27 2016 Revert of Make chrome/browser and .../ui static libraries. (patchset #2 id:20001 of https://codereview.chromium.org/2063483002/ ) Reason for revert: Breaking Win x64 Perf builder (official) Speculative. BUG= 619606 Original issue's description: > Make chrome/browser and .../ui static libraries. > > On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded. > > TBR=dpranke > (split off of https://codereview.chromium.org/2043873004/ which already has review) > BUG= 617837 > > Committed: https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31 > Cr-Commit-Position: refs/heads/master@{#399401} TBR=dpranke@google.com,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 617837 Review-Url: https://codereview.chromium.org/2061773002 Cr-Commit-Position: refs/heads/master@{#399462} [modify] https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac/chrome/browser/BUILD.gn [modify] https://crrev.com/7395734b45799a2bc04f54b8a932db259314faac/chrome/browser/ui/BUILD.gn |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fmea...@chromium.org
, Jun 13 2016