New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619605 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
inactive
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mustash: Support launching apps from app list

Project Member Reported by mfomitchev@chromium.org, Jun 13 2016

Issue description

Support launching apps from app list in Mustash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5621dd87cde37a495f22eeaaee24337eada0f826

commit 5621dd87cde37a495f22eeaaee24337eada0f826
Author: mfomitchev <mfomitchev@chromium.org>
Date: Mon Jun 13 20:35:30 2016

Adding ChromeLauncherController interface.

Breaking up the existing ChromeLauncherController class into ChromeLauncherController interface and ChromeLauncherControllerImpl implementation. With a few exceptions, classes that interact with ChromeLauncherController now do it through ChromeLauncherController interface.

This is the first step in adding a Mustash implementation of ChromeLauncherController.

ChromeLauncherControllerImpl does a lot more than implement ChromeLauncherController interface. Various parts of the code rely on this functionality. Particularly on methods from ash::ShelfDelegate that it implements. This was resolved in one of three ways:
- Using ash::Shell::GetShelfDelegate() (the reason this couldn't be used everywhere is unit tests)
- Using ChromeLauncherControllerImpl instead of ChromeLauncherController
- Storing separate pointers for ChromeLauncherController and ash::ShellDelegate.

BUG= 619605 

Review-Url: https://codereview.chromium.org/2052013002
Cr-Commit-Position: refs/heads/master@{#399527}

[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[add] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[add] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[rename] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[rename] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_tests.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/test/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5621dd87cde37a495f22eeaaee24337eada0f826

commit 5621dd87cde37a495f22eeaaee24337eada0f826
Author: mfomitchev <mfomitchev@chromium.org>
Date: Mon Jun 13 20:35:30 2016

Adding ChromeLauncherController interface.

Breaking up the existing ChromeLauncherController class into ChromeLauncherController interface and ChromeLauncherControllerImpl implementation. With a few exceptions, classes that interact with ChromeLauncherController now do it through ChromeLauncherController interface.

This is the first step in adding a Mustash implementation of ChromeLauncherController.

ChromeLauncherControllerImpl does a lot more than implement ChromeLauncherController interface. Various parts of the code rely on this functionality. Particularly on methods from ash::ShelfDelegate that it implements. This was resolved in one of three ways:
- Using ash::Shell::GetShelfDelegate() (the reason this couldn't be used everywhere is unit tests)
- Using ChromeLauncherControllerImpl instead of ChromeLauncherController
- Storing separate pointers for ChromeLauncherController and ash::ShellDelegate.

BUG= 619605 

Review-Url: https://codereview.chromium.org/2052013002
Cr-Commit-Position: refs/heads/master@{#399527}

[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[add] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[add] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[rename] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[rename] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/desktop_shell_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_tests.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/5621dd87cde37a495f22eeaaee24337eada0f826/chrome/test/BUILD.gn

Status: Verified (was: Started)

Sign in to add a comment