New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619588 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Configuring WebRTC with H.264 and RED causes video freezes.

Project Member Reported by holmer@chromium.org, Jun 13 2016

Issue description

When configuring webrtc with both h.264 and red freezes occur if packets ar lost. This is caused by the receiver assuming that retransmitted packets are red, while the sender doesn't send red with h.264 even when configured.
 

Comment 1 by holmer@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/8f4c77fea10010b5879a01bf6fcd485318594a85

commit 8f4c77fea10010b5879a01bf6fcd485318594a85
Author: stefan <stefan@webrtc.org>
Date: Fri Jun 03 07:16:45 2016

Always send RED headers if configured.

This shouldn't be needed, but because the receiver assumes RTX packets
contain RED if configured to receive them (due to an incompatibility
issue), we also have to make sure we send them for now.

BUG= webrtc:5675 

Review-Url: https://codereview.webrtc.org/2033763002
Cr-Commit-Position: refs/heads/master@{#13024}

[modify] https://crrev.com/8f4c77fea10010b5879a01bf6fcd485318594a85/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc
[modify] https://crrev.com/8f4c77fea10010b5879a01bf6fcd485318594a85/webrtc/video/video_send_stream.cc
[modify] https://crrev.com/8f4c77fea10010b5879a01bf6fcd485318594a85/webrtc/video/video_send_stream_tests.cc

Comment 2 by holmer@chromium.org, Jun 13 2016

Labels: Merge-Request-52

Comment 3 by holmer@chromium.org, Jun 13 2016

Status: Assigned (was: Untriaged)

Comment 4 by holmer@chromium.org, Jun 13 2016

Corresponding webrtc bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=5675

Comment 5 by tin...@google.com, Jun 14 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 6 by pbos@chromium.org, Jun 14 2016

Cc: holmer@chromium.org
Labels: -Hotlist-Merge-Approved -Merge-Approved-52 merge-merged-52
Owner: pbos@chromium.org
Status: Fixed (was: Assigned)
Merged in https://chromium.googlesource.com/external/webrtc.git/+/3446611ec58e3e218371debc798899fac7ff2e00, I forgot the BUG= label.

Comment 7 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 8 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment