New issue
Advanced search Search tips

Issue 619587 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Existing profiles may have invalid use stats.

Project Member Reported by se...@chromium.org, Jun 13 2016 
New profiles should be created with valid use stats now ( crbug.com/603640 ).

However, There is currently no way to differentiate a profile that was created just before that CL landed and one that was created 3 years ago if both have not been reused since. This causes problem when determining if a profile is relevant and/or if it should be deleted.

When updating profiles in the DB, if a profile has the invalid use date (0), we should set it to two weeks ago from now. 

This code should then be removed in the next version.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e

commit e9ba60d7808bcdc37d8e6c69d036841a683b9e3e
Author: mathp <mathp@chromium.org>
Date: Fri Jun 17 22:26:49 2016

Fix profiles with bad |use_date| values.

A recent CL set the use date of new profiles to Now(). However, profiles that were created before and have not been used since still have the default value.

Adds a routine to set the use date of profiles for which it is set to the default value to two weeks before Now(). That routine will be run once per major version.

BUG= 619587 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/2077003002
Cr-Commit-Position: refs/heads/master@{#400526}

[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/common/autofill_pref_names.cc
[modify] https://crrev.com/e9ba60d7808bcdc37d8e6c69d036841a683b9e3e/components/autofill/core/common/autofill_pref_names.h
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by se...@chromium.org, Jul 11 2016

Labels: -M-54 -MovedFrom-53 M-53
Status: Fixed (was: Started)
►

Sign in to add a comment