Right now, we have only one type of snippets - "Articles for you", fetched from ChromeReader. In the future, we will want more providers; Offline Pages will be the second. https://docs.google.com/document/d/1DsI3e2QPKuWezngOkAozap15FeS6J3Axebl_NoVDVas
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3 commit bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3 Author: pke <pke@google.com> Date: Mon Jun 27 14:00:14 2016 Add ContentSuggestion, ContentSuggestionCategory and ContentSuggestionProviderType Add new classes to be used by the upcoming ContentSuggestionService. These new classes are added in a way that does not break the existing NTPSnippets code. BUG= 619560 Review-Url: https://codereview.chromium.org/2059203002 Cr-Commit-Position: refs/heads/master@{#402164} [modify] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets.gypi [modify] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/BUILD.gn [add] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/content_suggestion.cc [add] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/content_suggestion.h [add] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/content_suggestion_category.h [add] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/content_suggestions_provider_type.h [modify] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/ntp_snippet.cc [modify] https://crrev.com/bf8042c0dfb265e5c39d1a7e69fe0aa7625867d3/components/ntp_snippets/ntp_snippet.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dbb90af760531b04ca335d99cc68b448e0523b9 commit 6dbb90af760531b04ca335d99cc68b448e0523b9 Author: pke <pke@google.com> Date: Fri Jul 08 14:00:46 2016 Add ContentSuggestionsService Add new ContentSuggestionsService, which acts as a mixer of suggestions provided by different providers. Add the ContentSuggestionsProvider interface to be implemented by these providers. Add the ContentSuggestionsServiceFactory. Add CSCategoryStatus for providers to report on the status of their categories. Rename ContentSuggestionCategory to ContentSuggestionsCategory for consistency. Remove ContentSuggestionsProviderType as there can only be one provider for any category. Remove previously inserted ToContentSuggestion() from NTPSnippet. All new classes do not yet interact with existing code or even touch it and the new code is not yet used by the UI. The new service is launched by the ProfileManager but does not do anything yet. BUG= 619560 Review-Url: https://codereview.chromium.org/2102023002 Cr-Commit-Position: refs/heads/master@{#404347} [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/chrome/browser/ntp_snippets/content_suggestions_service_factory.h [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/chrome/browser/profiles/profile_manager.cc [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/chrome/chrome_browser.gypi [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets.gypi [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestion.cc [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestion.h [delete] https://crrev.com/39a62799e3d7d69725863d324d265c06f03b6c75/components/ntp_snippets/content_suggestion_category.h [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_category.h [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_category_status.cc [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_category_status.h [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_provider.cc [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_provider.h [delete] https://crrev.com/39a62799e3d7d69725863d324d265c06f03b6c75/components/ntp_snippets/content_suggestions_provider_type.h [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_service.cc [add] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/ntp_snippet.cc [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/ntp_snippet.h [modify] https://crrev.com/6dbb90af760531b04ca335d99cc68b448e0523b9/components/ntp_snippets/ntp_snippets_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6553c901b9663f2c3d63556f68fe4eccb730e03 commit a6553c901b9663f2c3d63556f68fe4eccb730e03 Author: pke <pke@google.com> Date: Wed Jul 13 09:20:36 2016 Change NTPSnippetsService to implement ContentSuggestionsProvider The NTPSnippetsService currently delivers snippets to the UI via the Android bridge. Change it to additionally serve as a ContentSuggestionsProvider implementation and deliver ContentSuggestions for the ARTICLES category. These ContentSuggestions are currently only delivered to the ContentSuggestionsService and not served to the UI, yet. Adjust NTPSnippetsServiceTest, SnippetsBridge and SnippetsInternals because of a few renamed functions. Change NTPSnippetsServiceFactory to register the NTPSnippetsService as a provder with the ContentSuggestionsService. BUG= 619560 Review-Url: https://codereview.chromium.org/2131943002 Cr-Commit-Position: refs/heads/master@{#405103} [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/content_suggestions_category_status.h [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/content_suggestions_provider.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/content_suggestions_provider.h [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/a6553c901b9663f2c3d63556f68fe4eccb730e03/components/ntp_snippets/ntp_snippets_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f397acb853c3eaf3791e43ecedd22610d954a9d9 commit f397acb853c3eaf3791e43ecedd22610d954a9d9 Author: pke <pke@google.com> Date: Wed Jul 13 14:47:43 2016 Add ContentSuggestionsService to SnippetsInternals The ContentSuggestionsService retrieves suggestions from the NTPSnippetsService as a provider. The latter currently delivers its snippets to the chrome://snippets-internals/ page for debugging. Before the NTP UI will be changed to retrieve suggestions from the ContentSuggestionsService instead of directly from the NTPSnippetsService, this adds the output of the ContentSuggestionsService to the snippets-internals page to allow debugging both and compare the data converted data to the original. This also adds controls for clearing cached/discarded suggestions. BUG= 619560 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2145563002 Cr-Commit-Position: refs/heads/master@{#405149} [modify] https://crrev.com/f397acb853c3eaf3791e43ecedd22610d954a9d9/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/f397acb853c3eaf3791e43ecedd22610d954a9d9/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/f397acb853c3eaf3791e43ecedd22610d954a9d9/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/f397acb853c3eaf3791e43ecedd22610d954a9d9/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/f397acb853c3eaf3791e43ecedd22610d954a9d9/components/ntp_snippets/ntp_snippets_service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396 commit adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396 Author: pke <pke@google.com> Date: Tue Jul 19 10:28:08 2016 Add Unit-Test for ContentSuggestionsService Implement ContentSuggestionsServiceTest BUG= 619560 Review-Url: https://codereview.chromium.org/2151863002 Cr-Commit-Position: refs/heads/master@{#406240} [modify] https://crrev.com/adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396/components/components_tests.gyp [modify] https://crrev.com/adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396/components/ntp_snippets/content_suggestions_service.h [add] https://crrev.com/adf6d2f83a45d1f7435d2294e72f7f6b4ecf1396/components/ntp_snippets/content_suggestions_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cde3173b62fee4162a93fe497f8df2597c5e49e commit 0cde3173b62fee4162a93fe497f8df2597c5e49e Author: pke <pke@google.com> Date: Tue Jul 19 14:23:54 2016 Use pipe as ID separator and add inverse functions for MakeUniqueID A ContentSuggestionsProvider needs to be able to split up the suggestion_id it retrieves in DiscardSuggestion and FetchSuggestionImage into the category and the within_category_id that it provided to MakeUniqueID when creating the ContentSuggestion. Add two static helper functions to ContentSuggestionsProvider that do the splitting. Use the pipe "|" character instead of a colon to separate the category from the within_category_id to prevent mistakes when implementing a ContentSuggestionsProvider: Accidentally splitting a URL (which might already be the within_category_id) instead of the unique_id fails silently because URLs contain a colon. Using a different separator prevents this. BUG= 619560 Review-Url: https://codereview.chromium.org/2155243003 Cr-Commit-Position: refs/heads/master@{#406268} [modify] https://crrev.com/0cde3173b62fee4162a93fe497f8df2597c5e49e/components/ntp_snippets/content_suggestions_provider.cc [modify] https://crrev.com/0cde3173b62fee4162a93fe497f8df2597c5e49e/components/ntp_snippets/content_suggestions_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27632ab6ad198cc8aceec6d50930bea0c2d8faef commit 27632ab6ad198cc8aceec6d50930bea0c2d8faef Author: pke <pke@google.com> Date: Mon Jul 25 10:20:25 2016 Change NTPSnippetsBridge to read from ContentSuggestionsService Change the NTPSnippetsBridge to receive ContentSuggestions from the new ContentSuggestionsService instead of receiving NTPSnippets directly from the NTPSnippetsService. Change the bridge/UI to receive and handle the ContentSuggestionsCategoryStatus instead of the state and DisabledReason from the NTPSnippetsStatusService. Modify the implementations of NTPSnippetsService ::DiscardSuggestion and ::FetchSuggestionImage to accept combined unique_ids instead of within_category_ids, which they wrongly accepted before. The new implementations conform to the ContentSuggestionsProvider interface and these two methods should not be called directly on the NTPSnippetsService with an ID of a NTPSnippet anymore (as it would now fail). BUG= 619560 Review-Url: https://codereview.chromium.org/2158883002 Cr-Commit-Position: refs/heads/master@{#407441} [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusListItem.java [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleListItem.java [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/chrome/browser/android/ntp/ntp_snippets_bridge.h [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/content_suggestion.h [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/content_suggestions_category_status.cc [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/content_suggestions_category_status.h [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/27632ab6ad198cc8aceec6d50930bea0c2d8faef/components/ntp_snippets/ntp_snippets_status_service.h
Design changes for dynamic sections and section ordering: https://docs.google.com/document/d/1IIAJFjurH-pwI7QI3fbTegXP4wjXnLhcktIwZyjx1ok/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc3ed5d9ca70635cf707d94cbdac78f9902b96ef commit cc3ed5d9ca70635cf707d94cbdac78f9902b96ef Author: pke <pke@google.com> Date: Wed Jul 27 08:47:08 2016 Show content suggestions from all categories on the NTP Currently, the NTP UI only supports a single section of content suggestions. Therefore, the available content suggestions from all categories are displayed in a single category to allow experimenting with new ContentSuggestionProviders until the UI supports separate sections. BUG= 619560 ,616090 Review-Url: https://codereview.chromium.org/2184683002 Cr-Commit-Position: refs/heads/master@{#408078} [modify] https://crrev.com/cc3ed5d9ca70635cf707d94cbdac78f9902b96ef/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/cc3ed5d9ca70635cf707d94cbdac78f9902b96ef/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1da90606faecfcd9ee888953ef7360037efd2ecb commit 1da90606faecfcd9ee888953ef7360037efd2ecb Author: pke <pke@google.com> Date: Fri Aug 05 14:20:27 2016 Call FetchImageCallback asynchronously when no thumbnail exists When a thumbnail image for a ContentSuggestion is requested by the UI and the thumbnail cannot be delivered for any reason, run the callback with an empty image asynchronously to be consistent with normal callback behaviors. BUG= 619560 Review-Url: https://codereview.chromium.org/2212313002 Cr-Commit-Position: refs/heads/master@{#410055} [modify] https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/1da90606faecfcd9ee888953ef7360037efd2ecb/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17361590f84745a69e0373e6482184e3bada6c3b commit 17361590f84745a69e0373e6482184e3bada6c3b Author: pke <pke@google.com> Date: Mon Aug 08 15:18:23 2016 Add per-section clearing and dismissed suggestions to snippets-internals Add new ClearCachedSuggestionsForDebugging, GetDismissedSuggestionsForDebugging and ClearDismissedSuggestionsForDebugging methods to the ContentSuggestionsProvider. Implement these methods in all existing providers. Adjust the unit tests. Call those methods from snippets-internals, build new internals UI for viewing dismissed suggestions and clearing suggestions per category. Remove now unused NTPSnippetsService-related things. BUG= 619560 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2222853004 Cr-Commit-Position: refs/heads/master@{#410360} [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/content_suggestions_provider.h [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc [modify] https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d61d048b670eb91e05a988e731a8f7f944c2bb commit 20d61d048b670eb91e05a988e731a8f7f944c2bb Author: jbudorick <jbudorick@chromium.org> Date: Mon Aug 08 15:49:14 2016 Revert of Add per-section clearing and dismissed suggestions to snippets-internals (patchset #3 id:40001 of https://codereview.chromium.org/2222853004/ ) Reason for revert: Appears to have broken compilation on Android Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/70928 Original issue's description: > Add per-section clearing and dismissed suggestions to snippets-internals > > Add new ClearCachedSuggestionsForDebugging, > GetDismissedSuggestionsForDebugging and > ClearDismissedSuggestionsForDebugging methods to the > ContentSuggestionsProvider. Implement these methods in all existing > providers. Adjust the unit tests. > > Call those methods from snippets-internals, build new internals UI for > viewing dismissed suggestions and clearing suggestions per category. > Remove now unused NTPSnippetsService-related things. > > BUG= 619560 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b > Cr-Commit-Position: refs/heads/master@{#410360} TBR=treib@chromium.org,bauerb@chromium.org,pke@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 619560 Review-Url: https://codereview.chromium.org/2223963002 Cr-Commit-Position: refs/heads/master@{#410365} [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/content_suggestions_provider.h [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc [modify] https://crrev.com/20d61d048b670eb91e05a988e731a8f7f944c2bb/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
The last CL was just reverted, so probably this is not fixed?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/151b550fbd93427200cfddd13c5fdea68ea38d86 commit 151b550fbd93427200cfddd13c5fdea68ea38d86 Author: pke <pke@google.com> Date: Tue Aug 09 12:15:13 2016 Add per-section clearing and dismissed suggestions to snippets-internals Add new ClearCachedSuggestionsForDebugging, GetDismissedSuggestionsForDebugging and ClearDismissedSuggestionsForDebugging methods to the ContentSuggestionsProvider. Implement these methods in all existing providers. Adjust the unit tests. Call those methods from snippets-internals, build new internals UI for viewing dismissed suggestions and clearing suggestions per category. Remove now unused NTPSnippetsService-related things. BUG= 619560 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2223073002 Cr-Commit-Position: refs/heads/master@{#410640} [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/chrome/browser/resources/snippets_internals.html [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/chrome/browser/resources/snippets_internals.js [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/chrome/browser/ui/webui/snippets_internals_message_handler.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/chrome/browser/ui/webui/snippets_internals_message_handler.h [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/content_suggestions_provider.h [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/content_suggestions_service.h [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/content_suggestions_service_unittest.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/ntp_snippets_service.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/ntp_snippets_service.h [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/ntp_snippets_service_unittest.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc [modify] https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
Comment 1 by nepper@chromium.org
, Jun 14 2016