New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619545 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 603386
issue 663536



Sign in to add a comment

Views combobox doesn't honor enter/space to open. Up/Down don't show the menu.

Reported by rk...@etouch.net, Jun 13 2016

Issue description

Chrome Version:53.0.2766.0 Revision e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363}
OS: Mac Pro (10.10.5, 11.11.4)

Pre-condition: Enable ‘Toolkit-Views Native-style Browser Dialogs’ and ‘Toolkit-Views WebUI-style Browser Dialogs’ flags

What steps will reproduce the problem?
1. Launch chrome, navigate to https://chrome.google.com/webstore/category/apps?hl=en
2. Click on 'View site information' icon, press 'Tab' key upto Focus reaches to 'Permissions'.
3. Hitt Enter or Spacebar and observe.

After hitting Enter or Spacebar drop down list under permissions does not get open.

After hitting Enter or Spacebar drop down list under permissions should be open.

This is a regression issue, broken in 'M-53', below is bisect info:

Good Build: 53.0.2763.0
Bad Build: 53.0.2764.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/bd78a9e4abd238929b9f97dfa52350294c9c9842..bd10cc1ecbbcc95f143d19911a6d3b81b8043d65?pretty=fuller&n=50

Suspecting: r399034

Note: Issue is not seen on Windows and Mac OS.
 
Actual_Video.mov
2.2 MB Download
Expected_Video.mov
2.4 MB Download

Comment 1 Deleted

Labels: -ReleaseBlock-Stable
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by rk...@etouch.net, Oct 3 2016

Just to update:

Above issue is reproducible on latest canary 55.0.2878.0
Labels: -hasbisect -M-54 -Type-Bug-Regression -MovedFrom-53 Phase1 Proj-MacViews Type-Bug
Summary: Views combobox doesn't honor enter/space to open (was: Regression: Hitting 'Enter' does't open drop down list under 'Permissions' of 'View site info' bubble.)
Components: -UI>Browser>Permissions UI>Browser>Bubbles>PageInfo
Probably related: Ctrl-Opt-Space doesn't open the combobox in MacViews with VoiceOver.
Screen Shot 2016-11-08 at 14.29.58.png
372 KB View Download
Blocking: 663536
In the interest of "one bug, one issue", I filed  Issue 663536 . Feel free to close both or dedup if the same fix turns out to cover both.
Heh, this is really weird:

If you hit space, nothing happens (bug #1)
If you hit enter, the menu opens as expected, but when you close the menu, the combobox moves to the left (??)

Looking.
> If you hit enter, the menu opens as expected, but when you close the menu, the combobox moves to the left (??)

This is  Issue 657284  (one of several layout issues).
Blocking: 603386
Cc: ellyjo...@chromium.org
Labels: M-58
Owner: karandeepb@chromium.org
This should be fixed for the harmony rollout.

Karan - it's probably related to  Issue 607430 . I.e.

1) Enter: only activate "Default" buttons, if any (otherwise: do nothing)
2) Space: only activate the current/focused button/combobox

Currently (2) works for buttons but not the combobox action (Enter on a combobox should do nothing).
Had also filed  issue 636669  for this. Marking it as a dupe.
Cc: karandeepb@chromium.org
 Issue 636669  has been merged into this issue.
Status: Started (was: Assigned)
Summary: Views combobox doesn't honor enter/space to open. Up/Down don't show the menu. (was: Views combobox doesn't honor enter/space to open)
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b412f671d94f869489023137ba2705785883614f

commit b412f671d94f869489023137ba2705785883614f
Author: karandeepb <karandeepb@chromium.org>
Date: Mon Jan 16 02:34:26 2017

MacViews: Correctly handle character events when there's an active TextInputClient.

Currently in insertTextInternal:, we do not generate a synthetic character event
for the View hierarchy when there's an active TextInputClient. Since a Space key
press generates an insertText: (or insertText:replacementRange:) action message,
this causes views::Combobox to not receive the space key press. This is because
views::Combobox uses the views::PrefixSelector TextInputClient when focused. As
a result, a space key press on a combobox does not currently open the combobox
dropdown.

To solve, generate key events for all character events in insertTextInternal:.
The key event is generated before calling TextInputClient::Insert[Char/Text]
which is similar to other platforms. However, the key event is not passed to the
View hierarchy in case there's active composition text, since it should be
consumed by the IME in that case.

Also, a new variable hasUnhandledKeyDownEvent_ is introduced on the
BridgedContentView so that keyDownEvent_ remains valid for the duration of
keyDown:. This is needed because a keyDown: can infact lead to multiple
insertText: action messages.

Also, combobox unittests are modified to use an EventGenerator to test key event
behavior to provide better coverage. (With an EventGenerator,
ComboboxTest.NotifyOnClickWithSpaceKey fails on the master).

BUG= 619545 ,  607429 
TEST=With chrome://flags/#secondary-ui-md on Mac, open the Bookmark bubble.
Enable Full Keyboard Access (Ctrl+F7). Focus the Folder combobox. Ensure
pressing space opens the combobox dropdown.

Review-Url: https://codereview.chromium.org/2624093002
Cr-Commit-Position: refs/heads/master@{#443832}

[modify] https://crrev.com/b412f671d94f869489023137ba2705785883614f/ui/views/cocoa/bridged_content_view.h
[modify] https://crrev.com/b412f671d94f869489023137ba2705785883614f/ui/views/cocoa/bridged_content_view.mm
[modify] https://crrev.com/b412f671d94f869489023137ba2705785883614f/ui/views/controls/combobox/combobox_unittest.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95da469f19599a040d9dd93fe443e89345a65509

commit 95da469f19599a040d9dd93fe443e89345a65509
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Jan 18 04:15:55 2017

MacViews: Fix combobox keyboard shortcuts.

This CL changes the following behavior on MacViews:
  - Return key on a focused combobox does nothing (It should perform the default
    action for the dialog).
  - Up/Down arrow keys open the combobox dropdown instead of changing the
    selected index directly.
  - Space key press on a combobox opens the dropdown menu even for STYLE_ACTION.
  - Home, End, Command+Up/Down open the dropdown menu.
  - F4, Page Down, Page Up on a focused combobox do nothing.

BUG= 619545 ,  607430 

Review-Url: https://codereview.chromium.org/2627013002
Cr-Commit-Position: refs/heads/master@{#444269}

[modify] https://crrev.com/95da469f19599a040d9dd93fe443e89345a65509/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/95da469f19599a040d9dd93fe443e89345a65509/ui/views/controls/combobox/combobox.h
[modify] https://crrev.com/95da469f19599a040d9dd93fe443e89345a65509/ui/views/controls/combobox/combobox_unittest.cc

Status: Fixed (was: Started)

Comment 20 by rk...@etouch.net, Feb 2 2017

Just to update:

Above issue is fixed on latest canary 58.0.3000.0

Thank you.
Labels: TE-Verified-M58 TE-Verified-58.0.3000.0
As per above comment #20 adding TE-verified labels

Sign in to add a comment