New issue
Advanced search Search tips

Issue 619528 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
rdevlin....@chromium.org
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Touching files below chrome/common/extensions/doc causes presubmit to take several minutes

Project Member Reported by thakis@chromium.org, Jun 13 2016 
I touched a file below chrome/common/extensions/doc today ( https://codereview.chromium.org/2059143002 ).

`git cl upload` needed over 9 minutes (!) to run presubmits as part of `git cl upload`; most of that due to extension docs.

That's way too long and just leads to me using --bypass-hooks for CLs touching that dir.

Comment 1 by asargent@chromium.org, Jul 8 2016

Cc: lazyboy@chromium.org rdevlin....@chromium.org catmulli...@chromium.org asargent@chromium.org
Status: Available (was: Untriaged)
Summary: Touching files below chrome/common/extensions/doc causes presubmit to take several minutes (was: Touching a file below chrome/common/extensions/doc causes presubmit to take several minutes)
I just made a couple of no-op test changes to some of the same files as the CL, and was able to reproduce the extreme slowness in git cl upload.

chrome/common/extensions/docs/server2/caching_file_system.py
chrome/common/extensions/docs/server2/new_github_file_system.py
chrome/common/extensions/docs/templates/articles/extensions_index.html

I'm guessing it's the changes to the .py files that cause this, not the .html, but haven't verified yet. 

cc'ing several of us on extensions team since we're hoping to refactor the docserver this quarter, and should try and fix this
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by catmulli...@chromium.org, Feb 8 2018

Cc: -catmulli...@chromium.org

Comment 4 by asargent@chromium.org, May 15 2018

Cc: -asargent@chromium.org
►

Sign in to add a comment