New issue
Advanced search Search tips

Issue 619526 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extension WasInstalledByCustodian flag is lost when the extension is pre-installed.

Project Member Reported by mamir@chromium.org, Jun 13 2016

Issue description

Extensions that are installed by custodians are marked with "WasInstalledByCustodian" creation flag to prohibit supervised users from uninstalling them.

If the same extension was both installed by custodian and preinstalled at Chrome browser before the child signs in, the flag is always reset to false ignoring the value stored at Sync server.

 

Comment 1 by fi...@chromium.org, Jun 15 2016

Status: Assigned (was: Untriaged)

Comment 2 by treib@chromium.org, Jun 15 2016

Status: Started (was: Assigned)
One more - I know for a fact that this is started (and, hopefully, even almost finished) :)

Comment 3 by mamir@chromium.org, Jun 22 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192d78833ff9297c754f59f20cb4e590d693a7c2

commit 192d78833ff9297c754f59f20cb4e590d693a7c2
Author: mamir <mamir@chromium.org>
Date: Wed Jun 22 17:10:16 2016

Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Before this CL:
If a custodian-installed extension was already installed in the
browser before the child signs in, the "WasInstalledByCustodian" flag is
stored in Sync was ignored and the default value (false) is used giving
the child the ability to uninstall the extension for example.

After this CL:
The creation flag has been replaced with a pref which is updated
properly upon receiving Sync data.

BUG= 619526 

Review-Url: https://codereview.chromium.org/2054773002
Cr-Commit-Position: refs/heads/master@{#401318}

[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_sync_data.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_sync_data.h
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_util.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/extension_util.h
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/pending_extension_info.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/pending_extension_info.h
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/pending_extension_manager.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/pending_extension_manager.h
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/chrome/browser/themes/theme_syncable_service.cc
[modify] https://crrev.com/192d78833ff9297c754f59f20cb4e590d693a7c2/extensions/common/extension.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e960964b7ea2caff5289d4a2f40488af7613389d

commit e960964b7ea2caff5289d4a2f40488af7613389d
Author: mamir <mamir@chromium.org>
Date: Tue Jun 28 22:17:54 2016

Supervised users initiated extensions installs

Supervised users can install apps and extension.  The extension will be
installed in a disabled state and an approval request will be sent to
their custodian.

If the custodian approves the request, the extension will be enabled.
If the custodian denies the request, the extension will be uninstalled.

BUG= 619526 

Review-Url: https://codereview.chromium.org/2004043002
Cr-Commit-Position: refs/heads/master@{#402570}

[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/extensions/extension_service_test_with_install.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/extensions/extension_util.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/legacy/permission_request_creator_sync.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/permission_request_creator.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_constants.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_constants.h
[add] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_features.cc
[add] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_features.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_pref_store.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_settings_service.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/browser/supervised_user/supervised_user_settings_service.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/chrome_browser.gypi
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/chrome_tests.gypi
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/common/pref_names.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/common/pref_names.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/test/BUILD.gn
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/test/DEPS
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/chrome/test/base/testing_profile.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/extensions/common/extension.h
[modify] https://crrev.com/e960964b7ea2caff5289d4a2f40488af7613389d/tools/metrics/histograms/histograms.xml

Comment 6 by mamir@chromium.org, Jun 29 2016

This revision https://chromium.googlesource.com/chromium/src.git/+/e960964b7ea2caff5289d4a2f40488af7613389d
doesn't refer to this bug.
The bug was added by mistake to it.
Cc: dhadd...@chromium.org
can this be verified yet? or are we waiting on issue 397951

Comment 8 by mamir@chromium.org, Oct 21 2016

Yes, it's indeed waiting on issue 397951
Status: Verified (was: Fixed)

Sign in to add a comment