New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619519 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Blank page appears after dragging url from omnibox on page.

Reported by vku...@etouch.net, Jun 13 2016

Issue description

Chrome Version: 53.0.2766.0 (Official Build) e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363} 32/64-bit.
OS:Mac (10.10.5 , 10.11.4),Mac Retina (10.11.4)

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://settings or any webpage.
2.Right click and select 'view page source' from context menu.
3.After loading the page drag url from omnibox onto the page and observe.

Actual: Blank page appears after dragging url of 'view page source' on  page.

Expected: Blank page should not be seen after dragging url of 'view page source' on page.

This is a regression issue broken in 'M53' and will soon update other info.
 

Comment 1 by vku...@etouch.net, Jun 13 2016

Components: UI>Browser>Omnibox
Labels: hasbisect OS-Linux OS-Windows
Owner: mea...@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 53.0.2756.0
Bad Build:  53.0.2757.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/5f94fda863b8540f99eb571b4f94c8dd24dba406..47379284a4a83df80f1f539e87a069164c558d2e?pretty=fuller&n=10

Suspecting: r397505 

Actual_Url.mov
866 KB Download
Expected_Url.mov
1.0 MB Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.

Comment 3 by mea...@chromium.org, Jun 13 2016

Cc: creis@chromium.org
Broken by r397505: We blocked page initiated navigations to view-source urls. I didn't know that dragging & dropping URLs into the page cause a page-initiated navigation, I'd expect them to be browser initiated.

Charlie, any thoughts? Do you think this is a wontfix?
This shouldn't be WontFix.  I think ideally this should be considered browser-initiated.

Comment 5 by mea...@chromium.org, Jun 13 2016

That's what I was thinking, but I'm not sure if there is an argument against it.
creis@ : Could you please take a look into this as issue still persists on the latest canary 53.0.2773.0

Comment 7 by creis@chromium.org, Jun 21 2016

Cc: dcheng@chromium.org
How is this a P1 stable blocker?  It only affects dragging view-source URLs into the content area.  That seems very uncommon to me, so I'd suggest lowering the priority to P2 and removing the blocking label.

I'm not sure if it's possible to treat dragged URLs as browser-initiated navigations or not.  dcheng@, do you know how dragged navigations work?

I imagine the renderer is the one that decides to translate the drag into a navigation (much like link clicks and other renderer-initiated navigations).  It seems problematic to say that the renderer can't do navigations to view-source URLs while allowing it to do drag navigations to them.  Wouldn't that make the protection in r397505 meaningless, such that a compromised renderer could always just say it's a drag operation?
Clearly we can't let the renderer make that determination.

At the risk of speaking out of my ignorance, I think the way this should work is that the renderer should decide whether something in the page content is going to consume the drag contents (e.g. for when you're dragging an image onto Google Image Search).  If nothing does, the browser is free to do a browser-initiated navigation of the renderer to the desired URL.

Comment 9 by dcheng@chromium.org, Jun 21 2016

Components: Blink>DataTransfer
It's possible to make this work. Basically, in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/DragController.cpp?rcl=0&l=274, we'd want to have it call back out to the browser to navigate on its behalf. In theory, pretty simple...
(The browser will have to save a copy of the URL, so the call out to the embedder would just be an IPC telling it to take a navigation with the drag data it already has)
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
based on c#7, reducing the priority and removing blocker label.

Please add if required.
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by vku...@etouch.net, Oct 3 2016

Note:Above issue is still reproducible on latest canary version i.e 55.0.2878.0 (Official Build)

Comment 14 by hush@chromium.org, Oct 21 2016

Cc: hush@chromium.org anthonyvd@chromium.org lfg@chromium.org
 Issue 622589  has been merged into this issue.
Components: -Blink>DataTransfer -UI>Browser>Options UI>Browser>Navigation
Labels: -Pri-2 Hotlist-Polish Pri-3
Still reproduces (dragging a view-source: URL to the content area causes a navigation to about:blank).

meacer@, are you still planning to fix this?

Removing DataTransfer and Options components, adding Navigation component.

Labels: -M-54
> meacer@, are you still planning to fix this?

It's low priority, so yes but not anytime soon. If anyone else is interested, please feel free to take it.

Sign in to add a comment