Issue metadata
Sign in to add a comment
|
Regression : Blue focus highlight is seen broken in www.showroom.ford.com.
Reported by
mni...@etouch.net,
Jun 13 2016
|
||||||||||||||||||||||||
Issue descriptionVersion: 53.0.2766.0 e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS) URL : http://www.showroom.ford.com/FDShowroom.jsp What steps will reproduce the problem? 1) Launch chrome and navigate to above url. 2) Click on 'Search' icon and click inside search box so blue focus highlight is seen around search box. 3) Now click on '>' icon in search box and place the mouse hand pointer on '>' icon for a while and observe the blue focus highlight Actual : Blue focus highlight is seen broken Expected : Blue focus highlight should be seen properly This is a regression issue broken in 'M-52' and below is the manual regression and Narrow bisect info: Good build : 52.0.2711.0 Bad build : 52.0.2712.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/74d1a68fa838d973b6104ddb4af4d88881fb901c..de7ae34361ba945b6d1ec7b3c679fecf5d94d35b?pretty=fuller&n=50 Suspecting : r387861 from Narrow bisect @kochi : Could you please help to reassign if your change is not the cause for this change. Note : Issue is not seen in Mac OS.
,
Jun 13 2016
Can someone in Paint team take this issue?
,
Jun 13 2016
More likely https://chromium.googlesource.com/chromium/src/+/de7ae34361ba945b6d1ec7b3c679fecf5d94d35b But I could not repro on Linux ToT.
,
Jun 13 2016
robhogan@ can you take a look?
,
Jun 15 2016
Please have a fix ready and merge it to M52 branch once it is baked in Canary before 6/22 so that it can be picked up for next beta promotion.
,
Jun 16 2016
I will get to this in a few days. I don't believe it's a release blocker, it seems hard to reproduce reliably.
,
Jun 17 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 23 2016
,
Jun 26 2016
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/488de59908c1faab11124da600aabd5708df6e75 commit 488de59908c1faab11124da600aabd5708df6e75 Author: robhogan <robhogan@gmail.com> Date: Wed Jun 29 00:56:41 2016 Calc overflow on the positioned descendants of tables Tables can be the containing block for positioned objects too, so when we take over the overflow calc duties from LayoutBlock we need to cater for positioned objects like it does too. I also spotted an error in LayoutTable::recalcChildOverflowAfterStyleChange() - we need to recalc overflow for all sections regardless of whether a section has already changed its overflow. BUG= 619510 Review-Url: https://codereview.chromium.org/2100343002 Cr-Commit-Position: refs/heads/master@{#402626} [add] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table-expected.html [add] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table-expected.txt [add] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/LayoutTests/fast/repaint/input-overflow-in-table.html [modify] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/Source/core/layout/LayoutBlock.cpp [modify] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/Source/core/layout/LayoutBlock.h [modify] https://crrev.com/488de59908c1faab11124da600aabd5708df6e75/third_party/WebKit/Source/core/layout/LayoutTable.cpp
,
Jul 5 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
Does the commit in comment #10 fix this? Is it worth merging into m52 before it hits Stable?
,
Jul 18 2016
I think it's low impact. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Jun 13 2016