New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619507 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.6% regression in thread_times.key_idle_power_cases at 399254:399307

Project Member Reported by oth@chromium.org, Jun 13 2016

Issue description

See the link to graphs below.
 

Comment 1 by oth@chromium.org, Jun 13 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=619507

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_KbZsQoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 13 2016

Cc: dpranke@chromium.org
Owner: dpranke@chromium.org

=== Auto-CCing suspected CL author dpranke@chromium.org ===

Hi dpranke@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Change //build/config/compiler:optimize_max to use -O3. (patchset #1 id:1 of https://codereview.chromium.org/2048163002/ )
Author  : dpranke
Commit description:
  
Reason for revert:
Reverting, this caused a size regression for cronet that is more important to them than any likely perf gains.

I'll re-land a different CL that's less broad.

Original issue's description:
> Change //build/config/compiler:optimize_max to use -O3.
>
> Certain components (e.g., v8) really want to be compiled with -O3,
> but the current ":optimize_max" setting just used -O2. Since "max"
> should theoretically mean "max", let's try making it be -O3 across
> the board and see what happens.
>
> R=brettw@chromium.org
> BUG= 616031 
>
> Committed: https://crrev.com/96a6dfa2c30ab9b22abd20c87ed0e0d6ae41c40e
> Cr-Commit-Position: refs/heads/master@{#398704}

TBR=brettw@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 616031 

Review-Url: https://codereview.chromium.org/2062433002
Cr-Commit-Position: refs/heads/master@{#399276}
Commit  : c4dc398543c8a7cbd4b5f8bfe3495d6182dc3f19
Date    : Fri Jun 10 21:43:15 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev     N  Good?
chromium@399253  0.30376   0.00596041  5  good
chromium@399267  0.301652  0.0021703   5  good
chromium@399274  0.300744  0.001937    5  good
chromium@399275  0.301895  0.00121107  5  good
chromium@399276  0.32143   0.00276636  5  bad    <--
chromium@399277  0.321739  0.00157799  5  bad
chromium@399280  0.320732  0.00248452  5  bad
chromium@399307  0.32116   0.00183886  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 619507

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: thread_total_all_cpu_time_per_second/animated-gif.html
Relative Change: 5.73%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1351
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981374486762512


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5836416823590912

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Change //build/config/compiler:optimize_max to use -O3. (patchset #1 id:1 of https://codereview.chromium.org/2048163002/ )
Author  : dpranke
Commit description:
  
Reason for revert:
Reverting, this caused a size regression for cronet that is more important to them than any likely perf gains.

I'll re-land a different CL that's less broad.

Original issue's description:
> Change //build/config/compiler:optimize_max to use -O3.
>
> Certain components (e.g., v8) really want to be compiled with -O3,
> but the current ":optimize_max" setting just used -O2. Since "max"
> should theoretically mean "max", let's try making it be -O3 across
> the board and see what happens.
>
> R=brettw@chromium.org
> BUG= 616031 
>
> Committed: https://crrev.com/96a6dfa2c30ab9b22abd20c87ed0e0d6ae41c40e
> Cr-Commit-Position: refs/heads/master@{#398704}

TBR=brettw@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 616031 

Review-Url: https://codereview.chromium.org/2062433002
Cr-Commit-Position: refs/heads/master@{#399276}
Commit  : c4dc398543c8a7cbd4b5f8bfe3495d6182dc3f19
Date    : Fri Jun 10 21:43:15 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev      N  Good?
chromium@399253  0.302429  0.00739462   5  good
chromium@399267  0.301729  0.00173286   5  good
chromium@399274  0.301289  0.00442134   5  good
chromium@399275  0.300418  0.00230071   5  good
chromium@399276  0.319682  0.00210824   5  bad    <--
chromium@399277  0.320359  0.00229677   5  bad
chromium@399280  0.321123  0.0020214    5  bad
chromium@399307  0.321055  0.000797155  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 619507

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: thread_total_all_cpu_time_per_second/animated-gif.html
Relative Change: 6.16%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1350
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981381425278352


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5864830985043968

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
The revert was intentional and expected to cause regressions. The need to get things back on -O3 is tracked in  bug 616031 , so there's no need to track this here as well.

Sign in to add a comment