New issue
Advanced search Search tips

Issue 619505 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

17.7% regression in blink_perf.events at 399168:399187

Project Member Reported by oth@chromium.org, Jun 13 2016

Issue description

See the link to graphs below.
 

Comment 1 by oth@chromium.org, Jun 13 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=619505

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_KauoAoM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 13 2016

Cc: yosin@chromium.org
Owner: yosin@chromium.org

=== Auto-CCing suspected CL author yosin@chromium.org ===

Hi yosin@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Introduce CustomElementRegistry#whenDefined() method
Author  : yosin
Commit description:
  
This patch introduces |CustomElementRegistry#whenDefined()| as specified in [1],
and makes |CustomElementRegistry::define()| to resolve a promise associated to
newly defined name.

[1] // https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-whendefined

BUG= 594918 
TEST=LayoutTests/custom-elements/spec/custom-elements-registry/when_defined.html

Review-Url: https://codereview.chromium.org/2048343002
Cr-Commit-Position: refs/heads/master@{#399171}
Commit  : 52523d4e58d99cdb768791bf9ac532c917522460
Date    : Fri Jun 10 13:26:25 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@399167  236.988  2.90351  5  good
chromium@399170  249.108  3.29798  5  good
chromium@399171  167.517  2.26814  5  bad    <--
chromium@399172  167.994  1.11113  5  bad
chromium@399177  165.462  2.40658  5  bad
chromium@399187  166.628  1.48279  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 619505

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.events
Test Metric: EventsDispatching/EventsDispatching
Relative Change: 29.69%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/705
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981471892738192


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5871599316631552

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Introduce CustomElementRegistry#whenDefined() method
Author  : yosin
Commit description:
  
This patch introduces |CustomElementRegistry#whenDefined()| as specified in [1],
and makes |CustomElementRegistry::define()| to resolve a promise associated to
newly defined name.

[1] // https://html.spec.whatwg.org/multipage/scripting.html#dom-customelementsregistry-whendefined

BUG= 594918 
TEST=LayoutTests/custom-elements/spec/custom-elements-registry/when_defined.html

Review-Url: https://codereview.chromium.org/2048343002
Cr-Commit-Position: refs/heads/master@{#399171}
Commit  : 52523d4e58d99cdb768791bf9ac532c917522460
Date    : Fri Jun 10 13:26:25 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@399167  242.931  2.77214   5  good
chromium@399170  249.379  3.01671   5  good
chromium@399171  167.81   0.606064  5  bad    <--
chromium@399172  165.8    1.77607   5  bad
chromium@399177  165.215  1.6556    5  bad
chromium@399187  167.208  1.6176    5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 619505

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.events
Test Metric: EventsDispatching/EventsDispatching
Relative Change: 31.17%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/706
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981465698745104


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5879641911328768

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by yosin@chromium.org, Jun 27 2016

Status: WontFix (was: Assigned)
Mark WontFix, since
 - my patch can't affect the test; new method CustomElementsRegistry#whenDefined()
 - perf is recovered in range 399400 - 399407 

Sign in to add a comment