New issue
Advanced search Search tips

Issue 619502 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

16.6% regression in blink_perf.bindings at 399264:399287

Project Member Reported by oth@chromium.org, Jun 13 2016

Issue description

See the link to graphs below.
 

Comment 1 by oth@chromium.org, Jun 13 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=619502

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_LSruwoM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 13 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@399263  88.3273  26.317   18  good
chromium@399287  95.1688  28.6175  18  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 619502

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: serialize-long-string/serialize-long-string
Relative Change: 1.44%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/218
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981713446251936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5889996809043968

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2016

Cc: rouslan@chromium.org
Owner: rouslan@chromium.org

=== Auto-CCing suspected CL author rouslan@chromium.org ===

Hi rouslan@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add billing address identifier to WalletMaskedCard.
Author  : rouslan
Commit description:
  
BUG= 602663 

Review-Url: https://codereview.chromium.org/2058513002
Cr-Commit-Position: refs/heads/master@{#399278}
Commit  : f92801e56ecb266525bc52a6a398db8affbc6247
Date    : Fri Jun 10 21:48:18 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@399263  65.8985  0.902027  8  good
chromium@399275  66.3391  0.845887  8  good
chromium@399277  68.2896  0.505749  5  good
chromium@399278  70.5142  0.33966   5  bad    <--
chromium@399281  70.8104  0.181885  5  bad
chromium@399287  67.8654  0.723415  8  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 619502

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: serialize-long-string/serialize-long-string
Relative Change: 2.68%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/217
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009981718327571936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5898941883744256

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Don't think the bisect is accurate. oth@: If we temporarily revert my patch, how long till we know whether the benchmark has recovered?
Owner: dpranke@chromium.org
rouslan: sorry about that! I reported the bisect job as incorrect. Looking at the graph up and down pattern, this is almost certainly the revert of https://codereview.chromium.org/2048163002.

dpranke: based on CL description I think this is WontFix?
Status: WontFix (was: Assigned)
Well, it's good to know that -O3 does improve perf benchmarks somewhere :).

Yes, we still want -O3 enabled in some places, but since that's tracked in  bug 616031 , I think it's fine to WontFix this.

Sign in to add a comment