Regression: Alarm extension icon is not properly on setting the alarm time.
Reported by
dmascare...@etouch.net,
Jun 13 2016
|
|||
Issue descriptionChrome Version:53.0.2766.0 (Official Build) e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363} 32/64 bit OS:Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). Test url: https://chrome.google.com/webstore/detail/alarm/fdjkdjnaajdmnminlhhhcicfnokdhjfg/related?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome and navigate to above url, click on ‘Add to chrome’. 2. Click on extension icon seen at browser action container and set some time, description then click on ‘Add’ button. 3. Observe. Actual: Alarm extension icon is not properly on setting the alarm time. Expected: Alarm extension icon should be seen properly on setting the alarm time. This is regression issue,broken in ‘M 51’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/a6c42bddb0ce6253b7da6f3b66460a243071d04f..dd5ed50fcfaba45855d3a3c63084e74011dd6166?pretty=fuller&n=100 Suspecting: r378233 Good build: 51.0.2663.0 Bad build: 51.0.2664.0
,
Jun 24 2016
the only reason this looks bad is because the badge is specifying a partially transparent bg color and that messes up subpixel anti-aliasing. We can either disable subpixel AA on this text or we can force the bg color to be opaque (or blend it onto some other opaque color, like black). Here is one possible solution: https://codereview.chromium.org/2093973002
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b16eadaef85aa0128bf4f74fb96270f0a2479b78 commit b16eadaef85aa0128bf4f74fb96270f0a2479b78 Author: estade <estade@chromium.org> Date: Mon Jun 27 16:34:29 2016 Ignore alpha value in extension-specified badge bg color. (Force full opacity.) BUG= 619499 Review-Url: https://codereview.chromium.org/2093973002 Cr-Commit-Position: refs/heads/master@{#402198} [modify] https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
,
Jun 29 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Jun 23 2016Owner: est...@chromium.org