New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619495 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 619490
Owner:
Last visit > 30 days ago
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

30.8% regression in blink_perf.dom at 399254:399307

Project Member Reported by oth@chromium.org, Jun 13 2016

Issue description

See the link to graphs below.
 

Comment 1 by oth@chromium.org, Jun 13 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=619495

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_L3moAoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 13 2016

Mergedinto: 619490
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reserve enough vertical space for the menuList layout element setting its logical height to the max option height.
Author  : glebl
Commit description:
  
The option's height is calculated from option's text FloatRect generated by CachingWordShaper.

BUG= 484632 

TEST=fast/forms/select/menulist-height-change.html

Review-Url: https://codereview.chromium.org/2055593002
Cr-Commit-Position: refs/heads/master@{#399293}
Commit  : 4681903723a0df535a60069ec9f7d6ea21fe69d0
Date    : Fri Jun 10 22:16:58 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@399253  15.0265  0.149779   5  good
chromium@399280  15.0664  0.153293   5  good
chromium@399287  15.039   0.103119   5  good
chromium@399291  15.16    0.115856   5  good
chromium@399292  15.1107  0.0863086  5  good
chromium@399293  10.256   0.109447   5  bad    <--
chromium@399294  10.3204  0.0375798  5  bad
chromium@399307  10.0507  0.0483993  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 619495

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.dom
Test Metric: select-multiple-add/select-multiple-add
Relative Change: 33.11%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1348
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009983549196367088


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5772483551035392

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 13 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reserve enough vertical space for the menuList layout element setting its logical height to the max option height.
Author  : glebl
Commit description:
  
The option's height is calculated from option's text FloatRect generated by CachingWordShaper.

BUG= 484632 

TEST=fast/forms/select/menulist-height-change.html

Review-Url: https://codereview.chromium.org/2055593002
Cr-Commit-Position: refs/heads/master@{#399293}
Commit  : 4681903723a0df535a60069ec9f7d6ea21fe69d0
Date    : Fri Jun 10 22:16:58 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@399253  14.8625  0.0942052  5  good
chromium@399280  14.8884  0.105196   5  good
chromium@399287  14.9707  0.0627423  5  good
chromium@399291  14.9591  0.0851896  5  good
chromium@399292  15.0115  0.1125     5  good
chromium@399293  10.1836  0.077041   5  bad    <--
chromium@399294  10.1599  0.0441345  5  bad
chromium@399307  10.1492  0.0746043  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 619495

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.dom
Test Metric: select-multiple-add/select-multiple-add
Relative Change: 31.71%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1349
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009983541751864608


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5891459245408256

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment