Issue metadata
Sign in to add a comment
|
24.1% regression in blink_perf.dom at 399281:399348 |
||||||||||||||||||||
Issue descriptionPerf regression per title.
,
Jun 13 2016
=== Auto-CCing suspected CL author glebl@chromium.org === Hi glebl@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reserve enough vertical space for the menuList layout element setting its logical height to the max option height. Author : glebl Commit description: The option's height is calculated from option's text FloatRect generated by CachingWordShaper. BUG= 484632 TEST=fast/forms/select/menulist-height-change.html Review-Url: https://codereview.chromium.org/2055593002 Cr-Commit-Position: refs/heads/master@{#399293} Commit : 4681903723a0df535a60069ec9f7d6ea21fe69d0 Date : Fri Jun 10 22:16:58 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@399280 45.087 0.302836 5 good chromium@399289 45.0391 0.120569 5 good chromium@399291 44.9017 0.209867 5 good chromium@399292 45.0278 0.108512 5 good chromium@399293 32.6061 0.138498 5 bad <-- chromium@399297 32.4522 0.205166 5 bad chromium@399314 32.1989 0.663933 5 bad chromium@399348 31.6926 0.0759961 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 619490 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.dom Test Metric: select-multiple-add/select-multiple-add Relative Change: 29.71% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/700 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009984406000955440 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5251448451891200 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 13 2016
=== Auto-CCing suspected CL author erikchen@chromium.org === Hi erikchen@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Add tracing for DescheduleUntilFinishedCHROMIUM. Author : erikchen Commit description: This makes it easier to track down problems with chrome://tracing. This should have no functional effect. BUG= 617249 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2060533002 Cr-Commit-Position: refs/heads/master@{#399317} Commit : 29277336774a776985a04c57fc6a61c2ac3ab4af Date : Fri Jun 10 23:39:56 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@399280 41.3371 10.844 8 good chromium@399314 32.5138 0.18532 5 good chromium@399316 32.7652 0.0372375 5 good chromium@399317 30.0068 0.29471 5 bad <-- chromium@399319 30.1794 0.0754174 5 bad chromium@399323 29.3945 0.0433517 5 bad chromium@399331 30.5395 0.0459987 5 bad chromium@399348 31.751 0.0809224 8 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 619490 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.dom Test Metric: select-multiple-add/select-multiple-add Relative Change: 18.74% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/699 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009984421504634576 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5855036312125440 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 13 2016
It seems pretty unlikely that adding a single trace statement caused a 24.1% regression. Is there a tag we can add for bad bisects?
,
Jun 13 2016
,
Jun 13 2016
,
Jun 13 2016
erikchen: please click the "Not what you expected" link in the comment from the bisect bot to get it on our triage list.
,
Jun 22 2016
closing this one as the performance metrics got back to normal after 2 patches http://crrev.com/2077343002 and http://crrev.com/2066073002 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by oth@chromium.org
, Jun 13 2016