New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619466 link

Starred by 3 users
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Jun 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : "BROWSE AS GUEST" and "ADD PERSON" Buttons are seen in User Manager window even unchecked in chrome://settings page

Project Member Reported by mm00333...@techmahindra.com, Jun 13 2016 
Version: 53.0.2766.0
OS: Ubuntu 14.04,Windows

Pre-condition: Enable 'Material Design User Manager' flag from 'chrome://flags'

What steps will reproduce the problem?
(1)Launch chrome -> Go to chrome://settings page
(2)Now under people section uncheck "Enable Guest browsing", "Let anyone add a person to chrome" options
(3)Now  click on avatar icon -> Click on 'Switch person' option for User Manager window and observe "BROWSE AS GUEST" and "ADD PERSON" Buttons (Please refer Video and screenshots)

Expected:  "BROWSE AS GUEST" and "ADD PERSON" Buttons should not be seen in User Manager window 
Actual: Instead  "BROWSE AS GUEST" and "ADD PERSON" Buttons are seen in User Manager window 

This is Regression Issue broken in M-53
will provide bisect info soon
Actual_UserManager.ogv
1.4 MB View Download
Actual_UserManager.png
124 KB View Download
Expected_UserManager.ogv
1002 KB View Download
Expected_UserManager.png
464 KB View Download

Comment 1 by mm00333...@techmahindra.com, Jun 13 2016

Components: UI>Browser>Profiles
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)
Note:  Unable to Navigate to guest window On clicking "BROWSE AS GUEST" button whereas able to add person on clicking "ADD PERSON" button 

Manual good and Bad Builds:
Good Build: 53.0.2764.0
Bad Build:  53.0.2765.0

Below is the Bisect info:

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02..c7f4eacdb5de838a2d6f30d140c070deadd5c893

Suspecting https://codereview.chromium.org/2053723002 from above changelog

@mahmadi : Please feel free to re-assign if its not related to your change

Comment 2 by ajha@chromium.org, Jun 13 2016

Labels: OS-Mac
Reproducible on 53.0.2766.0 on Mac OS 10.11.5 as well.

Comment 3 by mahmadi@chromium.org, Jun 13 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de5b1233eab1d73a43be8818a5af3d520e41b4b

commit 9de5b1233eab1d73a43be8818a5af3d520e41b4b
Author: mahmadi <mahmadi@chromium.org>
Date: Mon Jun 13 20:06:32 2016

MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG= 619466 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2063623003
Cr-Commit-Position: refs/heads/master@{#399516}

[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/control_bar.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/supervised_user_learn_more.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/user_manager_dialog.html
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de5b1233eab1d73a43be8818a5af3d520e41b4b

commit 9de5b1233eab1d73a43be8818a5af3d520e41b4b
Author: mahmadi <mahmadi@chromium.org>
Date: Mon Jun 13 20:06:32 2016

MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG= 619466 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2063623003
Cr-Commit-Position: refs/heads/master@{#399516}

[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/control_bar.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/supervised_user_learn_more.html
[modify] https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b/chrome/browser/resources/md_user_manager/user_manager_dialog.html

Comment 6 by mm00333...@techmahindra.com, Jun 15 2016 

Issue is still seen in Build 53.0.2768.0 whose Version is 399800 which is higher than Commit-Position 399516 (As per comment #5). Attaching Screenshot for reference
IssueIn53.0.2768.0Build.png
184 KB View Download

Comment 7 by mahmadi@chromium.org, Jun 15 2016

Status: Fixed (was: Started)
mm00333839@ we recently landed a change for the new User Manager to ignore the preferences in the chrome://settings and display the buttons at all time. If all profiles are locked the user should see error messages when trying to interact with them.

Comment 8 by mm00333...@techmahindra.com, Jul 13 2016 

@mahmadi : As per comment #7 "BROWSE AS GUEST" and "ADD PERSON" Buttons should be seen even on unchecking the options("Enable Guest browsing", "Let anyone add a person to chrome") in chrome://settings page but in 54.0.2794.0 Build Buttons are not displayed on unchecking (Please refer Video)
Please clarify whether it is intended change or not?
Actual_Uncheck.ogv
842 KB View Download

Comment 9 by mahmadi@chromium.org, Jul 13 2016 

Thanks for checking. yes, this is an intended changed b/c those two options are also policy-controlled and have to be respected. Changes landed in:
https://codereview.chromium.org/2128093002

Note that, those options will be eliminated in the new settings page and will practically be ignored unless controlled by policy.
►

Sign in to add a comment