Issue 619452 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	xiaoche...@chromium.org
Closed:	Aug 2016
Cc:	editing-dev@chromium.org
Components:	Blink>Editing
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

Blocked on:
issue 619408
issue 633509
issue 633510

Get rid of grammar checking related code

Project Member Reported by yosin@chromium.org, Jun 13 2016

Issue description

Since Blink doesn't support grammar checking, we should get rid of them to simplify Blink code base.

Comment 1 by yosin@chromium.org, Jun 13 2016

Blockedon: 619408

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea953678df513eff2c4e128d8849ab05e0031198

commit ea953678df513eff2c4e128d8849ab05e0031198
Author: yosin <yosin@chromium.org>
Date: Mon Jun 13 08:27:12 2016

Get rid of useless function HitTestResult::spellingToolTip()

This patch gets rid of useless function |HitTestResult::spellingToolTip()|,
which returns result of grammar checking, since Blink doesn't support grammar
checking, to simplify source code for improving code health.

BUG=619452
TEST=n/a; no user visible changes

Review-Url: https://codereview.chromium.org/2059093002
Cr-Commit-Position: refs/heads/master@{#399417}

[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/layout/HitTestResult.h
[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/page/ChromeClient.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea953678df513eff2c4e128d8849ab05e0031198

commit ea953678df513eff2c4e128d8849ab05e0031198
Author: yosin <yosin@chromium.org>
Date: Mon Jun 13 08:27:12 2016

Get rid of useless function HitTestResult::spellingToolTip()

This patch gets rid of useless function |HitTestResult::spellingToolTip()|,
which returns result of grammar checking, since Blink doesn't support grammar
checking, to simplify source code for improving code health.

BUG=619452
TEST=n/a; no user visible changes

Review-Url: https://codereview.chromium.org/2059093002
Cr-Commit-Position: refs/heads/master@{#399417}

[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/layout/HitTestResult.h
[modify] https://crrev.com/ea953678df513eff2c4e128d8849ab05e0031198/third_party/WebKit/Source/core/page/ChromeClient.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00e7954de686c4f376c5eae0cdf367f842f263b0

commit 00e7954de686c4f376c5eae0cdf367f842f263b0
Author: yosin <yosin@chromium.org>
Date: Mon Jun 27 05:02:10 2016

Make SpellChecker::respondToChangedSelection() to update layout tree explicitly

This patch makes |SpellChecker::respondToChangedSelection()| to update layout
tree explicitly for preparation of getting rid of grammar checking related code.

A test expectation of fast/repaint/inline-outline-repaint.html is updated, since
this patch reduced number of update test tree in |respondToChangedSelection()|
by calling |inShadowIncludingDocument()| before |isContentEditable()|, which
updates layout tree.

This patch is also a preparation of crrev.com/2089993003, Get rid of
|EUpdateStyle| parameter from |isEditablePosition()|.

BUG=619452, 623005
TEST=n/a; no user visible changes

Review-Url: https://codereview.chromium.org/2092063002
Cr-Commit-Position: refs/heads/master@{#402115}

[modify] https://crrev.com/00e7954de686c4f376c5eae0cdf367f842f263b0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/00e7954de686c4f376c5eae0cdf367f842f263b0/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5352007c7fa97275fa9357c1b373843e9d6bba9

commit f5352007c7fa97275fa9357c1b373843e9d6bba9
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Jun 27 06:35:17 2016

Auto-rebaseline for r402115

https://chromium.googlesource.com/chromium/src/+/00e7954de

BUG=619452
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/2100053002 .

Cr-Commit-Position: refs/heads/master@{#402125}

[modify] https://crrev.com/f5352007c7fa97275fa9357c1b373843e9d6bba9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f5352007c7fa97275fa9357c1b373843e9d6bba9/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.txt
[modify] https://crrev.com/f5352007c7fa97275fa9357c1b373843e9d6bba9/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-outline-repaint-expected.txt
[modify] https://crrev.com/f5352007c7fa97275fa9357c1b373843e9d6bba9/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.txt

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be44d0ea538814bb21fd76bf562b4247c10f5f9b

commit be44d0ea538814bb21fd76bf562b4247c10f5f9b
Author: yosin <yosin@chromium.org>
Date: Wed Jun 29 04:25:25 2016

Make SpellChecker::didBeginEdit() not to crash with elements editing ignore content

This patch makes |SpellChecker::didBeginEdit()| not to pass an element
which returns true for |editingIgnoresContent(element)|, since
|selectionFromContentsOfNode(element)| doesn't accept such elements, to avoid
crash with such elements.

Since test runner sets false for |unifiedTextCheckerEnabled()|, we have not
been aware this. Following patch will make |unifiedTextCheckerEnabled()|
to return true always.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes

Review-Url: https://codereview.chromium.org/2109543002
Cr-Commit-Position: refs/heads/master@{#402714}

[modify] https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b/third_party/WebKit/LayoutTests/editing/execCommand/append-node-under-document-expected.txt
[modify] https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b/third_party/WebKit/LayoutTests/editing/execCommand/append-node-under-document.html
[modify] https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b/third_party/WebKit/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html
[modify] https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5

commit 7b6cfcb832a6ba764490517eb23dd4f616ebd0a5
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 06:20:06 2016

Convert editing/deleting/delete-3928305-fix.html to use w3c test harness

This patch converts "editing/deleting/delete-3928305-fix.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170753003
Cr-Commit-Position: refs/heads/master@{#407080}

[modify] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-3928305-fix-expected.png
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-3928305-fix-expected.txt
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-3928305-fix-expected.png
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-3928305-fix-expected.txt
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-3928305-fix-expected.png
[delete] https://crrev.com/6577e9c2199e226fb59c1b15fcc8dc89e245752b/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-3928305-fix-expected.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6b8de688c8572005dae1c30375bcae08bcd7e3a

commit b6b8de688c8572005dae1c30375bcae08bcd7e3a
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 06:34:35 2016

Convert editing/deleting/delete-and-undo.html to use w3c test harness

This patch converts "editing/deleting/delete-and-undo.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2164243002
Cr-Commit-Position: refs/heads/master@{#407081}

[modify] https://crrev.com/b6b8de688c8572005dae1c30375bcae08bcd7e3a/third_party/WebKit/LayoutTests/editing/deleting/delete-and-undo.html
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-and-undo-expected.png
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-and-undo-expected.txt
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-and-undo-expected.png
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-and-undo-expected.txt
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-and-undo-expected.png
[delete] https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-and-undo-expected.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee02461978cc4c62832472126900f9b868e04153

commit ee02461978cc4c62832472126900f9b868e04153
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 06:48:02 2016

Convert editing/deleting/delete-tab-[1234].html to use w3c test harness

This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172943002
Cr-Commit-Position: refs/heads/master@{#407085}

[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/editing/deleting/delete-tab-001.html
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/editing/deleting/delete-tab-002.html
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/editing/deleting/delete-tab-003.html
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/editing/deleting/delete-tab-004.html
[add] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/editing/deleting/delete_tab.html
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-001-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-001-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-002-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-002-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-003-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-003-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-004-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-tab-004-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-001-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-001-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-002-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-002-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-003-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-003-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-004-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-tab-004-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-001-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-001-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-002-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-002-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-003-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-003-expected.txt
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-004-expected.png
[delete] https://crrev.com/e98926775a397000c50afc25234c21e7022fa7e7/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-tab-004-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54194784a446c68c87b44a41a2950c28ab384302

commit 54194784a446c68c87b44a41a2950c28ab384302
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 06:48:44 2016

Convert editing/deleting/delete-contiguous-ws-001.html to use w3c test harness

This patch converts "editing/deleting/delete-contiguous-ws-001.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2169263003
Cr-Commit-Position: refs/heads/master@{#407086}

[modify] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/editing/deleting/delete-contiguous-ws-001.html
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-contiguous-ws-001-expected.png
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-contiguous-ws-001-expected.txt
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-contiguous-ws-001-expected.png
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-contiguous-ws-001-expected.png
[delete] https://crrev.com/ee02461978cc4c62832472126900f9b868e04153/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-contiguous-ws-001-expected.txt

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ee869813b4b05d9bad1d84b15d148891df2d58

commit 08ee869813b4b05d9bad1d84b15d148891df2d58
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 06:49:52 2016

Convert editing/deleting/delete-block-content-00[123].html to use w3c test harness

This patch converts "editing/deleting/delete-block-content-00[123].html" to use
w3c test harness to simplify test files by consolidating them into
"delete-block-content.html".

Note: "delete-block-content-003.html" is identical to
"delete-block-content-002.html" expect for 003.html has two DIV[id=root].

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170273002
Cr-Commit-Position: refs/heads/master@{#407087}

[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-001.html
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-002.html
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents-003.html
[add] https://crrev.com/08ee869813b4b05d9bad1d84b15d148891df2d58/third_party/WebKit/LayoutTests/editing/deleting/delete-block-contents.html
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-001-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-001-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-002-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-002-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-003-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-contents-003-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-001-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-001-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-002-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-002-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-003-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-contents-003-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-001-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-001-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-002-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-002-expected.txt
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-003-expected.png
[delete] https://crrev.com/54194784a446c68c87b44a41a2950c28ab384302/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-contents-003-expected.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53

commit a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 08:04:03 2016

Convert editing/deleting/delete-to-select-table.html to use w3c test harness

This patch converts "editing/deleting/delete-to-select-table.html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2169323002
Cr-Commit-Position: refs/heads/master@{#407097}

[modify] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/editing/deleting/delete-to-select-table.html
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/android/editing/deleting/delete-to-select-table-expected.png
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-to-select-table-expected.png
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-to-select-table-expected.txt
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-to-select-table-expected.png
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-to-select-table-expected.txt
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-to-select-table-expected.png
[delete] https://crrev.com/cb77a1a9eadd86f63926e778bd6bee6a6bb9569d/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-to-select-table-expected.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a042a214c625d528a809551422ce88c978fe2c67

commit a042a214c625d528a809551422ce88c978fe2c67
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 08:05:53 2016

Convert editing/deleting/delete-ws-fixup-00[1234].html to use w3c test harness

This patch converts "editing/deleting/delete-ws-fixup-00[1234].html" to use w3c
test harness and consolidates into "delete_ws_fixup.html" to simplify test
files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2174683002
Cr-Commit-Position: refs/heads/master@{#407099}

[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/editing/deleting/delete-ws-fixup-001.html
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/editing/deleting/delete-ws-fixup-002.html
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/editing/deleting/delete-ws-fixup-003.html
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/editing/deleting/delete-ws-fixup-004.html
[add] https://crrev.com/a042a214c625d528a809551422ce88c978fe2c67/third_party/WebKit/LayoutTests/editing/deleting/delete_ws_fixup.html
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-001-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-001-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-002-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-002-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-003-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-003-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-004-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-ws-fixup-004-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-001-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-002-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-003-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-004-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-001-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-001-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-002-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-002-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-003-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-003-expected.txt
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-004-expected.png
[delete] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-ws-fixup-004-expected.txt

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ba29152cac4a48f6294a74b1d0938927cec3f6

commit 68ba29152cac4a48f6294a74b1d0938927cec3f6
Author: yosin <yosin@chromium.org>
Date: Fri Jul 22 08:04:45 2016

Convert editing/deleting/delete-trailing-ws-00[12].html to use w3c test harness

This patch converts "editing/deleting/delete-trailing-ws-00[12].html" to use w3c
test harness and consolidates into "delete_trailing_ws.html" to simplify test
files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2174673002
Cr-Commit-Position: refs/heads/master@{#407098}

[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/editing/deleting/delete-trailing-ws-001.html
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/editing/deleting/delete-trailing-ws-002.html
[add] https://crrev.com/68ba29152cac4a48f6294a74b1d0938927cec3f6/third_party/WebKit/LayoutTests/editing/deleting/delete_trailing_ws.html
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-trailing-ws-001-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-trailing-ws-001-expected.txt
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-trailing-ws-002-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-trailing-ws-002-expected.txt
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-trailing-ws-001-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-trailing-ws-002-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-trailing-ws-001-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-trailing-ws-001-expected.txt
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-trailing-ws-002-expected.png
[delete] https://crrev.com/a48a2bfb7ddf8f0fd86c658a53fc7ee89440ef53/third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-trailing-ws-002-expected.txt

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/058dc607cd673cedfdf5e6505ea7fbbdb8f3644b

commit 058dc607cd673cedfdf5e6505ea7fbbdb8f3644b
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 03:00:13 2016

Convert editing/inserting/insert-br-00[0-9].html to use w3c test harness

This patch converts "editing/inserting/insert-br-00[0-9].html" to use w3c
test harness and consolidates into "insert_br.html" to simplify test case
for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2175673002
Cr-Commit-Position: refs/heads/master@{#407401}

[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-001.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-002.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-003.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-004.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-005.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-006.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-007.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-008.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/editing/inserting/insert-br-009.html
[add] https://crrev.com/058dc607cd673cedfdf5e6505ea7fbbdb8f3644b/third_party/WebKit/LayoutTests/editing/inserting/insert_br.html
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-001-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-001-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-002-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-002-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-003-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-003-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-004-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-004-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-005-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-005-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-006-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-006-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-007-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-007-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-008-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-008-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-009-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-br-009-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-001-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-001-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-002-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-002-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-003-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-003-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-004-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-004-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-005-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-005-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-006-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-006-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-007-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-007-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-008-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-008-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-009-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-br-009-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-001-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-001-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-002-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-002-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-003-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-003-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-004-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-004-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-005-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-005-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-006-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-006-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-007-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-007-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-008-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-008-expected.txt
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-009-expected.png
[delete] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-br-009-expected.txt

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40247bdd0ab99581e5d1aff147a0e01694a106f7

commit 40247bdd0ab99581e5d1aff147a0e01694a106f7
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 03:14:50 2016

Convert editing/execCommand/insertHorizontalRule.html to use w3c test harness

This patch converts "editing/execCommand/insertHorizontalRule.html" to use w3c
test harness to simplify test files.

This patch also renames it to "insert_horizontal_rule.html" to follow other
test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172033003
Cr-Commit-Position: refs/heads/master@{#407404}

[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/editing/execCommand/insertHorizontalRule.html
[add] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/editing/execCommand/insert_horizontal_rule.html
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/insertHorizontalRule-expected.png
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/insertHorizontalRule-expected.txt
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/insertHorizontalRule-expected.png
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/insertHorizontalRule-expected.txt
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/insertHorizontalRule-expected.png
[delete] https://crrev.com/7f6db660beae6209ce45208167e98f691ad6ee73/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/insertHorizontalRule-expected.txt

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/232ad7c7f6f33344df0a7195d076d54a0aa74b9b

commit 232ad7c7f6f33344df0a7195d076d54a0aa74b9b
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 03:16:09 2016

Convert editing/inserting/editing-empty-divs.html to use w3c test harness

This patch converts "editing/inserting/editing-empty-divs.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172163003
Cr-Commit-Position: refs/heads/master@{#407405}

[modify] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/editing/inserting/editing-empty-divs.html
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/editing-empty-divs-expected.png
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/editing-empty-divs-expected.txt
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/editing-empty-divs-expected.png
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/editing-empty-divs-expected.txt
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/win/editing/inserting/editing-empty-divs-expected.png
[delete] https://crrev.com/40247bdd0ab99581e5d1aff147a0e01694a106f7/third_party/WebKit/LayoutTests/platform/win/editing/inserting/editing-empty-divs-expected.txt

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df54426c9c46217a8b04b00669d3dcf77f58bb2e

commit df54426c9c46217a8b04b00669d3dcf77f58bb2e
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 03:19:08 2016

Convert editing/execCommand/indent-selection.html to use w3c test harness

This patch converts "editing/execCommand/indent-selection.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2175633002
Cr-Commit-Position: refs/heads/master@{#407406}

[modify] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/editing/execCommand/indent-selection.html
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/indent-selection-expected.png
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/indent-selection-expected.txt
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/indent-selection-expected.png
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/indent-selection-expected.txt
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/indent-selection-expected.png
[delete] https://crrev.com/232ad7c7f6f33344df0a7195d076d54a0aa74b9b/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/indent-selection-expected.txt

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/413d890d48174b78822e408f1b782dcb205a80c7

commit 413d890d48174b78822e408f1b782dcb205a80c7
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 03:22:53 2016

Convert editing/execCommand/4916402.html to use w3c test harness

This patch converts "editing/execCommand/4916402.html" to use w3c
test harness to simplify test file and renames to descriptive name
"insert_list_ul_li_to_ol.html" to provide hint what this test does.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2168413002
Cr-Commit-Position: refs/heads/master@{#407407}

[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/editing/execCommand/4916402.html
[add] https://crrev.com/413d890d48174b78822e408f1b782dcb205a80c7/third_party/WebKit/LayoutTests/editing/execCommand/insert_list/insert_list_ul_li_to_ol.html
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/4916402-expected.png
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/4916402-expected.txt
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/4916402-expected.png
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/4916402-expected.txt
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/4916402-expected.png
[delete] https://crrev.com/df54426c9c46217a8b04b00669d3dcf77f58bb2e/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/4916402-expected.txt

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41da486d798bf62ab32c0d6021465ae14860b34b

commit 41da486d798bf62ab32c0d6021465ae14860b34b
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 04:18:31 2016

Convert editing/execCommand/indent-list-item.html to use w3c test harness

This patch converts "editing/execCommand/indent-list-item.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2171223002
Cr-Commit-Position: refs/heads/master@{#407412}

[modify] https://crrev.com/41da486d798bf62ab32c0d6021465ae14860b34b/third_party/WebKit/LayoutTests/editing/execCommand/indent-list-item.html
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/indent-list-item-expected.png
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/indent-list-item-expected.txt
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/indent-list-item-expected.png
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/indent-list-item-expected.txt
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/indent-list-item-expected.png
[delete] https://crrev.com/45eaf49a7cea5e2188ecacb01c0579d7035963ac/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/indent-list-item-expected.txt

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ebca70047188a50411999c4ad30d827d48d21e

commit b5ebca70047188a50411999c4ad30d827d48d21e
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 07:28:42 2016

Convert editing/inserting/insert-div-00[1-8].html to use w3c test harness

This patch converts "editing/inserting/insert-div-00[1-8].html" to use w3c
test harness and consolidates into "insert_div_with_style.html" to simplify test
case for ease of maintenance with introducing "insertParagraph" command without
"insertText" to verify result of "insertParagraph".

Note: insert-div-001.html and insert-div-002.html are identical. Both set caret
at end of text then insert a paragraph and a character.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2181583002
Cr-Commit-Position: refs/heads/master@{#407422}

[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-001.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-002.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-003.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-004.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-005.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-006.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-007.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/editing/inserting/insert-div-008.html
[add] https://crrev.com/b5ebca70047188a50411999c4ad30d827d48d21e/third_party/WebKit/LayoutTests/editing/inserting/insert_div_with_style.html
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-001-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-001-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-002-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-002-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-003-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-003-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-004-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-004-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-005-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-005-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-006-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-006-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-007-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-007-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-008-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-008-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-001-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-001-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-002-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-002-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-003-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-003-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-004-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-004-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-005-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-005-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-006-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-006-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-007-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-007-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-008-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-008-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-001-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-001-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-002-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-002-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-003-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-003-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-004-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-004-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-005-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-005-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-006-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-006-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-007-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-007-expected.txt
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-008-expected.png
[delete] https://crrev.com/e4c0c0a729891099c502c8e330b71acca7041ce3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-008-expected.txt

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b595c05e06799f436fabe62e1ef026f8697c57ee

commit b595c05e06799f436fabe62e1ef026f8697c57ee
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 07:46:20 2016

Convert editing/insert-div-019.html to use w3c test harness

This patch converts "editing/insert-div-019.html" to use w3c test harness to
simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2181603002
Cr-Commit-Position: refs/heads/master@{#407425}

[modify] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/editing/inserting/insert-div-019.html
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-019-expected.png
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-019-expected.txt
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-019-expected.png
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-019-expected.txt
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-019-expected.png
[delete] https://crrev.com/8fb95e706d70e82d0f9c41fba01b7919d16b8ab3/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-019-expected.txt

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/990ae76ba01c26a15412f4bde95f6144e3c28545

commit 990ae76ba01c26a15412f4bde95f6144e3c28545
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 07:51:09 2016

Convert editing/insert-div-20.html to use w3c test harness

This patch converts "editing/insert-div-20.html" to use w3c test harness to
simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2180833002
Cr-Commit-Position: refs/heads/master@{#407426}

[modify] https://crrev.com/990ae76ba01c26a15412f4bde95f6144e3c28545/third_party/WebKit/LayoutTests/editing/inserting/insert-div-020.html
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-020-expected.png
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-020-expected.txt
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-020-expected.png
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-020-expected.txt
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-020-expected.png
[delete] https://crrev.com/b595c05e06799f436fabe62e1ef026f8697c57ee/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-020-expected.txt

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ad76b419eacefc4d619a212c933484c797ba472

commit 6ad76b419eacefc4d619a212c933484c797ba472
Author: yosin <yosin@chromium.org>
Date: Mon Jul 25 09:23:53 2016

Convert editing/inserting/insert-div-01[1-7].html to use w3c test harness

This patch converts "editing/inserting/insert-div-01[1-7].html" to use w3c
test harness and consolidates into "insert_div_with_attr.html" to simplify test
case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2176113002
Cr-Commit-Position: refs/heads/master@{#407436}

[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-011.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-012.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-013.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-014.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-015.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-016.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/editing/inserting/insert-div-017.html
[add] https://crrev.com/6ad76b419eacefc4d619a212c933484c797ba472/third_party/WebKit/LayoutTests/editing/inserting/insert_div_with_attr.html
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-011-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-011-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-012-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-012-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-013-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-013-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-014-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-014-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-015-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-015-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-016-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-016-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-017-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-017-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-011-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-011-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-012-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-012-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-013-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-014-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-014-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-015-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-016-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-016-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-017-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-017-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-011-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-011-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-012-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-012-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-013-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-013-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-014-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-014-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-015-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-015-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-016-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-016-expected.txt
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-017-expected.png
[delete] https://crrev.com/b76fc4469acf4c44336dd8d42d1e127c8823d08b/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-017-expected.txt

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba49be21047c327c3e82292cc8991b8668d99994

commit ba49be21047c327c3e82292cc8991b8668d99994
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 01:19:14 2016

Convert editing/insert-div-22.html to use w3c test harness

This patch converts "editing/insert-div-22.html" to use w3c test harness to
simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2178863002
Cr-Commit-Position: refs/heads/master@{#407670}

[modify] https://crrev.com/ba49be21047c327c3e82292cc8991b8668d99994/third_party/WebKit/LayoutTests/editing/inserting/insert-div-022.html
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-022-expected.png
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-022-expected.txt
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-022-expected.png
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-022-expected.txt
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-022-expected.png
[delete] https://crrev.com/be517ca4aa6a819cb23427d46f79e4e4e6c43537/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-022-expected.txt

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59f000d102e7f801cfb580ed0bdf58e13eb0d3c7

commit 59f000d102e7f801cfb580ed0bdf58e13eb0d3c7
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 03:02:26 2016

Convert editing/insert-text-with-newlines.html to use w3c test harness

This patch converts "editing/insert-text-with-newlines.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2180863002
Cr-Commit-Position: refs/heads/master@{#407694}

[modify] https://crrev.com/59f000d102e7f801cfb580ed0bdf58e13eb0d3c7/third_party/WebKit/LayoutTests/editing/inserting/insert-text-with-newlines.html
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-text-with-newlines-expected.png
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-text-with-newlines-expected.txt
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-text-with-newlines-expected.png
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-text-with-newlines-expected.txt
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-text-with-newlines-expected.png
[delete] https://crrev.com/3ededbe4872bb7fe8908c78d32467e96693766cb/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-text-with-newlines-expected.txt

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd091a10e58c7da8243c87ea4b5e78c186d00d6

commit 9fd091a10e58c7da8243c87ea4b5e78c186d00d6
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 07:21:59 2016

Convert editing/typing-around-br-001.html to use w3c test harness

This patch converts "editing/typing-around-br-001.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184603002
Cr-Commit-Position: refs/heads/master@{#407731}

[modify] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/editing/inserting/typing-around-br-001.html
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-around-br-001-expected.png
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-around-br-001-expected.txt
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-around-br-001-expected.png
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-around-br-001-expected.txt
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-around-br-001-expected.png
[delete] https://crrev.com/d62b8c75b100ac27584a6ee8aa67e0fdb63f5a2e/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-around-br-001-expected.txt

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52e039ba69a827512936f7a9146578560778e519

commit 52e039ba69a827512936f7a9146578560778e519
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 07:50:17 2016

Convert editing/inserting/typing-00[1-3].html to use w3c test harness

This patch converts "editing/inserting/typing-00[1-3].html" to use w3c
test harness and consolidates into "typing.html" to simplify test case
for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184503003
Cr-Commit-Position: refs/heads/master@{#407732}

[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/editing/inserting/typing-001.html
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/editing/inserting/typing-002.html
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/editing/inserting/typing-003.html
[add] https://crrev.com/52e039ba69a827512936f7a9146578560778e519/third_party/WebKit/LayoutTests/editing/inserting/typing.html
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-001-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-001-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-002-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-002-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-003-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-003-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-001-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-001-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-002-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-002-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-003-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-003-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-001-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-001-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-002-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-002-expected.txt
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-003-expected.png
[delete] https://crrev.com/9fd091a10e58c7da8243c87ea4b5e78c186d00d6/third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-003-expected.txt

Project Member

Comment 29 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb49e6072bba24dba5a526a30162d198a1e0503

commit cbb49e6072bba24dba5a526a30162d198a1e0503
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 08:27:45 2016

Convert editing/pasteboard/8145-[1-3].html to use w3c test harness

This patch converts "editing/pasteboard/8145-[1-3].html" to use w3c
test harness and consolidates into "insert_html_as_plain_text.html" to simplify
test case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2179373002
Cr-Commit-Position: refs/heads/master@{#407735}

[add] https://crrev.com/cbb49e6072bba24dba5a526a30162d198a1e0503/third_party/WebKit/LayoutTests/editing/inserting/insert_html_as_plain_text.html
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/editing/pasteboard/8145-1.html
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/editing/pasteboard/8145-2.html
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/editing/pasteboard/8145-3.html
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/android/editing/pasteboard/8145-1-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/android/editing/pasteboard/8145-1-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-1-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-1-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-2-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-2-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-3-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/8145-3-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-1-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-1-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-2-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-2-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-3-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-3-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-1-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-1-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-2-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-2-expected.txt
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-3-expected.png
[delete] https://crrev.com/44311da279227dc22c1a2172e5ca0e36eb5809a8/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/8145-3-expected.txt

Project Member

Comment 30 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e7cb1df177023ec21114c253c2516e1ff341c10

commit 5e7cb1df177023ec21114c253c2516e1ff341c10
Author: yosin <yosin@chromium.org>
Date: Tue Jul 26 10:29:20 2016

Convert editing/pasteboard/merge-end-blockquote.html to use w3c test harness

This patch converts "editing/pasteboard/merge-end-blockquote.html" to use w3c
test harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2181113003
Cr-Commit-Position: refs/heads/master@{#407760}

[modify] https://crrev.com/5e7cb1df177023ec21114c253c2516e1ff341c10/third_party/WebKit/LayoutTests/editing/pasteboard/merge-end-blockquote.html
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-end-blockquote-expected.png
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-end-blockquote-expected.txt
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-end-blockquote-expected.png
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-end-blockquote-expected.png
[delete] https://crrev.com/a268394515d41c3917ce5777b4ec92a6fc1aa856/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-end-blockquote-expected.txt

Project Member

Comment 31 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5eb2d3975856e0c91bc43d807e93879801baac

commit ac5eb2d3975856e0c91bc43d807e93879801baac
Author: yosin <yosin@chromium.org>
Date: Wed Jul 27 01:04:27 2016

Convert editing/pasteboard/pasteboard/paste-4038267-fix.html.html to use w3c test harness

This patch converts "editing/pasteboard/merge-end-blockquote.html" to use w3c
test harness and rename "insert_interchange_newline_crash.html" to to simplify
test files, since this test verifies "insertHTML" command instead of "paste".

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184623002
Cr-Commit-Position: refs/heads/master@{#407999}

[add] https://crrev.com/ac5eb2d3975856e0c91bc43d807e93879801baac/third_party/WebKit/LayoutTests/editing/inserting/insert_interchange_newline_crash.html
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/editing/pasteboard/paste-4038267-fix.html
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/paste-4038267-fix-expected.png
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/paste-4038267-fix-expected.txt
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/paste-4038267-fix-expected.png
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/paste-4038267-fix-expected.txt
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/paste-4038267-fix-expected.png
[delete] https://crrev.com/03362ea9647cd828d767323060e8acbd672bfb6f/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/paste-4038267-fix-expected.txt

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d1fad9e3b073f1a4da0184392f3fe79f2f618b7

commit 0d1fad9e3b073f1a4da0184392f3fe79f2f618b7
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jul 27 02:19:59 2016

Convert editing/style/style-3998892-fix.html to use w3c test harness

This patch converts "editing/style/style-3998892-fix.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2183763003
Cr-Commit-Position: refs/heads/master@{#408016}

[modify] https://crrev.com/0d1fad9e3b073f1a4da0184392f3fe79f2f618b7/third_party/WebKit/LayoutTests/editing/style/style-3998892-fix.html
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/linux/editing/style/style-3998892-fix-expected.png
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/linux/editing/style/style-3998892-fix-expected.txt
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/mac/editing/style/style-3998892-fix-expected.png
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/mac/editing/style/style-3998892-fix-expected.txt
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/win/editing/style/style-3998892-fix-expected.png
[delete] https://crrev.com/79484710b29c7feef6e6ac4d03120e5fdc94f5af/third_party/WebKit/LayoutTests/platform/win/editing/style/style-3998892-fix-expected.txt

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1004d071d629d70592d69700a5d388e1a526559e

commit 1004d071d629d70592d69700a5d388e1a526559e
Author: yosin <yosin@chromium.org>
Date: Wed Jul 27 02:57:19 2016

Convert editing/pasteboard/merge-after-delete*.html to use w3c test harness

This patch converts "editing/pasteboard/merge-after-delete*.html" to use w3c
test harness and consolidates into "merge_after_delete.html" to simplify test
case for ease of maintenance.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2182013002
Cr-Commit-Position: refs/heads/master@{#408027}

[add] https://crrev.com/1004d071d629d70592d69700a5d388e1a526559e/third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete-1.html
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete-2.html
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete.html
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-1-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-1-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-2-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-2-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-1-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-2-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-1-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-1-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-2-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-2-expected.txt
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-expected.png
[delete] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-expected.txt

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9790bf534f1d6bd35445cb81a990fa83785a97c0

commit 9790bf534f1d6bd35445cb81a990fa83785a97c0
Author: yosin <yosin@chromium.org>
Date: Wed Jul 27 04:10:46 2016

Convert editing/selection/5057506.html to use w3c test harness

This patch converts "editing/selection/5057506.html" to use w3c
test harness to simplify test script, and rename
"double_click_after_last_cell.html" to describe what this test script does.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2178193004
Cr-Commit-Position: refs/heads/master@{#408037}

[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/editing/selection/5057506.html
[add] https://crrev.com/9790bf534f1d6bd35445cb81a990fa83785a97c0/third_party/WebKit/LayoutTests/editing/selection/mouse/double_click_after_last_cell.html
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5057506-expected.png
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5057506-expected.txt
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5057506-expected.png
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5057506-expected.txt
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/win/editing/selection/5057506-expected.png
[delete] https://crrev.com/e31add762eb64451ee27a9e40ae0fd94f90a8c12/third_party/WebKit/LayoutTests/platform/win/editing/selection/5057506-expected.txt

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0892e85e1abeb94475fb238852510db5bbf4d665

commit 0892e85e1abeb94475fb238852510db5bbf4d665
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jul 27 06:09:12 2016

Convert editing/style/5017613-*.html to use w3c test harness

This patch converts "editing/style/5017613-*.html" to use w3c test
harness to simplify test files, and merges them into
"editing/style/apply_style_to_plaintext_only.html" to better describe
what the script is doing.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2179033004
Cr-Commit-Position: refs/heads/master@{#408054}

[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/editing/style/5017613-1.html
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/editing/style/5017613-2.html
[add] https://crrev.com/0892e85e1abeb94475fb238852510db5bbf4d665/third_party/WebKit/LayoutTests/editing/style/apply_style_to_plaintext_only.html
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/linux/editing/style/5017613-1-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/linux/editing/style/5017613-1-expected.txt
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/linux/editing/style/5017613-2-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/linux/editing/style/5017613-2-expected.txt
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/mac/editing/style/5017613-1-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/mac/editing/style/5017613-1-expected.txt
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/mac/editing/style/5017613-2-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/mac/editing/style/5017613-2-expected.txt
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/win/editing/style/5017613-1-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/win/editing/style/5017613-1-expected.txt
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/win/editing/style/5017613-2-expected.png
[delete] https://crrev.com/8e9a0157ee99dd9ac7a2d36bca9a3daa3e0f320e/third_party/WebKit/LayoutTests/platform/win/editing/style/5017613-2-expected.txt

Project Member

Comment 36 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afaa923d7e5acab54ae4470cdfeac225f272a8c0

commit afaa923d7e5acab54ae4470cdfeac225f272a8c0
Author: yosin <yosin@chromium.org>
Date: Wed Jul 27 06:17:17 2016

Convert editing/selection/5234383-[12].html to use w3c test harness

This patch converts "editing/selection/5234383-[12].html" to use w3c
test harness to simplify test files and consolidate into
"move_by_sentence_boundary.html" with additional test cases to improve test
coverage.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184473006
Cr-Commit-Position: refs/heads/master@{#408057}

[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/editing/selection/5234383-1.html
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/editing/selection/5234383-2.html
[add] https://crrev.com/afaa923d7e5acab54ae4470cdfeac225f272a8c0/third_party/WebKit/LayoutTests/editing/selection/modify_move/move_by_sentence_boundary.html
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-1-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-1-expected.txt
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-2-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-2-expected.txt
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-1-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-1-expected.txt
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-2-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-2-expected.txt
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-1-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-1-expected.txt
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-2-expected.png
[delete] https://crrev.com/b8266963a948e43a80e09ad32c167db7e4391cfc/third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-2-expected.txt

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e13298a71480fed7befb5bc0574b9964c385354

commit 6e13298a71480fed7befb5bc0574b9964c385354
Author: yosin <yosin@chromium.org>
Date: Wed Jul 27 06:35:59 2016

Convert editing/paste-text-019.html to use w3c test harness

This patch converts "editing/paste-text-019.html" to use w3c
test harness to simplify test files and rename to
"paste_text_with_text_transform.html" to denote what this test file does.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184033002
Cr-Commit-Position: refs/heads/master@{#408060}

[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-019.html
[add] https://crrev.com/6e13298a71480fed7befb5bc0574b9964c385354/third_party/WebKit/LayoutTests/editing/pasteboard/paste_text_with_text_transform.html
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/paste-text-019-expected.png
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/paste-text-019-expected.txt
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/paste-text-019-expected.png
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/paste-text-019-expected.txt
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/paste-text-019-expected.png
[delete] https://crrev.com/3d65007a96c2b57a635401a6e5ba71b02083c536/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/paste-text-019-expected.txt

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd47c7e1b55f83206cfb5ae502c36e79efa563f5

commit cd47c7e1b55f83206cfb5ae502c36e79efa563f5
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jul 27 07:06:28 2016

Convert editing/selection/unrendered-space.html to use w3c test harness

This patch converts "editing/selection/unrendered-space.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184863003
Cr-Commit-Position: refs/heads/master@{#408065}

[modify] https://crrev.com/cd47c7e1b55f83206cfb5ae502c36e79efa563f5/third_party/WebKit/LayoutTests/editing/selection/unrendered-space.html
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/linux/editing/selection/unrendered-space-expected.png
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/linux/editing/selection/unrendered-space-expected.txt
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/mac/editing/selection/unrendered-space-expected.png
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/mac/editing/selection/unrendered-space-expected.txt
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/win/editing/selection/unrendered-space-expected.png
[delete] https://crrev.com/e8d505658c6c05c87bc2f9adfb0a8f27b8ba94f8/third_party/WebKit/LayoutTests/platform/win/editing/selection/unrendered-space-expected.txt

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31e862cf653173e6cefe10a6ba8200f632b787f0

commit 31e862cf653173e6cefe10a6ba8200f632b787f0
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jul 27 07:43:34 2016

Convert editing/selection/table-caret-1.html to use w3c test harness

This patch converts "editing/selection/table-caret-1.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2183413002
Cr-Commit-Position: refs/heads/master@{#408072}

[modify] https://crrev.com/31e862cf653173e6cefe10a6ba8200f632b787f0/third_party/WebKit/LayoutTests/editing/selection/table-caret-1.html
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/linux/editing/selection/table-caret-1-expected.png
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/linux/editing/selection/table-caret-1-expected.txt
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/mac/editing/selection/table-caret-1-expected.png
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/mac/editing/selection/table-caret-1-expected.txt
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/win/editing/selection/table-caret-1-expected.png
[delete] https://crrev.com/32dad58c08112ed4a04505675aca27d37d2ce755/third_party/WebKit/LayoutTests/platform/win/editing/selection/table-caret-1-expected.txt

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e27474b0b102b5194232de352ab9eeee556037e4

commit e27474b0b102b5194232de352ab9eeee556037e4
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jul 27 11:19:40 2016

Convert editing/selection/image-before-linebreak.html to use w3c test harness

This patch converts "editing/image-before-linebreak.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2189503003
Cr-Commit-Position: refs/heads/master@{#408094}

[modify] https://crrev.com/e27474b0b102b5194232de352ab9eeee556037e4/third_party/WebKit/LayoutTests/editing/selection/image-before-linebreak.html
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/linux/editing/selection/image-before-linebreak-expected.png
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/linux/editing/selection/image-before-linebreak-expected.txt
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/mac/editing/selection/image-before-linebreak-expected.png
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/mac/editing/selection/image-before-linebreak-expected.txt
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/win/editing/selection/image-before-linebreak-expected.png
[delete] https://crrev.com/190cffeadfe46c6419789d586551c877b24f082f/third_party/WebKit/LayoutTests/platform/win/editing/selection/image-before-linebreak-expected.txt

Project Member

Comment 41 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32de271fb02024450856b9a5dcfbe42609739224

commit 32de271fb02024450856b9a5dcfbe42609739224
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Jul 28 02:17:15 2016

Remove layout tests only for grammar checking

Blink does not have grammar checking, so the following layout tests for
grammar checking are removed:

editing/spelling/grammar-edit-word.html
editing/spelling/grammar-markers-hidpi.html
editing/spelling/grammar.html
editing/spelling/grammar-paste.html
editing/spelling/grammar-markers.html

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2188703002
Cr-Commit-Position: refs/heads/master@{#408314}

[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-expected.txt
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-expected.txt
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/editing/spelling/grammar.html
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-hidpi-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png
[delete] https://crrev.com/4771076dd784de40192c7249914a2fbb208e7a49/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png

Project Member

Comment 42 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0ece62b99aeb105a26423d1d0390c722b4fef3

commit 2b0ece62b99aeb105a26423d1d0390c722b4fef3
Author: yosin <yosin@chromium.org>
Date: Thu Jul 28 02:52:37 2016

Convert extend-by-character-[1-6].html to use assert_selection

This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2184953002
Cr-Commit-Position: refs/heads/master@{#408319}

[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/extend-by-character-006.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-001.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-002.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-003.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-004.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend-by-character-005.html
[add] https://crrev.com/2b0ece62b99aeb105a26423d1d0390c722b4fef3/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-006-expected.png
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-by-character-006-expected.txt
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-006-expected.png
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/mac/editing/selection/extend-by-character-006-expected.txt
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-006-expected.png
[delete] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/third_party/WebKit/LayoutTests/platform/win/editing/selection/extend-by-character-006-expected.txt

Project Member

Comment 43 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b84ed8f4c1df5564ae573459287ce55569dab3

commit 57b84ed8f4c1df5564ae573459287ce55569dab3
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Jul 28 07:00:07 2016

Remove grammar checking from layout tests, and MockGrammarCheck

Since Chromium and Blink do not support grammar checking, this patch
removes grammar checking from the following layout tests:

spelling/markers.html
spelling/inline_spelling_markers.html
spelling/inline-spelling-markers-hidpi.html
spelling/inline-spelling-markers-hidpi-composited.html

The last three tests use pixel tests, and are temporarily marked
as failing. They will be unmarked after the grammar marks are removed
from their pixel results.

This patch also removes the class MockGrammarCheck since its only
purpose is to support grammar checking in tests.

BUG=619452
TEST=n/a; this patch changes test files

Review-Url: https://codereview.chromium.org/2186923002
Cr-Commit-Position: refs/heads/master@{#408347}

[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/components/test_runner/BUILD.gn
[delete] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/components/test_runner/mock_grammar_check.cc
[delete] https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8/components/test_runner/mock_grammar_check.h
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/components/test_runner/test_runner.gyp
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/markers-expected.txt
[modify] https://crrev.com/57b84ed8f4c1df5564ae573459287ce55569dab3/third_party/WebKit/LayoutTests/editing/spelling/markers.html

Project Member

Comment 44 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bce93917093ec0d1acd2de4c769ffd18c7e3c075

commit bce93917093ec0d1acd2de4c769ffd18c7e3c075
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Jul 29 01:08:54 2016

Remove hasGrammarMarker from internals

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2191803002
Cr-Commit-Position: refs/heads/master@{#408541}

[modify] https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075/third_party/WebKit/Source/core/testing/Internals.idl

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/068b312e9d944f8fdb4090355b93ab3e87f9a99b

commit 068b312e9d944f8fdb4090355b93ab3e87f9a99b
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Jul 29 06:54:58 2016

Stop TextCheckingHelper from checking grammar

This patch removes grammar checking related code from TextCheckingHelper
because Chromium and Blink do not support grammar checking. The related
public member functions still keep the same signatures but no longer
perform any grammar checking or return any grammar mistake.

TextCheckerClient::checkGrammarOfString() is also removed since it is
only used by TextCheckingHelper.

BUG=619452
TEST=n/a; no visible behavior change

Review-Url: https://codereview.chromium.org/2190293002
Cr-Commit-Position: refs/heads/master@{#408594}

[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/platform/text/TextCheckerClient.h
[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/068b312e9d944f8fdb4090355b93ab3e87f9a99b/third_party/WebKit/Source/web/SpellCheckerClientImpl.h

Project Member

Comment 46 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/537eb21a213e933eadc4cb5261bd33f5b895d08d

commit 537eb21a213e933eadc4cb5261bd33f5b895d08d
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Jul 29 16:54:59 2016

Remove expectation images incorrectly added by autorebaseline bot

Auto rebaseline bot incorrectly added layout test expectation images in
platform/android for tests that are not run on Android bots in r408359.
This patch manually removes them.

BUG=619452
TBR=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2188393003
Cr-Commit-Position: refs/heads/master@{#408664}

[delete] https://crrev.com/0e892d8dbe70d7ab172f9af4afa2a1a00839169b/third_party/WebKit/LayoutTests/platform/android/editing/spelling/inline-spelling-markers-hidpi-expected.png
[delete] https://crrev.com/0e892d8dbe70d7ab172f9af4afa2a1a00839169b/third_party/WebKit/LayoutTests/platform/android/editing/spelling/inline_spelling_markers-expected.png

Project Member

Comment 47 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01554f3c62b7725817c766dd620e302fcdad6e00

commit 01554f3c62b7725817c766dd620e302fcdad6e00
Author: xiaochengh <xiaochengh@chromium.org>
Date: Mon Aug 01 05:14:44 2016

Hide some member functions of SpellChecker as private

This patch hides the following member functions of SpellChecker as
private because they are only used by SpellChecker itself:

bool markMisspellings(const VisibleSelection&);
void markBadGrammar(const VisibleSelection&);
bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);

This patch is a preparation for cleaning up grammar checking code from
SpellChecker.

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2198733003
Cr-Commit-Position: refs/heads/master@{#408912}

[modify] https://crrev.com/01554f3c62b7725817c766dd620e302fcdad6e00/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Comment 48 by xiaoche...@chromium.org, Aug 1 2016

Owner: xiaoche...@chromium.org

Project Member

Comment 49 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4b6d233d131487b752e5c92ff16f56779b3f7a

commit ca4b6d233d131487b752e5c92ff16f56779b3f7a
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 01:31:51 2016

Remove grammar marker inspection from WebFrameTest

This patch is part of the refactoring of removing grammar
checking code, because neither Chromium nor Blink supports
supports grammar checking.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2201783002
Cr-Commit-Position: refs/heads/master@{#409115}

[modify] https://crrev.com/ca4b6d233d131487b752e5c92ff16f56779b3f7a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 50 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4282ab146912a47641e62be16518fcd739f1c801

commit 4282ab146912a47641e62be16518fcd739f1c801
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 01:35:23 2016

Fix layout test accessibility/misspelling.html

This patch modifies the layout test in the following ways:

1. Add more step_timeout() to ensure that a test can be run only after
all previous tests are done.

2. In the second test case, ensure the triggering of spell checking by
moving the caret into <p>.

BUG=619452
TEST=n/a; this patch changes a test file
R=nektar@chromium.org, yosin@chromium.org

Review-Url: https://codereview.chromium.org/2197213002
Cr-Commit-Position: refs/heads/master@{#409118}

[modify] https://crrev.com/4282ab146912a47641e62be16518fcd739f1c801/third_party/WebKit/LayoutTests/accessibility/misspellings.html

Project Member

Comment 51 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2

commit 9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 04:33:49 2016

Remove some grammar checking code from SpellChecker

This patch does:

1. Remove SpellChecker::markBadGrammar and all of its call sites

2. Absorb SpellChecker::markMisspellingsOrBadGrammar by
SpellChecker::markMisspellings for code simplification

BUG=619452
TEST=n/a; no visible change

Review-Url: https://codereview.chromium.org/2199743003
Cr-Commit-Position: refs/heads/master@{#409137}

[modify] https://crrev.com/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 52 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ca178d41af494fd444fad6a44202d1d31388c6

commit 91ca178d41af494fd444fad6a44202d1d31388c6
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 07:10:12 2016

Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges

This patch removes grammar checking code from the above named function
of SpellChecker. It also simplifies its signature and stops its call
sites from passing arguments only for grammar checking to it.

BUG=619452
TESt=n/a; no visible change

Review-Url: https://codereview.chromium.org/2199203002
Cr-Commit-Position: refs/heads/master@{#409149}

[modify] https://crrev.com/91ca178d41af494fd444fad6a44202d1d31388c6/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/91ca178d41af494fd444fad6a44202d1d31388c6/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 53 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579c127d36de5035a5084b9aa88697f18b0a4552

commit 579c127d36de5035a5084b9aa88697f18b0a4552
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 07:10:55 2016

Remove some further grammar checking code from SpellChecker

This patch removes code for grammar checking and grammar marker
manipulation from the following member functions of SpellChecker:

advanceToNextMisspelling()
markAndReplaceFor()
didEndEditingOnTextField()
respondToChangedSelection()
requestTextChecking()

BUG=619452
TESt=n/a; no visible change

Review-Url: https://codereview.chromium.org/2202933002
Cr-Commit-Position: refs/heads/master@{#409150}

[modify] https://crrev.com/579c127d36de5035a5084b9aa88697f18b0a4552/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Comment 54 by xiaoche...@chromium.org, Aug 2 2016

Blockedon: 633509

Comment 55 by xiaoche...@chromium.org, Aug 2 2016

Blockedon: 633510

Project Member

Comment 56 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9

commit 0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 08:01:43 2016

Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar

This patch removes grammar checking code from the above named private member
function of SpellChecker, and make it absorbed by the public function of the
same name since the extra parameters are no longer effective.

BUG=619452
TESt=n/a; no visible change

Review-Url: https://codereview.chromium.org/2198223003
Cr-Commit-Position: refs/heads/master@{#409154}

[modify] https://crrev.com/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 57 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7095e1641402c57f32d2cc952b4357af13ff8dfc

commit 7095e1641402c57f32d2cc952b4357af13ff8dfc
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 08:21:30 2016

Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes grammar checking from the above named function, and also
stops its call sites from passing grammar checking related parameters to it.

This patch also removes function SpellChecker::resolveTextCheckTypeMask()
because it is not used any more.

BUG=619452
TESt=n/a; no visible change

Review-Url: https://codereview.chromium.org/2204843002
Cr-Commit-Position: refs/heads/master@{#409156}

[modify] https://crrev.com/7095e1641402c57f32d2cc952b4357af13ff8dfc/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/7095e1641402c57f32d2cc952b4357af13ff8dfc/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 58 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a10daeeca303db977aa23218f2ac71abbb2eaa2e

commit a10daeeca303db977aa23218f2ac71abbb2eaa2e
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 02 10:53:41 2016

Cleanup function names in SpellChecker and TextCheckingHelper

The above classes no longer performs any grammar checking. This patch
cleans up their member function names so that one can be clear that the
two classes only performs spell checking.

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2205823002
Cr-Commit-Position: refs/heads/master@{#409168}

[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/a10daeeca303db977aa23218f2ac71abbb2eaa2e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

Project Member

Comment 59 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a0304640b77b4fdddcccf35bc26cca7ed87ace

commit c5a0304640b77b4fdddcccf35bc26cca7ed87ace
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Aug 04 08:24:26 2016

Revert of Remove hasGrammarMarker from internals (patchset #1 id:1 of https://codereview.chromium.org/2191803002/ )

Reason for revert:
Blink may still draw grammar markers when "Ask Google for suggestion" is checked, so testing of grammar markers should not be removed.

BUG=633641
TBR=yosin@chromium.org, tkent@chromium.org

Original issue's description:
> Remove hasGrammarMarker from internals
>
> BUG=619452
> TEST=n/a; no behavior change
>
> Committed: https://crrev.com/bce93917093ec0d1acd2de4c769ffd18c7e3c075
> Cr-Commit-Position: refs/heads/master@{#408541}

TBR=yosin@chromium.org,tkent@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619452

Review-Url: https://codereview.chromium.org/2210863002
Cr-Commit-Position: refs/heads/master@{#409740}

[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/c5a0304640b77b4fdddcccf35bc26cca7ed87ace/third_party/WebKit/Source/core/testing/Internals.idl

Project Member

Comment 60 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580e9d52a44e15cc8e92673fc763cb47caa3717e

commit 580e9d52a44e15cc8e92673fc763cb47caa3717e
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Aug 04 11:52:58 2016

Revert removal of grammar checking and marking code

This is a manual revert of the following commits:

Revert "Remove layout tests only for grammar checking"
This reverts commit 32de271fb02024450856b9a5dcfbe42609739224.

Revert "Remove grammar checking from layout tests, and MockGrammarCheck"
This reverts commit 57b84ed8f4c1df5564ae573459287ce55569dab3.

Revert "Auto-rebaseline for r408347"
This reverts commit b8af511d0bb6a78352b434c4dede88f9348650c6.

Revert "Remove expectation images incorrectly added by autorebaseline bot"
This reverts commit 537eb21a213e933eadc4cb5261bd33f5b895d08d.

Revert "Remove grammar marker inspection from WebFrameTest"
This reverts commit ca4b6d233d131487b752e5c92ff16f56779b3f7a.

Revert "Stop TextCheckingHelper from checking grammar"
This reverts commit 068b312e9d944f8fdb4090355b93ab3e87f9a99b.

Revert "Hide some member functions of SpellChecker as private"
This reverts commit 01554f3c62b7725817c766dd620e302fcdad6e00.

Revert "Remove some grammar checking code from SpellChecker"
This reverts commit 9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2.

Revert "Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges"
This reverts commit 91ca178d41af494fd444fad6a44202d1d31388c6.

Revert "Remove some further grammar checking code from SpellChecker"
This reverts commit 579c127d36de5035a5084b9aa88697f18b0a4552.

Revert "Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar"
This reverts commit 0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9.

Revert "Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar"
This reverts commit 7095e1641402c57f32d2cc952b4357af13ff8dfc.

Revert "Cleanup function names in SpellChecker and TextCheckingHelper"
This reverts commit a10daeeca303db977aa23218f2ac71abbb2eaa2e.

BUG=619452,633641
TBR=yosin@chromium.org, tkent@chromium.org

Review-Url: https://codereview.chromium.org/2211813002
Cr-Commit-Position: refs/heads/master@{#409763}

[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/BUILD.gn
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/mock_grammar_check.cc
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/mock_grammar_check.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/components/test_runner/test_runner.gyp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/grammar.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/markers-expected.txt
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/editing/spelling/markers.html
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png
[add] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/platform/text/TextCheckerClient.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
[modify] https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 61 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5

commit b9f7be89f809441cba6aa4ff88e39bc967c0bcd5
Author: xiaochengh <xiaochengh@chromium.org>
Date: Mon Aug 08 02:21:45 2016

Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed, and
some other convoluted code is simplified.

BUG=619452
TEST=n/a; no visible change

Review-Url: https://codereview.chromium.org/2220493002
Cr-Commit-Position: refs/heads/master@{#410290}

[modify] https://crrev.com/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 62 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c66e99411384c332f3fddd1c8114fb8a0bad8e38

commit c66e99411384c332f3fddd1c8114fb8a0bad8e38
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 10 08:43:42 2016

Remove dead code in spell checker

This patch removes:

1. TextCheckingType and TextCheckingTypeMask, because all their clients have
hard-coded their value to the same constant.

2. WebSpellCheckClient::checkTextOfParagraph() and all its overrides. This
function is in fact dead code, because it can only be called with
|mask == WebTextCheckingTypeGrammar|, but does not do anything when |mask|
does not contain WebTextCheckingTypeSpelling.

3. WebTextCheckingType and WebTextCheckingTypeMask, because their only client
is WebSpellCheckClient::checkTextOfParagraph().

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2228293002
Cr-Commit-Position: refs/heads/master@{#411010}

[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/chrome/renderer/spellchecker/spellcheck_provider.cc
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/chrome/renderer/spellchecker/spellcheck_provider.h
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/components/test_runner/spell_check_client.h
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/platform/text/TextChecking.h
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38/third_party/WebKit/public/web/WebSpellCheckClient.h
[delete] https://crrev.com/76da73779963edf41bd7775000f4c04ce37f9f13/third_party/WebKit/public/web/WebTextCheckingType.h

Project Member

Comment 63 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba7cb1928cd87eed73ef04b19474ff757b516c09

commit ba7cb1928cd87eed73ef04b19474ff757b516c09
Author: xiaochengh <xiaochengh@chromium.org>
Date: Fri Aug 12 05:35:38 2016

Removal of grammar-checking-related dead code

This patch removes the following dead functions:
- static findBadGrammars() from TextCheckingHelper.cpp
- TextCheckerClient::checkGrammarOfString
- TextCheckingHelper::findFirstBadGrammar
- TextCheckingHelper::findFirstGrammarDetail
- TextCheckingHelper::markAllBadGrammar

This patch also does some follow-up cleanup to:
- SpellChecker::advanceToNextMisspelling
- TextCheckingHelper::findFirstMisspellingOrBadGrammar
- static checkTextOfParagraph() and FindMisspellings() in TextCheckingHelper.cpp

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2245543003
Cr-Commit-Position: refs/heads/master@{#411557}

[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/platform/text/TextCheckerClient.h
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
[modify] https://crrev.com/ba7cb1928cd87eed73ef04b19474ff757b516c09/third_party/WebKit/Source/web/SpellCheckerClientImpl.h

Project Member

Comment 64 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e34bbf30308de2f40faedccb857766835c6ab2

commit 94e34bbf30308de2f40faedccb857766835c6ab2
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 16 09:45:52 2016

Merge TextCheckingHelper into SpellChecker Part 1

Class TextCheckingHelper should be eliminated and merged into SpellChecker
because it is only used by SpellChecker::advanceToNextMisspelling() and does
not implement complicated logic.

This patch removes the class and changes its member functions into members
of SpellChecker. Followup patches will move the functions to SpellChecker.cpp
and cleanup the code.

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2246053003
Cr-Commit-Position: refs/heads/master@{#412200}

[modify] https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
[modify] https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/94e34bbf30308de2f40faedccb857766835c6ab2/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

Project Member

Comment 65 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3454acb3a76f88452bbfddabb7b3d13e112859b

commit b3454acb3a76f88452bbfddabb7b3d13e112859b
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Aug 16 10:44:41 2016

Merge TextCheckingHelper into SpellChecker Part 2

This patch moves the implementation of SpellChecker::findFirstMisspellingOrBadGrammar()
and SpellChecker::findMisspellings() from TextCheckingHelper.cpp
to SpellChecker.cpp without any other modification.

Followup patches will clean up the code.

Previous patches:
- Part 1: crrev.com/2246053003

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2253523002
Cr-Commit-Position: refs/heads/master@{#412209}

[modify] https://crrev.com/b3454acb3a76f88452bbfddabb7b3d13e112859b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/b3454acb3a76f88452bbfddabb7b3d13e112859b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp

Project Member

Comment 66 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85313d07c90a0ff9a229646aad87ecf6cee13a38

commit 85313d07c90a0ff9a229646aad87ecf6cee13a38
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 02:12:46 2016

Merge TextCheckingHelper into SpellChecker Part 3

This patch does code cleanup in SpellChecker.h/cpp after moving code
from TextCheckingHelper. Cleanup to TextCheckingHelper.h/cpp will be
done in followup patches.

Previous patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2247273002
Cr-Commit-Position: refs/heads/master@{#412422}

[modify] https://crrev.com/85313d07c90a0ff9a229646aad87ecf6cee13a38/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/85313d07c90a0ff9a229646aad87ecf6cee13a38/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Project Member

Comment 67 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10a153d1b5497dc3494ebe963abc574a06850cd

commit e10a153d1b5497dc3494ebe963abc574a06850cd
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 02:19:45 2016

Merge TextCheckingHelper into SpellChecker Part 4

This patch removes useless includes and forward declarations from
TextCheckingHelper.h/cpp. The removed code has become useless after
moving code to SpellChecker in previous patches.

This patch is part 4 of a series of patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002
- Part 3: http://crrev.com/2247273002

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2246923004
Cr-Commit-Position: refs/heads/master@{#412423}

[modify] https://crrev.com/e10a153d1b5497dc3494ebe963abc574a06850cd/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp
[modify] https://crrev.com/e10a153d1b5497dc3494ebe963abc574a06850cd/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

Project Member

Comment 68 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bdbfe4114fc567476b5f87ba547627ede13b308

commit 6bdbfe4114fc567476b5f87ba547627ede13b308
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 02:38:11 2016

Merge TextCheckingHelper into SpellChecker Part 5

This patch renames TextCheckingHelper.h/cpp to TextCheckingParagraph.h/cpp
because the class TextCheckingHelper no longer exists.

This patch is the final part of a series of patches:
- Part 1: http://crrev.com/2246053003
- Part 2: http://crrev.com/2253523002
- Part 3: http://crrev.com/2247273002
- part 4: http://crrev.com/2246923004

BUG=619452
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2251753002
Cr-Commit-Position: refs/heads/master@{#412432}

[modify] https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[rename] https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.cpp
[rename] https://crrev.com/6bdbfe4114fc567476b5f87ba547627ede13b308/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingParagraph.h

Project Member

Comment 69 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf

commit 922c87eb33d709ba9fb9332ecde0a1bcf72d86bf
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 07:33:14 2016

Remove paragraph range from SpellCheckRequest

|m_paragraphRange| is a redundant member of SpellCheckRequest because
it is always initiated with the same value as |m_checkingRange| [*]. So
this patch removes this redundant member.

[*] This claim was always true until revision r368035, where I allowed
a |SpellCheckRequest| to have two different ranges for the first time,
which is an unnecessary change, though.

BUG=619452
TEST=n/a; no visible change

Review-Url: https://codereview.chromium.org/2252973002
Cr-Commit-Position: refs/heads/master@{#412468}

[modify] https://crrev.com/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h
[modify] https://crrev.com/922c87eb33d709ba9fb9332ecde0a1bcf72d86bf/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Project Member

Comment 70 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ce09744c75c1060c10bd1ac75455db27429e73

commit c4ce09744c75c1060c10bd1ac75455db27429e73
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 17 12:07:32 2016

Remove parameter node from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar

This patch removes parameter |node| from the above mentioned function because
it can always be computed as the root editable element of |insertedRange|.

This patch is a preparation for reducing the use of TextCheckingParagraph in
spell checker, since TextCheckingParagraph was introduced for synchronous
spell checking which no longer exists now.

BUG=619452

Review-Url: https://codereview.chromium.org/2241293006
Cr-Commit-Position: refs/heads/master@{#412504}

[modify] https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/c4ce09744c75c1060c10bd1ac75455db27429e73/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Comment 71 by xiaoche...@chromium.org, Aug 26 2016

Status: Fixed (was: Started)

►

Issue 619452 link

Issue metadata

Get rid of grammar checking related code

Issue description

Comment 1 by yosin@chromium.org, Jun 13 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 27 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 27 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jun 29 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 22 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jul 22 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jul 22 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jul 22 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jul 22 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jul 22 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 22 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 22 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jul 25 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jul 25 2016

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Jul 25 2016

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Jul 25 2016

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Jul 25 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Jul 25 2016

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jul 25 2016

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Jul 25 2016

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Jul 25 2016

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Jul 25 2016

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Jul 26 2016

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Jul 26 2016

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Jul 26 2016

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Jul 26 2016

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Jul 26 2016

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Jul 26 2016

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Jul 27 2016

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Jul 27 2016

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Jul 27 2016

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Jul 27 2016

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Jul 27 2016

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Jul 27 2016

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Jul 27 2016

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Jul 27 2016

Comment 38 Deleted