New issue
Advanced search Search tips

Issue 619424 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

No keyboard shortcuts shown for Shift+Search in Ctrl+Alt+/ overlay

Reported by frnol...@gmail.com, Jun 12 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8172.47.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36
Platform: 8172.47.0 (Official Build) stable-channel quawks

Steps to reproduce the problem:
1. Shift+Search+[Volume Up key] raises context menu
2. Shift+Search+0 [zero key] raises context menu
3. Shift+Search+2 does page reload
4. Shift+Search+3 opens Find in Page dialog

These shortcuts are not mapped in the overlay mentioned in the summary; they should be (along with any other Shift+Search shortcuts)

What is the expected behavior?
Ctrl+Alt+/ overlay shows all shortcuts for Shift+Search combo

What went wrong?
No shortcuts are shown for Shift+Search but some exist

Did this work before? N/A 

Chrome version: 51.0.2704.79  Channel: stable
OS Version: 8172.47.0
Flash Version: 21.0.0.242-r1 (Disabled)

This is slightly related to  bug 616130 , except that it does not matter where the cursor is in the page for Shift+Search+VolumeUp, and at least some folks do not consider it a bug to have a keyboard shortcut that raises the context menu.
 
#CBC-RS/TC-watchlist

Owner: tbuck...@chromium.org
Status: Assigned (was: Unconfirmed)
tbuckley for decision.

Comment 3 Deleted

Cc: afakhry@chromium.org abodenha@chromium.org
Search+Escape shows Task Manager for me.

I'm surprised that these other shortcuts exist -- there seem to be more prominent shortcuts available, eg. Ctrl+F for find-in-page. I think it's good that we avoid redundancy in the keyboard shortcut overlay, but I'd also like to avoid redundancy in our shortcuts. Is there a reason to keep these around? If not, I'd vote for removing them.
My mistake on search+escape. I have been working through all the shortcuts to look for other missing ones.

I have deleted my previous comment.

Comment 6 by frnol...@gmail.com, Jun 22 2016

If I may: please retain one of the shortcuts for raising the context menu. This is a useful feature for those who favor the keyboard, and may be important for those who have difficulty with a mouse or touchpad. Thanks.
Yep, we'll absolutely keep one.
Owner: afakhry@chromium.org
Shift+Search+VolUp is listed in the manager as showing the context menu
Ctrl+R does page reload
Ctrl+F does find-in-page

@afakhry can we remove the following shortcuts?
- shift+search+0 (duplicate of shift+search+VolUp)
- shift+search+2 (does not trigger reload for me?)
- shift+search+3 (search+3 also triggers find-in-page)
Sure thing!
The keyboard overlay shows only a shortcut for Shift+Search+0, but no 
Shift+Search+2, or
Shift+Search+3.

So I will only remove Shift+Search+0.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf33bdcae3a0560499e73ba26c143f3aafb61601

commit cf33bdcae3a0560499e73ba26c143f3aafb61601
Author: afakhry <afakhry@chromium.org>
Date: Tue Feb 14 18:43:54 2017

Remove duplicate Shift+Search+0 entry in the keyboard overlay

BUG= 619424 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2692103003
Cr-Commit-Position: refs/heads/master@{#450419}

[modify] https://crrev.com/cf33bdcae3a0560499e73ba26c143f3aafb61601/chrome/browser/resources/chromeos/keyboard_overlay_data.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
59.0.3051.3/9408.0.0

Sign in to add a comment