The extension ID is for the bookmark manager.

https://cs.chromium.org/chromium/src/chrome/common/extensions/extension_constants.cc?l=32

Able to reproduce the issue and is a regression broken in M53 seeing on Windows 7, MAC 10.11.5 and Ubuntu 14.04. Below are the bisect details for the same:

Bisect Info:
============
53.0.2757.0 - Good Build
53.0.2758.0 - Bad Build

Change Log: https://chromium.googlesource.com/chromium/src/+log/c643d33cf668665bac4562e69a72f9ef29b5bbed..72c30193f0804fff83ed73d92db7d5fc5df6b186

Suspecting the below catapult change could be the root cause for the issue:

Change URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+/05cd4f2553bbacce40bb53b078e5c43d2b370a8e
Review-Url: https://codereview.chromium.org/2030043004

@ kbr: Assigning to you, request you to please take a look into it. Please help us to reassign to the right owner if not with respect to your change.

Adding release block label, please undo if not the case.

Thanks.!

Sorry, there's no way my CL affected the behavior here. It affects only the Telemetry test harness and not the behavior of the browser.

Looping shrike@ for further inputs.

Thank you!

@shrike: Could you please provide an update on this issue.

Thank you.

Based on blame for change to IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL in chrome/app/bookmarks_strings.grdp, suspecting https://chromium.googlesource.com/chromium/src/+/dca42159c2b19c25f033ff6e5e0da8d70a491576

Thanks, but this also wasn't me. I was just fixing an error made by a previous bulk-edit of strings. This is either:
a) caused by that bulk-edit (so +jshin)
b) caused by some other code which pulls in that string (so +thestig, who seems to own https://chromium.googlesource.com/chromium/src/+blame/master/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc)

I just move files around. I don't actually own it. Well, I do, but from very far away. Also, jshin's code review name has "OOO" in it.

I'll bisect some more.

Should this error have been caught before making it into the product? If not, what can we do to guard against errors like this?

Yes, perhaps there should be a test for this. +chrome/browser/bookmarks/OWNERS

A narrow bisects gets to https://chromium.googlesource.com/chromium/src/+log/a0d71a26bbb231efc212cf23081450a50344831a..1e4e7ee016f5e0ab8ff4e1902358c327bd234997 which still points at jshin. Uh, I'll just try to fix this.

Though I'm worried we have other places where the messages are bad, and we just haven't found them yet.

IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL was:

  Are you sure you want to open <ph name="TAB_COUNT">$1<ex>20</ex></ph> tabs?

then jshing@ changed to ICU's plural format:

  {TAB_COUNT, plural,
    one{Are you sure you want to open # tab?}
    other{Are you sure you want to open # tabs?}
  }

and agable@ updated to:

  {TAB_COUNT, plural,
    =1 {Are you sure you want to open # tab?}
   other {Are you sure you want to open # tabs?}
  }

for the translation console.

jshin@ correctly changed 1 place IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL was used:

  return ShowQuestionMessageBox(
             parent, l10n_util::GetStringUTF16(IDS_PRODUCT_NAME),
             l10n_util::GetPluralStringFUTF16(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL,
                                              child_count)) ==
         MESSAGE_BOX_RESULT_YES;

but not another:

    localized_strings->SetString("should_open_all",
        l10n_util::GetStringUTF16(IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL));

(oops)

This just sends a bunch of goop to the bookmarks manager, which also displays this string ONLY WHEN YOU TRY TO OPEN 15 OR MORE BOOKMARKS.

Basically, there's no reason for the singular version of this string.  It's only ever used when the number is 15+.

tl;dr - I'm dropping the plural and noting in the desc="" that <ph name="TAB_COUNT">'s replacement will only ever be 15 or more (i.e. is always plural).

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc?q=IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL&sq=package:chromium&l=143&dr=C
[2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc?q=IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL&sq=package:chromium&dr=C&l=491

fyi: here's the code that restricts to 15+ before displaying this string

https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/link_controller.js?q=should_open_all&sq=package:chromium&l=58,74,118-119&dr=C

https://cs.chromium.org/chromium/src/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc?q=IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL&sq=package:chromium&dr=C&l=60,138-139

soooo, while hunting this down I realized this prompt is completely broken in the bookmarks manager anyways (see: issue 623247).  opening a folder with 15+ bookmarks from the bookmarks *BAR* still works (and has a useful message again) with this CL: https://codereview.chromium.org/2098083002

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331ef7f54ea666407a123e92df2e39b97039bbb2

commit 331ef7f54ea666407a123e92df2e39b97039bbb2
Author: dbeam <dbeam@chromium.org>
Date: Sat Jun 25 01:07:46 2016

Bookmarks: revert ICU plural syntax for "Should we open all these bookmarks?" messsage

Basically a partial revert of r397608

R=thestig@chromium.org
BUG= 619392 

Review-Url: https://codereview.chromium.org/2098083002
Cr-Commit-Position: refs/heads/master@{#402037}

[modify] https://crrev.com/331ef7f54ea666407a123e92df2e39b97039bbb2/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/331ef7f54ea666407a123e92df2e39b97039bbb2/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc

see also: issue 623247 which i have not successfully circumvented by changing the Bookmark Manager's CSP yet