New issue
Advanced search Search tips

Issue 619388 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

OK GOogle doesn't work with Next

Project Member Reported by chaok@google.com, Jun 12 2016

Issue description

Mode: force_next
Version: 52.0.2743.32
Reproduction Steps: 
1. ENroll in OK GOogle
2. Using Next
3. Say OK Google followed by query

Observed:
Nothing

Expected:
OK GOogle to work with Next


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 12 2016

Labels: Hotlist-Google
Labels: -Pri-2 Phase3 Pri-1
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
One issue I'm seeing here is that when I click on the microphone icon on google.com, Next reads out the full content of the dialog that pops up to have the user enable okay google. But, I can't use chromevox navigation to get to those buttons to either enable or press no thanks.

Once I use the mouse to click on this icon, the feature works. The issue is actually the accessibility of that dialog with Next, though. 

Adding as P1 since this an issue with accessing UI on google.com 

Comment 3 by chaok@google.com, Jun 13 2016

THis dialog appears elsewhere (e.g. photo, microphone, notification, and location permissions). They're all inaccessible with NExt

Comment 4 by dtseng@chromium.org, Jun 15 2016

This mostly works in 53 except for a hang which I have a fix for.

Comment 5 by chaok@google.com, Jun 15 2016

I use to be able to use OK Google  a while ago on CLassic on my previous CHromeBOok
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d356e830cd6c653cf7979e16754faeef1e6f953

commit 4d356e830cd6c653cf7979e16754faeef1e6f953
Author: dtseng <dtseng@chromium.org>
Date: Wed Jun 15 23:42:03 2016

Fix alert dialog output.

An alert dialog uses $descendants for its enter rule, but this potentially results in infinite recursion since a descendant's format rule may walk up to the alert dialog to format an ancestor. We should never use children in the formatting of enter rules.

A specific case where this hits is in the
google.com -> search by voice

permissions dialog. Moving forward from the close button results in the above mentioned infinite recursion.

BUG= 619417 , 619388 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2075473002
Cr-Commit-Position: refs/heads/master@{#400044}

[modify] https://crrev.com/4d356e830cd6c653cf7979e16754faeef1e6f953/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Comment 7 by dtseng@chromium.org, Jun 15 2016

Status: fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on 53.0.2768.0

Comment 9 by chaok@google.com, Jun 18 2016

"OK, GOogle" doesn't respond for me.
In addition, "retrain voice model" link in chrome://settings is non-functional with ENTER, SPACEBAR, or SEARCH+SPACEBAR.

Comment 10 by chaok@google.com, Jul 8 2016

OK GOogle still doesn't work for me on:
54.0.2787.0
I re-enrolled OK GOogle, but don't hear chime after saying OK Google post-enrollment

Comment 11 by chaok@google.com, Aug 31 2016

I went to TEchStop to debug this further:
1. Dell ChromeBook (stable build) with ChromeVOx Classic does *not* have voice training, nor does OK GOogel trigger.
2. Samus (Canary) with cvox2 has VOice Training (works fine), but hotwording does not trigger (nor does microphone show in a fresh tab). We also tried without cvox, which had the same result. 

We went through various debugging/troubleshooting docs for "OK Google" on Chrome OS, but couldn't get it to work on 2 different ChromeBooks.

Sign in to add a comment