New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619372 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in usrsctp_dumppacket

Project Member Reported by ClusterFuzz, Jun 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5401728401014784

Fuzzer: phoglund_webrtc_peerconnection
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x06e173d4
Crash State:
  usrsctp_dumppacket
  cricket::SctpDataMediaChannel::OnPacketReceived
  cricket::DataMediaChannel::~DataMediaChannel
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_chrome&range=398942:399015

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95eKGobLVDTuUHLl7Bt4j6T9Dt75dm0A9NGXsqhgEKDfl0Hkl5OFY11N5aC8ZfHYHrKtWGblXuX-WCVI7oaLYjsqQIMW5sWANkmv11rU5F0jldcctvVBw_g3SfykAYK2NkBGyY6bIu-YZDWM2yNhjEn10cVqlKiXCHfw76esWpUiqeBlhw


Additional requirements: Requires HTTP

Filer: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>WebRTC
Owner: phoglund@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 12 2016

Labels: Pri-1
Cc: katrielc@chromium.org tommi@chromium.org deadbeef@chromium.org
Owner: pthatcher@chromium.org
pthatcher, deadbeef, looks like the fuzzer found an overflow in sctp data media channels. Can you discuss and help with an owner? I didn't find anything obvious in the blame list here, but the error at least appears to be reproducible so I hope it should be possible to debug what's going on here.
Cc: phoglund@chromium.org
Labels: M-51
I think I found the issue just by inspecting the code. See: https://codereview.webrtc.org/2061093003/

I have *no* idea how we didn't find this earlier... I guess we don't usually run tests with verbose logging enabled?
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 14 2016

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 8 by ClusterFuzz, Jun 15 2016

ClusterFuzz has detected this testcase as flaky and is unable to reproduce it in the original crash revision. Skipping fixed testing check and marking it as potentially fixed.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5401728401014784

Fuzzer: phoglund_webrtc_peerconnection
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x06e173d4
Crash State:
  usrsctp_dumppacket
  cricket::SctpDataMediaChannel::OnPacketReceived
  cricket::DataMediaChannel::~DataMediaChannel
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_asan_chrome&range=398942:399015

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95eKGobLVDTuUHLl7Bt4j6T9Dt75dm0A9NGXsqhgEKDfl0Hkl5OFY11N5aC8ZfHYHrKtWGblXuX-WCVI7oaLYjsqQIMW5sWANkmv11rU5F0jldcctvVBw_g3SfykAYK2NkBGyY6bIu-YZDWM2yNhjEn10cVqlKiXCHfw76esWpUiqeBlhw


Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Owner: deadbeef@chromium.org
Status: Verified (was: Assigned)
Looks like it was successfully fixed by this CL: https://codereview.webrtc.org/2061093003/
Project Member

Comment 10 by ClusterFuzz, Jun 15 2016

Labels: Merge-Triage M-52
Adding Merge-Triage label for tracking purposes.

Once your fix had sufficient bake time (on canary, dev as appropriate), please nominate your fix for merge by adding the Merge-Request-XX label, where XX is the Chrome milestone.

When your merge is approved by the release manager, please start merging with higher milestone label first. Make sure to re-request merge for every milestone in the label list. You can get branch information on omahaproxy.appspot.com.

- Your friendly ClusterFuzz
I'm not sure if this really needs merging, since it only occurs if you enable verbose logging.
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 16 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Merge-Triage -M-51 Merge-Request-53
If this require a merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Labels: -Merge-Request-53
This fix is already in M53. I'll remove the merge request label.
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 22 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment