New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in SkAutoCanvasMatrixPaint::SkAutoCanvasMatrixPaint

Project Member Reported by ClusterFuzz, Jun 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5676342972776448

Fuzzer: ifratric_acrojs
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN READ
Crash Address: 0x000000001110
Crash State:
  SkAutoCanvasMatrixPaint::SkAutoCanvasMatrixPaint
  SkCanvas::drawPicture
  printing::PdfMetafileSkia::FinishDocument
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=398731:398752

Minimized Testcase (312.51 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95gLFu3LfGjp9O03gbJVIcjBlGsOfpU1e4-qzbXwiDztkAPmXFgkYAU2Ov_3NKYGT0eEbFcmYJTSqpb6ZGN-GIogpW7TdOxNKnkL-1Jt3Mzc86w6xGkWnKYe_Jjh29lLXD5lGU56A6Pjtti-7pnCqdGWkdA17EAKNfwtvc8og94UgNmy_k

Filer: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: reed@chromium.org
Components: Internals>Skia
Owner: halcanary@chromium.org
Status: Assigned (was: Available)
Author: halcanary
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/223f70ac109b1a06a248852bfe2067848ac2a5f9
Time: Thu Jun 09 00:07:42 2016
Lines 180 of file pdf_metafile_skia.cc which potentially caused crash are changed in this cl (frame #5, "printing::PdfMetafileSkia::FinishDocument").
Minimum distance from crash line to modified line: 0. (file: pdf_metafile_skia.cc, crashed on: 177, modified: 177).

Suspected Project: chromium
Suspected Component: Internals>Printing
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 12 2016

Labels: Pri-1
Status: Started (was: Assigned)
https://crrev.com/2067473003
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd6f024c76e6b34b93bbc985efdfad27fc90441

commit 8dd6f024c76e6b34b93bbc985efdfad27fc90441
Author: halcanary <halcanary@google.com>
Date: Mon Jun 13 19:40:23 2016

PdfMetafileSkia: don't rely on SkPicture::cullRect

BUG= 619371 

Review-Url: https://codereview.chromium.org/2062903002
Cr-Commit-Position: refs/heads/master@{#399507}

[modify] https://crrev.com/8dd6f024c76e6b34b93bbc985efdfad27fc90441/printing/pdf_metafile_skia.cc

Labels: M-52
Project Member

Comment 6 by ClusterFuzz, Jun 14 2016

ClusterFuzz has detected this issue as fixed in range 399504:399530.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5676342972776448

Fuzzer: ifratric_acrojs
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN READ
Crash Address: 0x000000001110
Crash State:
  SkAutoCanvasMatrixPaint::SkAutoCanvasMatrixPaint
  SkCanvas::drawPicture
  printing::PdfMetafileSkia::FinishDocument
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=398731:398752
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=399504:399530

Minimized Testcase (312.51 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95gLFu3LfGjp9O03gbJVIcjBlGsOfpU1e4-qzbXwiDztkAPmXFgkYAU2Ov_3NKYGT0eEbFcmYJTSqpb6ZGN-GIogpW7TdOxNKnkL-1Jt3Mzc86w6xGkWnKYe_Jjh29lLXD5lGU56A6Pjtti-7pnCqdGWkdA17EAKNfwtvc8og94UgNmy_k

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 14 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dd6f024c76e6b34b93bbc985efdfad27fc90441

commit 8dd6f024c76e6b34b93bbc985efdfad27fc90441
Author: halcanary <halcanary@google.com>
Date: Mon Jun 13 19:40:23 2016

PdfMetafileSkia: don't rely on SkPicture::cullRect

BUG= 619371 

Review-Url: https://codereview.chromium.org/2062903002
Cr-Commit-Position: refs/heads/master@{#399507}

[modify] https://crrev.com/8dd6f024c76e6b34b93bbc985efdfad27fc90441/printing/pdf_metafile_skia.cc

Project Member

Comment 10 by ClusterFuzz, Jun 15 2016

Labels: Merge-Triage
Adding Merge-Triage label for tracking purposes.

Once your fix had sufficient bake time (on canary, dev as appropriate), please nominate your fix for merge by adding the Merge-Request-XX label, where XX is the Chrome milestone.

When your merge is approved by the release manager, please start merging with higher milestone label first. Make sure to re-request merge for every milestone in the label list. You can get branch information on omahaproxy.appspot.com.

- Your friendly ClusterFuzz
Cc: awhalley@chromium.org nparker@chromium.org
Labels: -M-52 -Merge-Triage M-53
Regressed in 398731, initially in 53.0.2763.0 so don't need in M52, or am I missing something nparker@?
sounds right to me.
yup, my mistake.
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 21 2016

Labels: -Restrict-View-SecurityNotify
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic

Sign in to add a comment