linux_chromium_msan_rel_ng is useless |
||||
Issue descriptionThe linux_chromium_msan_rel_ng bot on tryserver.chromium.linux is configured to mirror the "MSAN Builder" and "MSAN Tests" bots on chromium.memory.fyi. However, it appears to be constantly red when the continuous builders are green, even for no-op try jobs. This makes it more-or-less useless. My initial theory is that since DCHECKs are enabled on the trybot but not the waterfall bot, we're detecting sanitizer errors that the waterfall bot simply doesn't see. Whether this would be due to timing differences or differences in the code being executed, I don't know.
,
Jun 12 2016
,
Jun 13 2016
It does look like DCHECKs are the culprit ... I've posted a CL to turn them off: https://codereview.chromium.org/2063583002/.
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 commit 21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 Author: dpranke <dpranke@chromium.org> Date: Mon Jun 13 18:44:32 2016 Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG= 619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng Review-Url: https://codereview.chromium.org/2063583002 Cr-Commit-Position: refs/heads/master@{#399492} [modify] https://crrev.com/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1/tools/mb/mb_config.pyl
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 commit 21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 Author: dpranke <dpranke@chromium.org> Date: Mon Jun 13 18:44:32 2016 Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG= 619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng Review-Url: https://codereview.chromium.org/2063583002 Cr-Commit-Position: refs/heads/master@{#399492} [modify] https://crrev.com/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1/tools/mb/mb_config.pyl
,
Jun 15 2016
This should be fixed now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jun 12 2016