Issue metadata
Sign in to add a comment
|
Crash: [Renderer kill] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker |
||||||||||||||||||||||||
Issue descriptionCrash Signature: [Renderer kill] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker Process Type: Browser Platform: Android Channel: Dev Version: 53.0.2763.0 Distinct Clients: 5 CPM: 1.16 Crash Reports: 5 Median Uptime: 09m:50s Infected Clients: 0.0% Sample Reports: https://crash.corp.google.com/browse?q=reportid=%270cde47dc00000000%27 https://crash.corp.google.com/browse?q=reportid=%27abfde6ba00000000%27 https://crash.corp.google.com/browse?q=reportid=%2722cbbaba00000000%27 https://crash.corp.google.com/browse?q=reportid=%277b89b38600000000%27 https://crash.corp.google.com/browse?q=reportid=%27dd06778600000000%27 Crash Link: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20product.version%3D%2753.0.2763.0%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20kill%5D%20content%3A%3AServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27 Crash Link (with version impact distribution): https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20kill%5D%20content%3A%3AServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27 Crash Stacktrace: DUMP_REQUESTED (0x62d6ff2f) #0 0x62d6ff2f in google_breakpad::ExceptionHandler::WriteMinidump breakpad/src/client/linux/handler/exception_handler.cc:651 #1 0x623ee295 in DumpProcess components/crash/content/app/breakpad_linux.cc:558 #2 0x61a162f3 in content::BrowserMessageFilter::ShutdownForBadMessage content/public/browser/browser_message_filter.cc:169 #3 0x61d41a4f in content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker content/browser/service_worker/service_worker_dispatcher_host.cc:489 #4 0x61d40429 in base::DispatchToMethod<content::ServiceWorkerDispatcherHost*, void , int, int, int, long long int> base/tuple.h:126 #5 0x6106f821 in content::ServiceWorkerDispatcherHost::OnMessageReceived ipc/ipc_message_templates.h:26 #6 0x6105c945 in content::BrowserMessageFilter::Internal::OnMessageReceived content/public/browser/browser_message_filter.cc:70 #7 0x6110822f in TryFiltersImpl ipc/message_filter_router.cc:22 #8 0x61108183 in IPC::ChannelProxy::Context::TryFilters ipc/ipc_channel_proxy.cc:80 #9 0x61061889 in IPC::ChannelProxy::Context::OnMessageReceived ipc/ipc_channel_proxy.cc:97 #10 0x61213da1 in IPC::ChannelMojo::OnMessageReceived ipc/mojo/ipc_channel_mojo.cc:377 #11 0x61213b3d in IPC::internal::MessagePipeReader::Receive ipc/mojo/ipc_message_pipe_reader.cc:138 #12 0x61213907 in IPC::mojom::ChannelStub::Accept out/Release/gen/ipc/mojo/ipc.mojom.cc:606 #13 0x61212763 in mojo::internal::InterfaceEndpointClient::HandleValidatedMessage mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:307 #14 0x6121336b in IPC::mojom::ChannelRequestValidator::Accept out/Release/gen/ipc/mojo/ipc.mojom.cc:646 #15 0x61212497 in mojo::internal::MultiplexRouter::ProcessIncomingMessage mojo/public/cpp/bindings/lib/multiplex_router.cc:775 #16 0x612122c9 in mojo::internal::MultiplexRouter::Accept mojo/public/cpp/bindings/lib/multiplex_router.cc:495 #17 0x60eab049 in mojo::internal::MessageHeaderValidator::Accept mojo/public/cpp/bindings/lib/message_header_validator.cc:73 #18 0x60eaa861 in mojo::internal::Connector::ReadSingleMessage mojo/public/cpp/bindings/lib/connector.cc:271 #19 0x60eaa7ff in mojo::internal::Connector::ReadAllAvailableMessages mojo/public/cpp/bindings/lib/connector.cc:297 #20 0x60eaa7a9 in mojo::Watcher::OnHandleReady base/callback.h:397 #21 0x60ea1a6b in mojo::Watcher::CallOnHandleReady mojo/public/cpp/system/watcher.cc:142 #22 0x60ea1a31 in base::internal::Invoker<base::IndexSequence<0u, 1u>, base::internal::BindState<base::internal::RunnableAdapter<void >::Run base/bind_internal.h:160 #23 0x60ea1a0d in mojo::edk::Watcher::MaybeInvokeCallback base/callback.h:397 #24 0x60e9d123 in mojo::edk::RequestContext::~RequestContext mojo/edk/system/request_context.cc:49 #25 0x611069bb in mojo::edk::NodeChannel::OnChannelMessage mojo/edk/system/node_channel.cc:453 #26 0x61106641 in mojo::edk::Channel::OnReadComplete mojo/edk/system/channel.cc:553 #27 0x611063eb in ChannelPosix::OnFileCanReadWithoutBlocking mojo/edk/system/channel_posix.cc:281 #28 0x6103ffc9 in base::MessagePumpLibevent::OnLibeventNotification base/message_loop/message_pump_libevent.cc:95 #29 0x60fd03b3 in event_base_loop base/third_party/libevent/event.c:381 #30 0x60fcff8b in base::MessagePumpLibevent::Run base/message_loop/message_pump_libevent.cc:254 #31 0x60fcfdf7 in base::MessageLoop::RunHandler base/message_loop/message_loop.cc:439 #32 0x60fcfda3 in base::RunLoop::Run base/run_loop.cc:35 #33 0x60fcfd4f in base::MessageLoop::Run base/message_loop/message_loop.cc:294 #34 0x610218d9 in content::BrowserThreadImpl::IOThreadRun content/browser/browser_thread_impl.cc:215 #35 0x60fdee2d in content::BrowserThreadImpl::Run content/browser/browser_thread_impl.cc:251 #36 0x60fcd593 in base::Thread::ThreadMain base/threading/thread.cc:256 #37 0x60fcd3b1 in ThreadFunc base/threading/platform_thread_posix.cc:70 #38 0x4006b602 in libc.so+0xd602 Reporter: ajha
,
Jun 11 2016
This appeared first on 52.0.2739.3 on Android Dev. Considering previous Dev as the good build and below as the regression range: https://chromium.googlesource.com/chromium/src/+log/52.0.2735.0..52.0.2739.0?pretty=fuller&n=10000 Suspected change: https://codereview.chromium.org/1977473003 nhiroki@: Could you please take a look at the change or help in investigating this further. Thank you!
,
Jun 27 2016
** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks ** M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!
,
Jun 29 2016
,
Jun 29 2016
I think this is not so serious and we don't have to treat this as a release blocker. This happens when ServiceWorkerDispatcherHost detects a malformed IPC message. First we may need to judge whether this detection is false-positive or not.
,
Jun 29 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 30 2016
,
Jul 5 2016
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6 2016
Users experienced this crash on the following builds: Mac Canary 54.0.2788.0 - 1.52 CPM, 1 reports, 1 clients (signature [Renderer kill] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker) Android Dev 53.0.2782.9 - 0.51 CPM, 15 reports, 12 clients (signature [Renderer kill] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Jul 19 2016
Magic signatures have been updated to show the reason code. This bug's magic signature has changed to "[Renderer kill 54] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker" Reason code 54 is SWDH_UNREGISTER_CANNOT
,
Jul 22 2016
Undoing sheriffbot's move to Pri2. This is a top SW crasher on M52, but we may have missed the boat for that.
,
Jul 26 2016
nhiroki@ Are you handling this issue now?
,
Jul 27 2016
No, I haven't started this yet. Do you think you can take a look at this with issue 630495 and issue 630496 ? Reasons of them would be the same.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/587e8127d8c3fda4d66fea1da6fec3ff9890588e commit 587e8127d8c3fda4d66fea1da6fec3ff9890588e Author: horo <horo@chromium.org> Date: Fri Jul 29 02:49:49 2016 Add crash keys for ServiceWorkerDispatcherHost crashes BUG= 619294 ,630495,630496 Review-Url: https://codereview.chromium.org/2190513002 Cr-Commit-Position: refs/heads/master@{#408561} [modify] https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e/blimp/engine/app/blimp_engine_crash_keys.cc [modify] https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e/chrome/common/crash_keys.cc [modify] https://crrev.com/587e8127d8c3fda4d66fea1da6fec3ff9890588e/content/browser/service_worker/service_worker_dispatcher_host.cc
,
Jul 29 2016
Re: #15 I think this issue 619294 (OnUnregisterServiceWorker) is caused by another reason than issue 630495 (OnGetRegistration) and issue 630496 (OnRegisterServiceWorker). 1. We are receiving much more crash reports in OnUnregisterServiceWorker than OnGetRegistration and OnRegisterServiceWorker (especially on Android). - OnUnregisterServiceWorker: 2290 (W:906, M:144, A:1164, C:76) - OnRegisterServiceWorker: 111 (W:15, M:81, A:15, C:0) - OnGetRegistration : 65 (W:26, M:22, A:7, C:0) 2. I'm not 100% sure but I think many of crashes in OnRegisterServiceWorker and OnGetRegistration are from developers environment. It is because we can find Lighthouse extension ID (blipmdconlkpinefehnmjammfjpmpbjk) and "--disable-web-security" "--unsafely-treat-insecure-origin-as-secure" flags in those crash reports. 3. I can reproduce the crashes in OnRegisterServiceWorker and OnGetRegistration by just calling navigator.serviceWorker.register()/getRegistration() with different origin URL when I set "--disable-web-security" flag. I created a fix patch and test code for this: https://crrev.com/2196633002 But I can't reproduce the crash in OnUnregisterServiceWorker. ServiceWorkerDisableWebSecurityTest::RegisterNoCrash test in the patch doesn't crash even without the change in CanRegisterServiceWorker(). It is because when we call ServiceWorkerRegistration::unregister(), ServiceWorkerContainerClient and ServiceWorkerProviderID is acquired from the registration's ExecutionContext. - OnUnregisterServiceWorker: https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27ServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27Renderer%20kill%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D - OnRegisterServiceWorker: https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27ServiceWorkerDispatcherHost%3A%3AOnRegisterServiceWorker%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27Renderer%20kill%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D - OnGetRegistration: https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27ServiceWorkerDispatcherHost%3A%3AOnGetRegistration%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27Renderer%20kill%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D Let's look at it deeper next week. I think we will have useful URL crash keys.
,
Jul 29 2016
> But I can't reproduce the crash in OnUnregisterServiceWorker. > ServiceWorkerDisableWebSecurityTest::RegisterNoCrash test in the patch doesn't > crash even without the change in CanRegisterServiceWorker(). It is because > when we call ServiceWorkerRegistration::unregister(), > ServiceWorkerContainerClient and ServiceWorkerProviderID is acquired from the > registration's ExecutionContext But I can't reproduce the crash in OnUnregisterServiceWorker. ServiceWorkerDisableWebSecurityTest::UnregisterNoCrash test in the patch doesn't crash even without the change in CanUnregisterServiceWorker(). It is because when we call ServiceWorkerRegistration::unregister(), ServiceWorkerContainerClient and ServiceWorkerProviderID is acquired from the registration's ExecutionContext. Is correct.
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44 commit c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44 Author: horo <horo@chromium.org> Date: Mon Aug 01 12:42:54 2016 [ServiceWorker] Don't check the origin equality when disable-web-security flag is set. When "disable-web-security" flag is set, we don't check the origin equality in Blink. So we shouldn't check it in content side. BUG= 619294 ,630495,630496 Review-Url: https://codereview.chromium.org/2196633002 Cr-Commit-Position: refs/heads/master@{#408948} [modify] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/browser/service_worker/service_worker_dispatcher_host.cc [modify] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/common/service_worker/service_worker_utils.cc [modify] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/common/service_worker/service_worker_utils.h [add] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/test/data/service_worker/disable_web_security_get_registration.html [add] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/test/data/service_worker/disable_web_security_register.html [add] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/test/data/service_worker/disable_web_security_unregister.html [add] https://crrev.com/c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44/content/test/data/service_worker/disable_web_security_update.html
,
Aug 4 2016
For reference: commit c19aeb3cd6b368a2ba4e46bd76fefe42a7f11e44 was: initially in 54.0.2816.0
,
Aug 4 2016
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f65883a9c0e0412cf5fef1cf9c5f6091bbbfd325 commit f65883a9c0e0412cf5fef1cf9c5f6091bbbfd325 Author: nhiroki <nhiroki@chromium.org> Date: Thu Aug 04 09:54:42 2016 ServiceWorker: Change DCHECK to CHECK for debugging BUG= 619294 Review-Url: https://codereview.chromium.org/2208393002 Cr-Commit-Position: refs/heads/master@{#409751} [modify] https://crrev.com/f65883a9c0e0412cf5fef1cf9c5f6091bbbfd325/content/browser/service_worker/service_worker_context_core.cc
,
Aug 8 2016
Users experienced this crash on the following builds: Win Canary 54.0.2823.0 - 0.30 CPM, 3 reports, 3 clients (signature [Renderer kill 54] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker) Mac Dev 54.0.2816.4 - 0.31 CPM, 3 reports, 1 clients (signature [Renderer kill 54] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker) Android Dev 53.0.2785.44 - 0.67 CPM, 21 reports, 21 clients (signature [Renderer kill 54] content::ServiceWorkerDispatcherHost::OnUnregisterServiceWorker) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Aug 15 2016
I investigated the scopes of registration when it's crashed. [1] is the query. I expected these crashes are caused by claim() related to Issue 634222 , but, for example, a service worker script on https://touch.mail.ru/ doesn't have claim(). I'll investigate more. [1]: https://crash.corp.google.com/dremel_query_ui?q=select%20productdata.Value%2C%20count(productdata.Value)%20as%20c%20%0Afrom%0A%20crash.prod.latest%20%0Awhere%20%0A%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27ServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27%0A%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27Renderer%20kill%27%0A%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20kill%2054%5D%20content%3A%3AServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27%0A%20AND%20productdata.Key%20CONTAINS%20%27swdh_unregister_cannot_scope_url-1%27%20%0Agroup%20by%20%0A%20productdata.Value%20%0Aorder%20by%20%0A%20c%20desc
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90ac0459a2f02d2eaae991314f9b540f9fa97f4a commit 90ac0459a2f02d2eaae991314f9b540f9fa97f4a Author: shimazu <shimazu@chromium.org> Date: Tue Aug 23 07:03:39 2016 ServiceWorker: Call SyncMatchingRegistration when document_url is changed For details: https://crbug.com/634222 BUG= 634222 , 619294 , 454250 Review-Url: https://codereview.chromium.org/2245063003 Cr-Commit-Position: refs/heads/master@{#413682} [modify] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/content/browser/service_worker/service_worker_request_handler.cc [add] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/third_party/WebKit/LayoutTests/http/tests/serviceworker/claim-with-redirect.html [add] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/claim-with-redirect-iframe.html [add] https://crrev.com/90ac0459a2f02d2eaae991314f9b540f9fa97f4a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/update-claim-worker.php
,
Aug 26 2016
shimazu@ landed a promising fix and he is now monitoring the dashboard.
,
Aug 27 2016
Issue 641546 has been merged into this issue.
,
Aug 27 2016
I just merged bug 641546 , which has a simple repro for this crash. I managed to reproduce it on my Chromebook, but not on my Linux/Windows desktop.
,
Aug 29 2016
This seems to be caused by the same root with Issue 634222 .
,
Aug 29 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bf12b246a2546fe2b9386df0f7893617a0eb64f commit 7bf12b246a2546fe2b9386df0f7893617a0eb64f Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Sep 02 05:28:34 2016 [M53] ServiceWorker: Call SyncMatchingRegistration when document_url is changed Committing on behalf of shimazu@. For details: https://crbug.com/634222 BUG= 634222 , 619294 , 454250 Review-Url: https://codereview.chromium.org/2245063003 Cr-Commit-Position: refs/heads/master@{#413682} (cherry picked from commit 90ac0459a2f02d2eaae991314f9b540f9fa97f4a) Review URL: https://codereview.chromium.org/2300293002 . Cr-Commit-Position: refs/branch-heads/2785@{#809} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/content/browser/service_worker/service_worker_request_handler.cc [add] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/third_party/WebKit/LayoutTests/http/tests/serviceworker/claim-with-redirect.html [add] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/claim-with-redirect-iframe.html [add] https://crrev.com/7bf12b246a2546fe2b9386df0f7893617a0eb64f/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/update-claim-worker.php
,
Sep 5 2016
This problem didn't seem to happen after my patch is landed (54.0.2838), and the fix is already merged into M53 (53.0.2785.94). https://crash.corp.google.com/dremel_query_ui?q=select%0A%20REPLACE(product.Version%2C%20%27.0.%27%2C%20%27.%27)%20as%20v%2C%20count(product.Version)%20as%20c%0Afrom%0A%20crash.prod.latest%0Awhere%0A%20%20product.name%20CONTAINS%20%27Chrome%27%0A%20%20AND%20REGEXP(product.Version%2C%20r%27%5E%5Cd%7B2%7D(%5C.0)%3F%5C.%5Cd%7B4%7D%27)%0A%20%20AND%20(REPLACE(product.Version%2C%20%27.0.%27%2C%20%27.%27)%20%3E%3D%20%27xx.yyyy%27%20OR%20SUBSTR(product.Version%2C%201%2C%202)%20%3E%3D%20%2754%27)%0A%20%20AND%20(custom_data.ChromeCrashProto.magic_signature_1.file_path%20CONTAINS%20%27serviceworker%27%20OR%20custom_data.ChromeCrashProto.magic_signature_1.file_path%20CONTAINS%20%27service_worker%27)%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20kill%2054%5D%20content%3A%3AServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27%0Agroup%20by%0A%20%20v%0Aorder%20by%0A%20%20v%20desc
,
Sep 5 2016
Great work! :)
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7194546a50bbbc4c39425825459fea8f14805f99 commit 7194546a50bbbc4c39425825459fea8f14805f99 Author: shimazu <shimazu@chromium.org> Date: Fri Dec 09 02:17:41 2016 ServiceWorker: add crash keys for debugging of IPCs and remove old keys This patch is to check if the process_id() is kInvalidUniqueID or the value itself is valid. Additionally, I removed several crash keys which was for an issue which has been fixed. BUG=668633, 619294 Review-Url: https://codereview.chromium.org/2560873004 Cr-Commit-Position: refs/heads/master@{#437432} [modify] https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99/blimp/engine/app/blimp_engine_crash_keys.cc [modify] https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99/chrome/app/chrome_crash_reporter_client_win.cc [modify] https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99/chrome/common/crash_keys.cc [modify] https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99/chromecast/crash/cast_crash_keys.cc [modify] https://crrev.com/7194546a50bbbc4c39425825459fea8f14805f99/content/browser/service_worker/service_worker_dispatcher_host.cc
,
Mar 1 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14c3371a8f2bb2ea82fd8c4fa5c36851b59325dc commit 14c3371a8f2bb2ea82fd8c4fa5c36851b59325dc Author: xiaofeng.zhang <xiaofeng.zhang@intel.com> Date: Thu Jun 15 12:11:59 2017 ServiceWorker: Change CHECK to DHECK in ServiceWorkerContextCore This is a follow-up work after the bug is fixed. BUG= 619294 Review-Url: https://codereview.chromium.org/2943453002 Cr-Commit-Position: refs/heads/master@{#479674} [modify] https://crrev.com/14c3371a8f2bb2ea82fd8c4fa5c36851b59325dc/content/browser/service_worker/service_worker_context_core.cc
,
Jun 20 2017
There are no crash observed since : 53.0.2767.6, hence adding TE-Verified labels List to the link of builds: ============================ https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BRenderer%20kill%5D%20content%3A%3AServiceWorkerDispatcherHost%3A%3AOnUnregisterServiceWorker%27 Thank You... |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jun 11 2016