New issue
Advanced search Search tips

Issue 619279 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

N/P in Groups Errors

Project Member Reported by chaok@google.com, Jun 11 2016

Issue description

Mode: force_next
Version: 52.0.2743.32
Reproduction Steps: 
1. Navigate to GOogle Groups of interest
2. Open thread
3. Use N/P to navigate by  messages

Observed:
Error earcon

Expected:
Next equivalent of Classic, where focused message is read

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 11 2016

Labels: Hotlist-Google
Labels: Phase3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
This is still an issue with CVok 55.0.2878.0

Comment 4 by dtseng@chromium.org, Oct 11 2016

Status: fixed (was: Assigned)
Note: no need to re-ping the issue if there isn't any change in status. This was fixed by another cl. Please verify.

Comment 5 by chaok@google.com, Oct 15 2016

Status: Started (was: Fixed)
Not fixed in: 56.0.2890.0

Comment 6 by dtseng@chromium.org, Oct 16 2016

Status: Wontfix (was: Started)
The reproduction isn't what I'm seeing. This is one instance where groups makes a bad aria implementation. Classic ignored much of it by not being compliant. As for the error tone, next has no error tone. What I'm guessing the reporter is seeing is the earcons for the unlabelled text fields at the beginning of each message. The cl I checked in fixed an issue with the way earcons sync with speech so that multiple earcons don't play at the same time. 

Comment 7 by chaok@google.com, Oct 16 2016

Status: Verified (was: WontFix)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0026818d58dc22ebea46fe8ff31456aa0ac7bf65

commit 0026818d58dc22ebea46fe8ff31456aa0ac7bf65
Author: dtseng <dtseng@chromium.org>
Date: Thu Oct 20 16:37:15 2016

Further refine div output when a div receives focus

This cl makes div output the same way as classic:
- when a div receives either ChromeVox or page focus, read its text content or its aria label
- this cleans up output and retains the previously hardened behavior in Classic.

TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience.
BUG= 619279 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2433823003
Cr-Commit-Position: refs/heads/master@{#426497}

[modify] https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac37777c7afe66308015d5c1461a519d91ff7735

commit ac37777c7afe66308015d5c1461a519d91ff7735
Author: mathp <mathp@chromium.org>
Date: Fri Oct 21 15:47:30 2016

Revert of Further refine div output when a div receives focus (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2433823003/ )

Reason for revert:
Speculative revert to fix failing bots

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28199

Original issue's description:
> Further refine div output when a div receives focus
>
> This cl makes div output the same way as classic:
> - when a div receives either ChromeVox or page focus, read its text content or its aria label
> - this cleans up output and retains the previously hardened behavior in Classic.
>
> TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience.
> BUG= 619279 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65
> Cr-Commit-Position: refs/heads/master@{#426497}

TBR=dmazzoni@chromium.org,dtseng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 619279 

Review-Url: https://chromiumcodereview.appspot.com/2443603002
Cr-Commit-Position: refs/heads/master@{#426799}

[modify] https://crrev.com/ac37777c7afe66308015d5c1461a519d91ff7735/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/ac37777c7afe66308015d5c1461a519d91ff7735/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1bc4757d76f7c9cf83962c112f1a6be24320854

commit a1bc4757d76f7c9cf83962c112f1a6be24320854
Author: dtseng <dtseng@chromium.org>
Date: Fri Oct 21 17:38:59 2016

Reland: Further refine div output when a div receives focus

This cl makes div output the same way as classic:
- when a div receives either ChromeVox or page focus, read its text content or its aria label
- this cleans up output and retains the previously hardened behavior in Classic.

TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience.
BUG= 619279 
TBR=dtseng@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65
Cr-Commit-Position: refs/heads/master@{#426497}

patch from issue 2433823003 at patchset 20001 (http://crrev.com/2433823003#ps20001)

Review-Url: https://chromiumcodereview.appspot.com/2441033002
Cr-Commit-Position: refs/heads/master@{#426833}

[modify] https://crrev.com/a1bc4757d76f7c9cf83962c112f1a6be24320854/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/a1bc4757d76f7c9cf83962c112f1a6be24320854/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Sign in to add a comment