New issue
Advanced search Search tips

Issue 619266 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: 2016-11-23
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Text in permission dialog isn't read

Project Member Reported by chaok@google.com, Jun 11 2016

Issue description

Mode: force_next
Version: 52.0.2743.32
Reproduction Steps: 
1. Visit a page that will request for location/notificationpermissions
2. Search+Arrows to read text in dialog

Observed:
TExt in permission dialog isn't auauto-read and cannot be interacted with

Expected:
TExt to be read when diallog opens and interactable with search+arrows


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 11 2016

Labels: Hotlist-Google
Labels: Phase3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/319f110637783ce562ad6092120441756572e644

commit 319f110637783ce562ad6092120441756572e644
Author: dtseng <dtseng@chromium.org>
Date: Fri Nov 18 22:44:28 2016

Ensure fake alert window attached to AXAura tree and refine alert dialog output

- in the AXAura tree, we use a fake (undrawn) window to support raw text string alerts from callers. Previously, we were not attaching the window properly as a child of desktop. This resulted in some inconsistencies in the client (extension side) tree. Fix it by always adding this window as a child of desktop

- output for the permissions bubble is strange at the moment because the entire subtree is strange:
- a window contains descendants dialog, alert dialog. The dialog itself contains duplicate text with the dialog's name. The alert dialog contains a name identical to the dialog, but contains the actual content and the allow, deny buttons.

This cl doesn't change the structure, but does allow the user to descend properly into the alert dialog with linear navigation. We do this by making an alert dialog a structural container (i.e. something we descend into when navigating next).

The bubble looks like:
node id=364 role=window state={} parentID=6 childIds=[359]
 node id=359 role=dialog state={} parentID=364 childIds=[363]
  node id=363 role=dialog state={"focused":true} parentID=359 childIds=[362]
   node id=362 role=client state={} parentID=363 childIds=[367,361]
    node id=367 role=client state={} parentID=362 childIds=[368,369,358]
     node id=368 role=image state={} parentID=367 childIds=[]
     node id=369 role=staticText state={"readOnly":true} parentID=367 childIds=[]
     node id=358 role=button state={} parentID=367 childIds=[370,371]
      node id=370 role=image state={} parentID=358 childIds=[]
      node id=371 role=staticText state={"readOnly":true} parentID=358 childIds=[]
    node id=361 role=client state={} parentID=362 childIds=[360,365,366]
     node id=360 role=alertDialog state={} parentID=361 childIds=[372]
      node id=372 role=unknown state={} parentID=360 childIds=[373,374]
       node id=373 role=unknown state={} parentID=372 childIds=[375,376]
        node id=375 role=image state={} parentID=373 childIds=[]
        node id=376 role=staticText state={"readOnly":true} parentID=373 childIds=[]
       node id=374 role=unknown state={} parentID=372 childIds=[]
     node id=365 role=button state={"focusable":true} parentID=361 childIds=[377,378]
      node id=377 role=image state={} parentID=365 childIds=[]
      node id=378 role=staticText state={"readOnly":true} parentID=365 childIds=[]
     node id=366 role=button state={"focusable":true} parentID=361 childIds=[379,380]
      node id=379 role=image state={} parentID=366 childIds=[]
      node id=380 role=staticText state={"readOnly":true} parentID=366 childIds=[]

TEST=visit site containing notification; ensure we get focused on that window and search+right visits all window elements.
Use ChromeVox for a while and cause an alert (e.g. press caps lock). Ensure we don't get any errors concerning invalid nodes on deserialization and that ChromeVox only alerts once.

BUG= 619266 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2514583002
Cr-Commit-Position: refs/heads/master@{#433321}

[modify] https://crrev.com/319f110637783ce562ad6092120441756572e644/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
[modify] https://crrev.com/319f110637783ce562ad6092120441756572e644/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/319f110637783ce562ad6092120441756572e644/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/319f110637783ce562ad6092120441756572e644/chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc

Comment 4 by dtseng@chromium.org, Nov 23 2016

NextAction: 2016-11-23
Status: fixed (was: Assigned)

Comment 5 by chaok@google.com, Dec 4 2016

Status: Verified (was: Fixed)

Sign in to add a comment