Modify ChooserBubbleUiController and ChooserDialogCocoaController to correctly handle removing item |
||
Issue descriptionOS: Mac What steps will reproduce the problem? If the chooser's item list is [a, b, c], and b is selected. Remove item a. What is the expected output? Item b still should be selected. What do you see instead? Item c is selected.
,
Jun 14 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5ca45e05f2000f644a0b092813d294bcdcc5cc4 commit d5ca45e05f2000f644a0b092813d294bcdcc5cc4 Author: juncai <juncai@chromium.org> Date: Mon Jun 13 18:48:37 2016 Modify chooser controller to correctly handle removing item on Mac This CL modified ChooserBubbleUiController and ChooserDialogCocoaController to correctly handle removing item. And it also added and updated test code to cover it. BUG= 619230 Review-Url: https://codereview.chromium.org/2054333002 Cr-Commit-Position: refs/heads/master@{#399494} [modify] https://crrev.com/d5ca45e05f2000f644a0b092813d294bcdcc5cc4/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm [modify] https://crrev.com/d5ca45e05f2000f644a0b092813d294bcdcc5cc4/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm [modify] https://crrev.com/d5ca45e05f2000f644a0b092813d294bcdcc5cc4/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2016