[Android][Remoting] Panning inertia is way too sensitive |
||||||||||
Issue descriptionThe Android remoting client uses a canvas to render the remote desktop image. This image can be zoomed and panned and reacts to interia (aka fling momentum) when the user releases their finger by sliding the canvas in the direction of the pan. In the ToT M53 build, the intertia applied to the residual canvas motion is way too high and feels very unnatural (the canvas appears to fly off your finger when you pull it off the screen). This is a regression from the last release so I think it may be due to some recent refactoring.
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53e826563f4c551bb640ec10eb21ed40b1687141 commit 53e826563f4c551bb640ec10eb21ed40b1687141 Author: zijiehe <zijiehe@chromium.org> Date: Mon Jun 13 19:04:25 2016 [Chromoting] Fling gestures on Android client are too fast This change is to fix a bug in DesktopView.paint, which cause fling gestures to be too fast. This issue has been introduced by commit 06d70696de0b8fac307927064bd36be2d486fe2a. And the root cause is that animation job should be called during each paint call. BUG= 619224 Review-Url: https://codereview.chromium.org/2060643002 Cr-Commit-Position: refs/heads/master@{#399500} [modify] https://crrev.com/53e826563f4c551bb640ec10eb21ed40b1687141/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
,
Jun 13 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53e826563f4c551bb640ec10eb21ed40b1687141 commit 53e826563f4c551bb640ec10eb21ed40b1687141 Author: zijiehe <zijiehe@chromium.org> Date: Mon Jun 13 19:04:25 2016 [Chromoting] Fling gestures on Android client are too fast This change is to fix a bug in DesktopView.paint, which cause fling gestures to be too fast. This issue has been introduced by commit 06d70696de0b8fac307927064bd36be2d486fe2a. And the root cause is that animation job should be called during each paint call. BUG= 619224 Review-Url: https://codereview.chromium.org/2060643002 Cr-Commit-Position: refs/heads/master@{#399500} [modify] https://crrev.com/53e826563f4c551bb640ec10eb21ed40b1687141/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
,
Jun 24 2016
Re-activating as this is still a problem. We need to get this fixed in M53, otherwise we will not be able to release this build.
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b96b52256a06adc81bb68aab2b95e1c886dcd1 commit a7b96b52256a06adc81bb68aab2b95e1c886dcd1 Author: zijiehe <zijiehe@chromium.org> Date: Fri Jun 24 21:58:58 2016 [Chromoting] Panning inertia is way too sensitive A very tiny issue makes the trouble, we should use transformed delta values to control the fling gesture. BUG= 619224 Review-Url: https://codereview.chromium.org/2088393005 Cr-Commit-Position: refs/heads/master@{#401988} [modify] https://crrev.com/a7b96b52256a06adc81bb68aab2b95e1c886dcd1/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
,
Jun 24 2016
Hi, Lambros, As Yuwei mentioned in the code review, changes between trunk version 2694 to 2779 (both included) are impacted by the issue introduced by commit 4d2f03e9c6122f222bd337bd109b1c5f23ecffd0.
,
Jun 24 2016
My apology for introducing this bug... Luckily it is fixed before pushing to public. Thanks for fixing this :)
,
Jun 27 2016
Reopening to merge to the M52 branch. The fix is in CRD android app, doesn't affect chrome.
,
Jun 27 2016
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
I'll do the merge.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/592eeb9fb820e53d9d871ad1411de89260544ae7 commit 592eeb9fb820e53d9d871ad1411de89260544ae7 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Mon Jun 27 20:24:18 2016 [Chromoting] Panning inertia is way too sensitive A very tiny issue makes the trouble, we should use transformed delta values to control the fling gesture. BUG= 619224 Review-Url: https://codereview.chromium.org/2088393005 Cr-Commit-Position: refs/heads/master@{#401988} (cherry picked from commit a7b96b52256a06adc81bb68aab2b95e1c886dcd1) Review URL: https://codereview.chromium.org/2105433003 . Cr-Commit-Position: refs/branch-heads/2743@{#486} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/592eeb9fb820e53d9d871ad1411de89260544ae7/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
,
Jun 27 2016
AJ, would you mind to verify this change?
,
Jul 7 2016
Verified in 53.0.2783.5. The behavior has changed, and I found no regressions on 3 Android devices (KitKat, Lollipop and Marshmallow)
,
Jul 7 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by zijiehe@chromium.org
, Jun 11 2016