page_cycler.typical_25, telemetry is broken in ChromeOS |
|||||||||||
Issue description
Some recent change in telemetry has broken tests in ChromeOS. The following is from a test that is run in the ChromeOS lumpy-pfq waterfall; it started failing as of (roughly) June 8. This is currently considered a warning in the waterfall but if it is not fixed by June 15 it will become a waterfall failure. This needs to be investigated and fixed asap.
Extract from waterfall test log:
06/10 03:00:59.831 DEBUG| telemetry_runner:0143| Telemetry Path: /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src
06/10 03:00:59.831 INFO |telemetry_AFDOGene:0189| Starting run for Telemetry benchmark page_cycler.typical_25
06/10 03:00:59.832 DEBUG| telemetry_runner:0380| Running telemetry benchmark: page_cycler.typical_25
06/10 03:00:59.832 DEBUG| telemetry_runner:0312| Running Telemetry: ssh 100.107.160.4 python /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src --remote=chromeos2-row3-rack9-host11 --pageset-repeat=1 page_cycler.typical_25
06/10 03:00:59.832 DEBUG| telemetry_runner:0273| Running: ssh 100.107.160.4 python /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src --remote=chromeos2-row3-rack9-host11 --pageset-repeat=1 page_cycler.typical_25
06/10 03:00:59.833 DEBUG| base_utils:0185| Running 'ssh 100.107.160.4 python /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/run_benchmark --verbose --browser=cros-chrome --output-format=chartjson --output-dir=/home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src --remote=chromeos2-row3-rack9-host11 --pageset-repeat=1 page_cycler.typical_25'
06/10 03:01:05.862 DEBUG| telemetry_runner:0284| Error occurred executing.
06/10 03:01:05.862 DEBUG| telemetry_runner:0290| Completed with exit code: 1.
stdout:
stderr:Warning: Permanently added '100.107.160.4' (ECDSA) to the list of known hosts.
(INFO) 2016-06-10 02:59:09,296 browser_finder.FindBrowser:123 Chose browser: PossibleCrOSBrowser(browser_type=cros-chrome)
(INFO) 2016-06-10 02:59:09,296 exception_formatter.PrintFormattedException:19 Try printing formatted exception: <type 'exceptions.NotImplementedError'> <traceback object at 0x7f33c7df4488>
Traceback (most recent call last):
<module> at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/run_benchmark:22
sys.exit(main())
main at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/run_benchmark:19
return benchmark_runner.main(config, [trybot_command.Trybot])
main at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:432
return command_instance.Run(options)
Run at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:231
return min(255, self._benchmark().Run(args))
Run at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/benchmark.py:91
return story_runner.RunBenchmark(self, finder_options)
RunBenchmark at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:279
if possible_browser and benchmark.ShouldDisable(possible_browser):
ShouldDisable at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/tools/perf/benchmarks/page_cycler.py:165
if possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead':
GetDeviceTypeName at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/core/platform.py:125
return self._platform_backend.GetDeviceTypeName()
GetDeviceTypeName at /home/chromeos-test/images/lumpy-chrome-pfq/R53-8435.0.0-rc2/telemetry_src/src/third_party/catapult/telemetry/telemetry/internal/platform/platform_backend.py:166
raise NotImplementedError()
NotImplementedError
Locals:
No locals!
It appears the GetDeviceTypeName is not implemented for ChromeOS devices?
,
Jun 10 2016
,
Jun 10 2016
,
Jun 11 2016
Assigned to shadow gardener for next week (jdufault@), main gardener (ihf@) to cc. The waterfall appears to be down at the moment.
,
Jun 11 2016
Assigning this to aiolas who made the original change here: https://github.com/catapult-project/catapult/commit/cf58793d2956faeaeeb2628ddc2f010c2ba8934e This needs to be updated to work for Chrome OS as well. Kari, would you be able to make that change since you are familiar with this code? I'm assuming we just need to update somewhere in the inheritance tree such that this code reaches: https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/internal/platform/cros_platform_backend.py. I don't quite know what the function is used for, but a suitable string like "Chrome OS" is likely fine as that's what is used on desktop ("Desktop")
,
Jun 13 2016
,
Jun 13 2016
Ping? This will become a p0 in two days if it doesn't get fixed (it will start causing the ChromeOS internal waterfall to fail)...
,
Jun 13 2016
I'm going to be ooo in 2 days, and won't have time to really fix it before then. I'll add a workaround shortly to avoid breaking the waterfall, but someone who knows ChromeOS should do the following: Replace the logic in GetDeviceTypeName in the cros_platform_backend.py to return an actual device type.
,
Jun 13 2016
Workaround here: https://codereview.chromium.org/2065763002
,
Jun 13 2016
Thanks Kari! Assigning to Ben for further triage. We should try to return something more sensible. If we can return our internal name for the board that would be great. Please let me know if there are any questions.
,
Jun 13 2016
,
Jun 14 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfa760d4b4c20724cdd3d015889524f621f5d056 commit bfa760d4b4c20724cdd3d015889524f621f5d056 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Tue Jun 14 06:34:31 2016 Roll src/third_party/catapult/ a5b12d3ee..5fbbf6a7e (4 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5b12d3eed34..5fbbf6a7e7c1 $ git log a5b12d3ee..5fbbf6a7e --date=short --no-merges --format='%ad %ae %s' BUG= 619218 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2061653003 Cr-Commit-Position: refs/heads/master@{#399656} [modify] https://crrev.com/bfa760d4b4c20724cdd3d015889524f621f5d056/DEPS
,
Jun 14 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfa760d4b4c20724cdd3d015889524f621f5d056 commit bfa760d4b4c20724cdd3d015889524f621f5d056 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Tue Jun 14 06:34:31 2016 Roll src/third_party/catapult/ a5b12d3ee..5fbbf6a7e (4 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5b12d3eed34..5fbbf6a7e7c1 $ git log a5b12d3ee..5fbbf6a7e --date=short --no-merges --format='%ad %ae %s' BUG= 619218 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2061653003 Cr-Commit-Position: refs/heads/master@{#399656} [modify] https://crrev.com/bfa760d4b4c20724cdd3d015889524f621f5d056/DEPS
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1684132fc5b8a64a28060573ca98ba6899a13df2 commit 1684132fc5b8a64a28060573ca98ba6899a13df2 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jun 15 05:12:33 2016 Roll src/third_party/catapult/ 298440299..e319924ad (5 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/298440299790..e319924ad45b $ git log 298440299..e319924ad --date=short --no-merges --format='%ad %ae %s' BUG= 619218 , 619068 , 619448 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2065873004 Cr-Commit-Position: refs/heads/master@{#399847} [modify] https://crrev.com/1684132fc5b8a64a28060573ca98ba6899a13df2/DEPS
,
Jun 21 2016
Issue 621949 has been merged into this issue.
,
Jul 1 2016
Bulk verified
,
Jul 31 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by haddowk@chromium.org
, Jun 10 2016