New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619215 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Change enums in components/offline_pages/ to MACRO_STYLE

Project Member Reported by weiran@google.com, Jun 10 2016

Issue description

The enums in the following files did not follow the coding style:

snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

rewrite in MACRO_STYLE naming

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 11 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92c8b28dafc2d4748d5f7d4755320271e5319e1e

commit 92c8b28dafc2d4748d5f7d4755320271e5319e1e
Author: weiran <weiran@google.com>
Date: Mon Jun 13 20:33:49 2016

Rewrite enum in MACRO_STYLE

Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

Related files are edited to match the style.

BUG= 619215 

Review-Url: https://codereview.chromium.org/2063533002
Cr-Commit-Position: refs/heads/master@{#399526}

[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_in_memory_store_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/snapshot_controller.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/snapshot_controller.h

Comment 3 by weiran@google.com, Jun 13 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92c8b28dafc2d4748d5f7d4755320271e5319e1e

commit 92c8b28dafc2d4748d5f7d4755320271e5319e1e
Author: weiran <weiran@google.com>
Date: Mon Jun 13 20:33:49 2016

Rewrite enum in MACRO_STYLE

Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

Related files are edited to match the style.

BUG= 619215 

Review-Url: https://codereview.chromium.org/2063533002
Cr-Commit-Position: refs/heads/master@{#399526}

[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_in_memory_store_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request.h
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/background/save_page_request_unittest.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/snapshot_controller.cc
[modify] https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e/components/offline_pages/snapshot_controller.h

Sign in to add a comment