New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619205 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Chrome PFQ uprev status in metadata.json

Project Member Reported by leecy@chromium.org, Jun 10 2016

Issue description

We want to display whether or not a PFQ run actually uprevved Chrome, and don't have any data in metadata.json to actually know whether this happened.  Would like the metadata.json to contain some definitive information about whether the uprev occurred in this run.  It's fine (and preferred) if this only appears on the master metadata.json files.
 

Comment 1 by autumn@chromium.org, Jun 13 2016

Labels: -current-issue

Comment 2 by nxia@chromium.org, Jun 13 2016

Cc: dgarr...@chromium.org
I'd suggest grabbing two copies of metadata.json. One from a successful uprev, and one from a successful build in which no uprev was needed. I'm curious what is different between the two today.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9abc703209fd22d681b6ad502cd8607cd4e8ab79

commit 9abc703209fd22d681b6ad502cd8607cd4e8ab79
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Jun 16 18:32:38 2016

Add UprevvedChrome flag in metadata.json for Chrome PFQ.

Display whether a PFQ run actually uprevved Chrome in metadata results.
If Chrome uprev happens, 'UprevvedChrome: True' will be added to master
chrome builder metadata; otherwise, no 'UprevvedChrome' flag will be
added to any metadata.

BUG= chromium:619205 
TEST=unit_test;cbuildbot

Change-Id: I964f5751e3d25cdb824661631444b0b13db37dc0
Reviewed-on: https://chromium-review.googlesource.com/353166
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/9abc703209fd22d681b6ad502cd8607cd4e8ab79/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/9abc703209fd22d681b6ad502cd8607cd4e8ab79/cbuildbot/stages/completion_stages.py

Comment 5 by nxia@chromium.org, Jun 22 2016

Status: Fixed (was: Untriaged)
If Chrome uprev happens, 'UprevvedChrome: True' will be added to master
chrome builder metadata.
Closing... please feel free to reopen if its not fixed.
Status: Verified (was: Fixed)

Sign in to add a comment