New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619192 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ groby@chromium.org
ftang@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 608500



Sign in to add a comment

Translate bubble doesn't close when clicking outside of it

Project Member Reported by zkoch@chromium.org, Jun 10 2016 
Right now, you're forced to click one of the actions in the bubble to close it. But the bubble should close when you click outside, as is standard for other bubbles (e.g. password save).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/153dc6af7e1ac70671eefd48faed85c85cb151f0

commit 153dc6af7e1ac70671eefd48faed85c85cb151f0
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Jun 13 21:22:10 2016

Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG= 619192 

Review-Url: https://codereview.chromium.org/2061523002
Cr-Commit-Position: refs/heads/master@{#399543}

[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/translate/translate_bubble_view.h

Comment 2 by hcarmona@chromium.org, Jun 13 2016

Status: Fixed (was: Assigned)
This should be fixed in the next build.

Comment 3 by zkoch@chromium.org, Jun 13 2016 

Thanks!

Comment 4 by zkoch@chromium.org, Jun 14 2016

Cc: ftang@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/153dc6af7e1ac70671eefd48faed85c85cb151f0

commit 153dc6af7e1ac70671eefd48faed85c85cb151f0
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Jun 13 21:22:10 2016

Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG= 619192 

Review-Url: https://codereview.chromium.org/2061523002
Cr-Commit-Position: refs/heads/master@{#399543}

[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/153dc6af7e1ac70671eefd48faed85c85cb151f0/chrome/browser/ui/views/translate/translate_bubble_view.h

Comment 6 by zkoch@chromium.org, Jun 16 2016

Labels: Merge-Request-52

Comment 7 by tin...@google.com, Jun 16 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 16 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/121eb7c1d28d7cec596748fe86917abbf6e18d18

commit 121eb7c1d28d7cec596748fe86917abbf6e18d18
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Jun 16 20:48:49 2016

Enable the translate bubble to be dismissed when user ignores it.

Refactored the dismiss mechanism from passwords to the location bar
bubble delegate, which is a common location.

Not all bubbles will need this because it's only necessary on bubbles
that do not start focused. Like the passwords and translate bubbles.

BUG= 619192 

Review-Url: https://codereview.chromium.org/2061523002
Cr-Commit-Position: refs/heads/master@{#399543}
(cherry picked from commit 153dc6af7e1ac70671eefd48faed85c85cb151f0)

Review URL: https://codereview.chromium.org/2074913002 .

Cr-Commit-Position: refs/branch-heads/2743@{#371}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/121eb7c1d28d7cec596748fe86917abbf6e18d18/chrome/browser/ui/views/translate/translate_bubble_view.h

Comment 9 by nyerramilli@chromium.org, Jun 22 2016

Cc: nyerramilli@chromium.org
Labels: TE-Verified-M52 TE-Verified-52.0.2743.49
Tested this on Win7, Ubuntu 14.04 using Beta 52.0.2743.49 and it is working as intended.

Attached screencast for reference and adding TE-Verified labels.
619192.mp4
3.4 MB View Download
►

Sign in to add a comment