Issue 619185 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	enne@chromium.org
Closed:	Jun 2016
Cc:	danakj@chromium.org ericrk@chromium.org enne@chromium.org senorblanco@chromium.org
Components:	Internals>Compositing
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	0
Type:	Bug-Regression

Context menu is rendering as black box

Project Member Reported by kozyatinskiy@chromium.org, Jun 10 2016

Issue description

Version: ToT (refs/heads/master@{#399264})
OS: Linux

What steps will reproduce the problem?
(1) Open chrome
(2) Click left mouse button in NTP to open context menu

What is the expected output?
Context menu

What do you see instead?
Black box instead.

	Screenshot from 2016-06-10 15:00:10.png 82.2 KB View Download

	Screenshot from 2016-06-10 15:13:47.png 105 KB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bf22b3aae1b9b00b60874505c4ec22279236c8f

commit 8bf22b3aae1b9b00b60874505c4ec22279236c8f
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:43:06 2016

Revert of Disable blink layout tests related to crbug/254639 + (patchset #1 id:1 of https://codereview.chromium.org/2059723002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Disable blink layout tests related to crbug/254639 +
>  crbug.com/254639  css3/filters/effect-brightness-hw.html [ Failure Pass ]
>  crbug.com/254639  css3/filters/effect-hue-rotate-hw.html [ Failure Pass ]
>
> TBR=enne@chromium.org
> BUG= 254639 
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2af0f64999cc750dadcc0ba17b7cb7e8fe9a9563

TBR=enne@chromium.org,perkj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 

Review-Url: https://codereview.chromium.org/2054293002
Cr-Commit-Position: refs/heads/master@{#399303}

[modify] https://crrev.com/8bf22b3aae1b9b00b60874505c4ec22279236c8f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8

commit 5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:47:34 2016

Revert of Auto-rebaseline for r399060 (patchset #1 id:1 of https://codereview.chromium.org/2056993002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Auto-rebaseline for r399060
>
> https://chromium.googlesource.com/chromium/src/+/ff3dc65b0
>
> BUG= 254639 
> TBR=enne@chromium.org
>
> Committed: https://crrev.com/68faa261f0095f54cc38e9fc5cfb540f06e1fee4
> Cr-Commit-Position: refs/heads/master@{#399076}

TBR=enne@chromium.org,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 

Review-Url: https://codereview.chromium.org/2063433003
Cr-Commit-Position: refs/heads/master@{#399305}

[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-hw-expected.txt
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/android/compositing/masks/direct-image-mask-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/linux-precise/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/masks/direct-image-mask-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed2-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-contrast-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-grayscale-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-hue-rotate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/masks/direct-image-mask-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed2-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-clamping-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-contrast-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-grayscale-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-hue-rotate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-saturate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/win7/css3/filters/effect-brightness-hw-expected.png

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a0c4522dbb71c522c09798e7dbc77a7285d1ea

commit 95a0c4522dbb71c522c09798e7dbc77a7285d1ea
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:52:37 2016

Revert of Optimize render passes with single quads (patchset #13 id:240001 of https://codereview.chromium.org/1960543002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Optimize render passes with single quads
>
> Many effects (masks, replicas, filters) generate render passes for
> simplicity in the code.  However, in the cases where the pass contains a
> single quad with a texture, that resulting texture could just be used as
> the input texture instead of the render pass itself.
>
> The complication is mostly that render passes and tile textures are
> flipped relative to each other (oops) and so some knowledge of this has
> to leak into drawing render passes.
>
> This is done by detecting such render passes inside of DirectRenderer,
> storing the TileQuad that would have been drawn, skipping allocating the
> pass and rendering it, and then calling a slightly modified version of
> DrawRenderPassQuad with the TileQuad's resource.  The check for which
> render passes can be supported is conservative to start.
>
> This optimization usually will not be supported on mac because skia
> does not support textures with texture rectangle targets as input.
>
> BUG= 254639 , 606672 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232
> Cr-Commit-Position: refs/heads/master@{#399060}

TBR=ericrk@chromium.org,senorblanco@chromium.org,enne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 , 606672 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2058013003
Cr-Commit-Position: refs/heads/master@{#399308}

[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/direct_renderer.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/direct_renderer.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/gl_renderer.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/gl_renderer.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/data/rotated_drop_shadow_filter_gl.png
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/data/rotated_drop_shadow_filter_sw.png
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/solid_color_content_layer_client.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/trees/layer_tree_host_pixeltest_filters.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-hw-expected.html

Comment 4 by kozyatinskiy@chromium.org, Jun 10 2016

Status: Fixed (was: Assigned)

Reverted and in current ToT context menu works correctly.

Comment 5 by danakj@chromium.org, Jun 10 2016

Thanks :)

Comment 6 by enne@chromium.org, Jun 13 2016

Cc: enne@chromium.org

 Issue 619123  has been merged into this issue.

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bf22b3aae1b9b00b60874505c4ec22279236c8f

commit 8bf22b3aae1b9b00b60874505c4ec22279236c8f
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:43:06 2016

Revert of Disable blink layout tests related to crbug/254639 + (patchset #1 id:1 of https://codereview.chromium.org/2059723002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Disable blink layout tests related to crbug/254639 +
>  crbug.com/254639  css3/filters/effect-brightness-hw.html [ Failure Pass ]
>  crbug.com/254639  css3/filters/effect-hue-rotate-hw.html [ Failure Pass ]
>
> TBR=enne@chromium.org
> BUG= 254639 
>
> Committed: https://chromium.googlesource.com/chromium/src/+/2af0f64999cc750dadcc0ba17b7cb7e8fe9a9563

TBR=enne@chromium.org,perkj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 

Review-Url: https://codereview.chromium.org/2054293002
Cr-Commit-Position: refs/heads/master@{#399303}

[modify] https://crrev.com/8bf22b3aae1b9b00b60874505c4ec22279236c8f/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8

commit 5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:47:34 2016

Revert of Auto-rebaseline for r399060 (patchset #1 id:1 of https://codereview.chromium.org/2056993002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Auto-rebaseline for r399060
>
> https://chromium.googlesource.com/chromium/src/+/ff3dc65b0
>
> BUG= 254639 
> TBR=enne@chromium.org
>
> Committed: https://crrev.com/68faa261f0095f54cc38e9fc5cfb540f06e1fee4
> Cr-Commit-Position: refs/heads/master@{#399076}

TBR=enne@chromium.org,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 

Review-Url: https://codereview.chromium.org/2063433003
Cr-Commit-Position: refs/heads/master@{#399305}

[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-hw-expected.txt
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/android/compositing/masks/direct-image-mask-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/linux-precise/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/masks/direct-image-mask-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed2-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-clamping-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-contrast-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-grayscale-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-hue-rotate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-saturate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/masks/direct-image-mask-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed2-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-all-on-background-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-clamping-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-contrast-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-grayscale-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-hue-rotate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-saturate-hw-expected.png
[modify] https://crrev.com/5b0187835b7ee1eb6bd7ba72e98ea7d030ae20a8/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-sepia-hw-expected.png
[delete] https://crrev.com/4387613998060e4d1691434d0be687bf012596ce/third_party/WebKit/LayoutTests/platform/win7/css3/filters/effect-brightness-hw-expected.png

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a0c4522dbb71c522c09798e7dbc77a7285d1ea

commit 95a0c4522dbb71c522c09798e7dbc77a7285d1ea
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jun 10 22:52:37 2016

Revert of Optimize render passes with single quads (patchset #13 id:240001 of https://codereview.chromium.org/1960543002/ )

Reason for revert:
Context menu is broken on Linux:
https://drive.google.com/file/d/0B7RLEApsOKBLNGZDai1JT0kwR2M/view?usp=sharing

BUG= 619185 

Original issue's description:
> Optimize render passes with single quads
>
> Many effects (masks, replicas, filters) generate render passes for
> simplicity in the code.  However, in the cases where the pass contains a
> single quad with a texture, that resulting texture could just be used as
> the input texture instead of the render pass itself.
>
> The complication is mostly that render passes and tile textures are
> flipped relative to each other (oops) and so some knowledge of this has
> to leak into drawing render passes.
>
> This is done by detecting such render passes inside of DirectRenderer,
> storing the TileQuad that would have been drawn, skipping allocating the
> pass and rendering it, and then calling a slightly modified version of
> DrawRenderPassQuad with the TileQuad's resource.  The check for which
> render passes can be supported is conservative to start.
>
> This optimization usually will not be supported on mac because skia
> does not support textures with texture rectangle targets as input.
>
> BUG= 254639 , 606672 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232
> Cr-Commit-Position: refs/heads/master@{#399060}

TBR=ericrk@chromium.org,senorblanco@chromium.org,enne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 254639 , 606672 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2058013003
Cr-Commit-Position: refs/heads/master@{#399308}

[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/direct_renderer.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/direct_renderer.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/gl_renderer.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/output/gl_renderer.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/data/rotated_drop_shadow_filter_gl.png
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/data/rotated_drop_shadow_filter_sw.png
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/solid_color_content_layer_client.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/test/solid_color_content_layer_client.h
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/trees/layer_tree_host_pixeltest_filters.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/cc/trees/layer_tree_host_pixeltest_masks.cc
[modify] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/95a0c4522dbb71c522c09798e7dbc77a7285d1ea/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-hw-expected.html

►

Issue 619185 link

Issue metadata

Context menu is rendering as black box

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 10 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 10 2016

Comment 3 Deleted

Comment 4 by kozyatinskiy@chromium.org, Jun 10 2016

Comment 4 Deleted

Comment 5 by danakj@chromium.org, Jun 10 2016

Comment 5 Deleted

Comment 6 by enne@chromium.org, Jun 13 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

Comment 9 Deleted

Sign in to add a comment