New issue
Advanced search Search tips

Issue 619181 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add unit test for ash TrayUpdate system update tray item

Project Member Reported by jamescook@chromium.org, Jun 10 2016

Issue description

Auto-updates are important. We should test the UI.

 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1257f146f22e25c109b67e66d0790c79b927940

commit a1257f146f22e25c109b67e66d0790c79b927940
Author: jamescook <jamescook@chromium.org>
Date: Sun Jun 12 07:02:25 2016

ash: Add a unit test for the system update tray item

I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.

This also changes the default "update required" state in ash unit tests to not
having an update.

BUG= 619181 
TEST=ash_unittests TrayUpdateTest

Review-Url: https://codereview.chromium.org/2060003002
Cr-Commit-Position: refs/heads/master@{#399388}

[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/ash.gyp
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/system_tray.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/system_tray.h
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray_update.h
[add] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray_update_unittest.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/ash_test_helper.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/test_system_tray_delegate.h

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1257f146f22e25c109b67e66d0790c79b927940

commit a1257f146f22e25c109b67e66d0790c79b927940
Author: jamescook <jamescook@chromium.org>
Date: Sun Jun 12 07:02:25 2016

ash: Add a unit test for the system update tray item

I'm about to refactor SystemTrayNotifier and TrayUpdate, and I want more
confidence that I'm not breaking it.

This also changes the default "update required" state in ash unit tests to not
having an update.

BUG= 619181 
TEST=ash_unittests TrayUpdateTest

Review-Url: https://codereview.chromium.org/2060003002
Cr-Commit-Position: refs/heads/master@{#399388}

[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/ash.gyp
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/system_tray.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/system_tray.h
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray/tray_image_item.h
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray_update.h
[add] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/system/tray_update_unittest.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/ash_test_helper.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/a1257f146f22e25c109b67e66d0790c79b927940/ash/test/test_system_tray_delegate.h

Labels: VerifyIn-53
Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment