Courgette: Program Detection is Inefficient |
|||
Issue descriptionFor (ensemble) Courgette-gen, DetectDisassembler() scans through bytes of input files (e.g., chrome.7z) to find executables to parse. The Current code allocates new instances of Disassembler inherited classes (x 4) for every new byte encountered. This is wasteful; indeed FindEmbeddedElements() takes ~40 seconds to run for lastest chrome.7z! We can optimize this by having static functions to do "quick-and-dirty" for various executable types.
,
Jun 14 2016
,
Jul 22 2016
Setting to fixed; etiennep@ committed this in: https://chromiumcodereview.appspot.com/2055343002/ |
|||
►
Sign in to add a comment |
|||
Comment 1 by hua...@chromium.org
, Jun 10 2016