New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Courgette: Program Detection is Inefficient

Project Member Reported by hua...@chromium.org, Jun 10 2016

Issue description

For (ensemble) Courgette-gen,  DetectDisassembler() scans through bytes of input files (e.g., chrome.7z) to find executables to parse. The Current code allocates new instances of Disassembler inherited classes (x 4) for every new byte encountered.  This is wasteful; indeed FindEmbeddedElements() takes ~40 seconds to run for lastest chrome.7z!

We can optimize this by having static functions to do "quick-and-dirty" for various executable types.

 

Comment 1 by hua...@chromium.org, Jun 10 2016

Status: Started
... to do "quick-and-dirty" checks

Comment 2 by hua...@chromium.org, Jun 14 2016

Owner: etiennep@google.com

Comment 3 by hua...@chromium.org, Jul 22 2016

Cc: hua...@chromium.org
Status: Fixed (was: Started)
Setting to fixed; etiennep@ committed this in:
https://chromiumcodereview.appspot.com/2055343002/

Sign in to add a comment