Layout tests crashing in renderer time out on Mac |
|||
Issue descriptionhttps://codereview.chromium.org/2049263003/ will cause some tests crash because of bug 619103. However, these tests timed out instead of crashed on Mac. Also reproduced locally. The test does crashes: [...:FATAL:PaintController.cpp(506)] Check failed: false ... stack trace ... but content_shell doesn't exit.
,
Jul 28 2016
Will upload patch soon.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcb53cbb96304db38bb0a2774c26657f518e851e commit bcb53cbb96304db38bb0a2774c26657f518e851e Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Jul 28 20:40:52 2016 Correctly detect renderer crash because of CHECK failures on Mac Previously CHECK failures on Mac (SIGTRAP) were treated as TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout instead of printing #CRASH. We had to put TIMEOUT expectation in LayoutTests/TestExpectations for Mac for layout tests that crash because of CHECK failures. Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP. BTW also for SIGSYS. BUG= 619153 Review-Url: https://codereview.chromium.org/2188293002 Cr-Commit-Position: refs/heads/master@{#408469} [modify] https://crrev.com/bcb53cbb96304db38bb0a2774c26657f518e851e/base/process/kill_posix.cc
,
Jul 28 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wangxianzhu@chromium.org
, Jun 10 2016