New issue
Advanced search Search tips

Issue 619148 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

"WebViewTests/WebViewTest.CloseOnLoadcommit/1" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 10 2016

Issue description

"WebViewTests/WebViewTest.CloseOnLoadcommit/1" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixXZWJWaWV3VGVzdHMvV2ViVmlld1Rlc3QuQ2xvc2VPbkxvYWRjb21taXQvMQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by piman@chromium.org, Jun 10 2016

Cc: paulmeyer@chromium.org creis@chromium.org lfg@chromium.org
Labels: OS-Linux
Owner: wjmaclean@chromium.org
WebViewTests/WebViewTest.CloseOnLoadcommit/1 (run #1):
[ RUN      ] WebViewTests/WebViewTest.CloseOnLoadcommit/1
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[17937:17937:0610/104533:WARNING:audio_manager.cc(297)] Multiple instances of AudioManager detected
[17937:17937:0610/104533:WARNING:audio_manager.cc(271)] Multiple instances of AudioManager detected
[17937:17937:0610/104533:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
LaunchProcess: failed to execvp:
xdg-desktop-menu
LaunchProcess: failed to execvp:
xdg-icon-resource
[17937:18050:0610/104533:WARNING:shell_integration_linux.cc(304)] Could not install icon chrome-ncboifeglmmdfoklnfgngkjinhkiclnh-Default.png at size 512.
LaunchProcess: failed to execvp:
xdg-desktop-menu
[17937:17937:0610/104533:FATAL:web_contents_observer_sanity_checker.cc(366)] Check failed: render_frame_created_happened. A RenderFrameHost pointer was passed to a WebContentsObserver method, but WebContentsObserver::RenderFrameCreated was never called for that RenderFrameHost: (4, 10 -> chrome-extension://ncboifeglmmdfoklnfgngkjinhkiclnh/)
#0 0x0000064550fe base::debug::StackTrace::StackTrace()
#1 0x00000646e45b logging::LogMessage::~LogMessage()
#2 0x000006375a08 content::WebContentsObserverSanityChecker::AssertRenderFrameExists()
#3 0x000006375e6c content::WebContentsObserverSanityChecker::RenderFrameHostChanged()
#4 0x0000031861a7 content::WebContentsImpl::NotifyFrameSwapped()
#5 0x000002ee4bd9 content::RenderFrameHostManager::Init()
#6 0x000002ebe1be content::FrameTreeNode::AddChild()
#7 0x000002ebc93c content::FrameTree::AddFrame()
#8 0x000002edf3c6 content::RenderFrameHostImpl::OnCreateChildFrame()
#9 0x000002eef4f3 content::(anonymous namespace)::CreateChildFrameOnUI()
#10 0x000002eefe58 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2ELm3ELm4ELm5ELm6ELm7EEEENS0_9BindStateINS0_15RunnableAdapterIPFviiN5blink16WebTreeScopeTypeERKSsS9_NS6_15WebSandboxFlagsERKNS6_23WebFrameOwnerPropertiesEiEEESE_JRKiSI_RKS7_S9_S9_RKSA_SD_RiEEELb0EFvvEE3RunEPNS0_13BindStateBaseE
#11 0x000006455e69 base::debug::TaskAnnotator::RunTask()
#12 0x000006475f08 base::MessageLoop::RunTask()
#13 0x000006476228 base::MessageLoop::DeferOrRunPendingTask()
#14 0x00000647654b base::MessageLoop::DoWork()
#15 0x0000064781f9 base::MessagePumpGlib::Run()
#16 0x000006475b37 base::MessageLoop::RunHandler()
#17 0x00000649b8a0 base::RunLoop::Run()
#18 0x00000637326c content::RunThisRunLoop()
#19 0x00000637320a content::RunMessageLoop()
#20 0x000001283d91 InProcessBrowserTest::QuitBrowsers()
#21 0x000001283b0d InProcessBrowserTest::RunTestOnMainThreadLoop()
#22 0x0000017b612b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#23 0x0000012deec0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#24 0x0000012dde4e ChromeBrowserMainParts::PreMainMessageLoopRun()
#25 0x000002dfe7a5 content::BrowserMainLoop::PreMainMessageLoopRun()
#26 0x00000314a797 content::StartupTaskRunner::RunAllTasksNow()
#27 0x000002dfcf94 content::BrowserMainLoop::CreateStartupTasks()
#28 0x000002e01882 content::BrowserMainRunnerImpl::Initialize()
#29 0x000002dfa376 content::BrowserMain()
#30 0x00000634849b content::RunNamedProcessTypeMain()
#31 0x000006348f13 content::ContentMainRunnerImpl::Run()
#32 0x0000063477e0 content::ContentMain()
#33 0x0000017b5ab0 content::BrowserTestBase::SetUp()
#34 0x000001281fc9 InProcessBrowserTest::SetUp()
#35 0x0000065bc328 testing::Test::Run()
#36 0x0000065bd0ba testing::TestInfo::Run()
#37 0x0000065bd543 testing::TestCase::Run()
#38 0x0000065c4739 testing::internal::UnitTestImpl::RunAllTests()
#39 0x0000065c43de testing::UnitTest::Run()
#40 0x0000012940f6 base::TestSuite::Run()
#41 0x00000127bce9 ChromeTestSuiteRunner::RunTestSuite()
#42 0x00000636ff72 content::LaunchTests()
#43 0x0000005bfdf1 main
#44 0x7f204ad377ed __libc_start_main
#45 0x0000005bfcb1 <unknown>


This appears to be that a leftover task/callback happens as we're trying to tear down the test. RenderFrameHostImpl seems to be taken in a bad state.

->wjmaclean because this is possibly related to  crbug.com/291278 

Comment 2 by creis@chromium.org, Jun 10 2016

Cc: lazyboy@chromium.org
This also failed in https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/9490.

Seems concerning, given that this is an old test.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84e30a5c26bac544ec4e7b05a049f944d5c5a93

commit c84e30a5c26bac544ec4e7b05a049f944d5c5a93
Author: piman <piman@chromium.org>
Date: Fri Jun 10 21:52:38 2016

Disable flaky test on linux

BUG= 619148 
TBR=wjmaclean

Review-Url: https://codereview.chromium.org/2061483002
Cr-Commit-Position: refs/heads/master@{#399284}

[modify] https://crrev.com/c84e30a5c26bac544ec4e7b05a049f944d5c5a93/chrome/browser/apps/guest_view/web_view_browsertest.cc

Comment 4 by piman@chromium.org, Jun 10 2016

It has been failing very consistently (not flakily) on "Linux Tests (dbg)". First failure: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/29708

(it may still be a flake, so worth looking at previous changes too).

Comment 5 by piman@chromium.org, Jun 10 2016

Looked through, not clear suspect. There is https://chromium.googlesource.com/chromium/src/+/730669d119402a19dca92b5c0cc50bb6ff89172f from lazyboy@, landed on previous run, I assume it impacts this test?
Cc: -lazyboy@chromium.org -creis@chromium.org wjmaclean@chromium.org
Owner: lazyboy@chromium.org
Status: Started (was: Untriaged)
I'm going to run this locally and see what's happening as I don't have a hint on how my change can affect this.

The failure is interesting:
[26058:26058:0610/131651:FATAL:web_contents_observer_sanity_checker.cc(366)] Check failed: render_frame_created_happened. A RenderFrameHost pointer was passed to a WebContentsObserver method, but WebContentsObserver::RenderFrameCreated was never called for that RenderFrameHost: (4, 10 -> chrome-extension://inogddgdlhjjadlfahookkjbibcpjoai/)

Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84e30a5c26bac544ec4e7b05a049f944d5c5a93

commit c84e30a5c26bac544ec4e7b05a049f944d5c5a93
Author: piman <piman@chromium.org>
Date: Fri Jun 10 21:52:38 2016

Disable flaky test on linux

BUG= 619148 
TBR=wjmaclean

Review-Url: https://codereview.chromium.org/2061483002
Cr-Commit-Position: refs/heads/master@{#399284}

[modify] https://crrev.com/c84e30a5c26bac544ec4e7b05a049f944d5c5a93/chrome/browser/apps/guest_view/web_view_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment