Pulling this off of crbug.com/619103. If you load this in the browser there's clearly an underinvalidation issue. This test is incorrectly passing on the bots.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c46c2c4123213eb9a684a1df9ec22cccea39d52 commit 6c46c2c4123213eb9a684a1df9ec22cccea39d52 Author: pdr <pdr@chromium.org> Date: Sun Jun 12 00:05:49 2016 Disable incremental invalidation for SVG Incremental invalidation is a feature where size changes (e.g., shrinking an object's height) can only invalidate the shrunken region instead of the entire object. This can lead to underinvalidation bugs if the object is not fully opaque, such as the case of rounded corners. This patch switches all incremental invalidations to be full invalidations. BUG= 619108 Review-Url: https://codereview.chromium.org/2062533002 Cr-Commit-Position: refs/heads/master@{#399384} [modify] https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp [modify] https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f25deba1194fc7e67401fcbe6d62453f472f3fe4 commit f25deba1194fc7e67401fcbe6d62453f472f3fe4 Author: pdr <pdr@chromium.org> Date: Tue Jun 14 00:42:58 2016 Manually rebaseline 10 tests after 399384 This patch manually rebaselines 10 tests after: https://crrev.com/6c46c2c4123213eb9a684a1df9ec22cccea39d52 This patch also reverts suppressions added in: https://crrev.com/89ac1777f53c26ac798acccef38cb5506cf901a1 Rebaseline bot bug discussion: https://bugs.chromium.org/p/chromium/issues/detail?id=574272#c12 svg/custom/js-late-clipPath-and-object-creation.svg svg/custom/js-late-clipPath-creation.svg svg/custom/marker-viewBox-changes.svg svg/custom/relative-sized-content.xhtml svg/custom/relative-sized-deep-shadow-tree-content.xhtml svg/custom/relative-sized-image.xhtml svg/custom/relative-sized-shadow-tree-content.xhtml svg/custom/resource-invalidate-on-target-update.svg svg/filters/feImage-target-attribute-change-with-use-indirection.svg svg/repaint/inner-svg-change-viewBox-contract.svg svg/repaint/mask-clip-target-transform.svg BUG= 619108 TBR=wkorman@chromium.org Review-Url: https://codereview.chromium.org/2068553002 Cr-Commit-Position: refs/heads/master@{#399623} [modify] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/android/svg/repaint/inner-svg-change-viewBox-contract-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/android/svg/repaint/mask-clip-target-transform-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/inner-svg-change-viewBox-contract-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/inner-svg-change-viewBox-contract-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/mask-clip-target-transform-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/linux-precise/svg/repaint/mask-clip-target-transform-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-and-object-creation-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-and-object-creation-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-creation-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/js-late-clipPath-creation-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/marker-viewBox-changes-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/marker-viewBox-changes-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-content-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-content-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-deep-shadow-tree-content-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-image-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-image-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-shadow-tree-content-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/relative-sized-shadow-tree-content-expected.txt [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/resource-invalidate-on-target-update-expected.png [rename] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/resource-invalidate-on-target-update-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-and-object-creation-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-and-object-creation-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-creation-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/js-late-clipPath-creation-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/marker-viewBox-changes-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/marker-viewBox-changes-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-content-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-content-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-deep-shadow-tree-content-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-image-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-image-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-shadow-tree-content-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/relative-sized-shadow-tree-content-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/resource-invalidate-on-target-update-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/resource-invalidate-on-target-update-expected.txt [modify] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.png [modify] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win/svg/repaint/inner-svg-change-viewBox-contract-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win/svg/repaint/inner-svg-change-viewBox-contract-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win/svg/repaint/mask-clip-target-transform-expected.png [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win/svg/repaint/mask-clip-target-transform-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-and-object-creation-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-creation-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/marker-viewBox-changes-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-content-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-shadow-tree-content-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/custom/resource-invalidate-on-target-update-expected.txt [delete] https://crrev.com/5bcbf89d9ccff7e123c0b195e26f0901b7e65eff/third_party/WebKit/LayoutTests/platform/win7/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.png [modify] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.txt [add] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.png [modify] https://crrev.com/f25deba1194fc7e67401fcbe6d62453f472f3fe4/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67085165943cf00e2546580b80351ce67c36af0a commit 67085165943cf00e2546580b80351ce67c36af0a Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jun 14 22:47:00 2016 Skip tests that are failing after manual rebaselining. BUG= 619108 TBR=pdr@chromium.org, hcarmona@chromium.org Review URL: https://codereview.chromium.org/2069873002 . Cr-Commit-Position: refs/heads/master@{#399797} [modify] https://crrev.com/67085165943cf00e2546580b80351ce67c36af0a/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01bbf4e34d225af0dbcaa4871f8c47e95496ebcd commit 01bbf4e34d225af0dbcaa4871f8c47e95496ebcd Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Jun 15 03:20:25 2016 More tests need manual rebaselining after svg change BUG= 620126 , 619108 TBR=hcarmona@chromium.org, pdr@chromium.org Review URL: https://codereview.chromium.org/2063353003 . Cr-Commit-Position: refs/heads/master@{#399827} [modify] https://crrev.com/01bbf4e34d225af0dbcaa4871f8c47e95496ebcd/third_party/WebKit/LayoutTests/TestExpectations
I think this has been fixed.
Comment 1 by wangxianzhu@chromium.org
, Jun 10 2016