New issue
Advanced search Search tips

Issue 619103 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

New under-paint-invalidations

Project Member Reported by wangxianzhu@chromium.org, Jun 10 2016

Issue description

We haven't run under-paint-invalidation checking for some time. https://codereview.chromium.org/2049263003/ will enable both rect and object under-invalidation checking for repaint tests. The following tests failed on try bots:

compositing/overflow/updating-scrolling-container-and-content.html
fast/events/message-port-gc-closed-cloned.html
fast/repaint/align-self-overflow-change.html
fast/repaint/background-resize-height.html
fast/repaint/background-resize-width.html
fast/repaint/hover-invalidation-table.html
fast/repaint/justify-self-overflow-change.html
fast/repaint/mix-blend-mode-separate-stacking-context.html
fast/repaint/selected-replaced.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
paint/invalidation/invalidate-after-composited-scroll-of-window.html
paint/invalidation/invalidate-descendants-when-receiving-paint-layer.html
svg/repaint/rounded-rect-height-change.html
virtual/pointerevent/fast/events/message-port-gc-closed-cloned.html
virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content.html
virtual/trustedeventsdefaultaction/fast/events/message-port-gc-closed-cloned.html
 

Comment 1 Deleted

Comment 2 by pdr@chromium.org, Jun 10 2016

svg/repaint/rounded-rect-height-change.html is a pretty interesting underinvalidation case. I'll take a look in  https://crbug.com/619108 .
Ran locally the above tests with a modified pixel verification algorithm that tolerate difference<2 for unsaturated color components:

Object under-invalidations:
compositing/overflow/updating-scrolling-container-and-content.html
fast/repaint/align-self-overflow-change.html
fast/repaint/justify-self-overflow-change.html
fast/repaint/mix-blend-mode-separate-stacking-context.html
paint/invalidation/invalidate-descendants-when-receiving-paint-layer.html
virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content.html

Rect under-invalidations:
fast/repaint/background-resize-width.html
fast/repaint/hover-invalidation-table.html
fast/repaint/selected-replaced.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
paint/invalidation/invalidate-after-composited-scroll-of-window.html
svg/repaint/rounded-rect-height-change.html
Blockedon: 619108
On Windows, svg/text/text-viewbox-rescale.html also fails. Seems related to text glyph overflow. 
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993f7a7bbe936f55c0276eb524013a54bad1ce43

commit 993f7a7bbe936f55c0276eb524013a54bad1ce43
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sun Jun 12 02:05:20 2016

Auto-rebaseline for r399384

https://chromium.googlesource.com/chromium/src/+/6c46c2c41

BUG=619103
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2062663002 .

Cr-Commit-Position: refs/heads/master@{#399385}

[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/marker-viewBox-changes-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/resource-invalidate-on-target-update-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/rounded-rect-height-change-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/resource-invalidate-on-target-update-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/inner-svg-change-viewBox-contract-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/mask-clip-target-transform-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/rounded-rect-height-change-expected.txt

Blockedon: 619366
paint/invalidation/animated-gif-background-offscreen.html sometimes fail, almost always fail on debug builds:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245391
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281fab0cfc6a62067026664e3f8c522de9a5fc7a

commit 281fab0cfc6a62067026664e3f8c522de9a5fc7a
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Jun 12 23:17:17 2016

Mark paint/invalidation/animated-gif-background-offscreen.html flaky

BUG=619103

Cr-Commit-Position: refs/heads/master@{#399399}

[modify] https://crrev.com/281fab0cfc6a62067026664e3f8c522de9a5fc7a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ac1777f53c26ac798acccef38cb5506cf901a1

commit 89ac1777f53c26ac798acccef38cb5506cf901a1
Author: Per <perkj@chromium.org>
Date: Mon Jun 13 14:37:51 2016

Disable svg layouttest on Mac(Retina) and Win

crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-deep-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/resource-invalidate-on-target-update.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/marker-viewBox-changes.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-image.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-and-object-creation.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-creation.svg [ Pass Failure ]

BUG=619103
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2060863002 .

Cr-Commit-Position: refs/heads/master@{#399447}

[modify] https://crrev.com/89ac1777f53c26ac798acccef38cb5506cf901a1/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 619633
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/993f7a7bbe936f55c0276eb524013a54bad1ce43

commit 993f7a7bbe936f55c0276eb524013a54bad1ce43
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sun Jun 12 02:05:20 2016

Auto-rebaseline for r399384

https://chromium.googlesource.com/chromium/src/+/6c46c2c41

BUG=619103
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2062663002 .

Cr-Commit-Position: refs/heads/master@{#399385}

[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/linux/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/marker-viewBox-changes-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.png
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/resource-invalidate-on-target-update-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-and-object-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/js-late-clipPath-creation-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/marker-viewBox-changes-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-shadow-tree-content-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/custom/resource-invalidate-on-target-update-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/inner-svg-change-viewBox-contract-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/mask-clip-target-transform-expected.txt
[add] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/platform/win7/svg/repaint/rounded-rect-height-change-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/relative-sized-shadow-tree-content-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/custom/resource-invalidate-on-target-update-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/inner-svg-change-viewBox-contract-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/mask-clip-target-transform-expected.txt
[modify] https://crrev.com/993f7a7bbe936f55c0276eb524013a54bad1ce43/third_party/WebKit/LayoutTests/svg/repaint/rounded-rect-height-change-expected.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281fab0cfc6a62067026664e3f8c522de9a5fc7a

commit 281fab0cfc6a62067026664e3f8c522de9a5fc7a
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Jun 12 23:17:17 2016

Mark paint/invalidation/animated-gif-background-offscreen.html flaky

BUG=619103

Cr-Commit-Position: refs/heads/master@{#399399}

[modify] https://crrev.com/281fab0cfc6a62067026664e3f8c522de9a5fc7a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ac1777f53c26ac798acccef38cb5506cf901a1

commit 89ac1777f53c26ac798acccef38cb5506cf901a1
Author: Per <perkj@chromium.org>
Date: Mon Jun 13 14:37:51 2016

Disable svg layouttest on Mac(Retina) and Win

crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-deep-shadow-tree-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-content.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/resource-invalidate-on-target-update.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/marker-viewBox-changes.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/relative-sized-image.xhtml [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-and-object-creation.svg [ Pass Failure ]
crbug.com/619103 [ Win7 Retina] svg/custom/js-late-clipPath-creation.svg [ Pass Failure ]

BUG=619103
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2060863002 .

Cr-Commit-Position: refs/heads/master@{#399447}

[modify] https://crrev.com/89ac1777f53c26ac798acccef38cb5506cf901a1/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a2c53f105fd2c6f9e6451c6deb673115022047

commit 75a2c53f105fd2c6f9e6451c6deb673115022047
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Jun 18 21:43:12 2016

paint/invalidation/animated-gif[-background].html fail for crbug.com/619103

BUG=619103

Review URL: https://codereview.chromium.org/2073383002 .

Cr-Commit-Position: refs/heads/master@{#400602}

[modify] https://crrev.com/75a2c53f105fd2c6f9e6451c6deb673115022047/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf854aafb73b78b0c943c98230f9cfd8b5405b86

commit bf854aafb73b78b0c943c98230f9cfd8b5405b86
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Jun 20 14:26:00 2016

Disable updating-scrolling-container-and-content.html tests in Blink.

BUG=619103
TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2085503002 .

Cr-Commit-Position: refs/heads/master@{#400678}

[modify] https://crrev.com/bf854aafb73b78b0c943c98230f9cfd8b5405b86/third_party/WebKit/LayoutTests/TestExpectations

Labels: Hotlist-Fixit-PE2016
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccdbeb9ac61c65a33065a79314868bceb59a864d

commit ccdbeb9ac61c65a33065a79314868bceb59a864d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jun 24 21:25:55 2016

Deal with my NeedsManualRebaselines

Rebaseline paint/invalidation/animated-gif* and restore the original
expectations. Just remove NeedsManualRebaselines for the tests that
have been passing on all bots for some time.

TBR=wangxianzhu@chromium.org
BUG= 622892 , 600008 ,619103, 619630 , 617799 

Review URL: https://codereview.chromium.org/2097173002 .

Cr-Commit-Position: refs/heads/master@{#401978}

[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-expected.txt
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-expected.txt
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-expected.txt
[add] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/animated-gif-background-offscreen-expected.txt

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f41e76c78effe2493b639354696530a5ee23f6

commit 86f41e76c78effe2493b639354696530a5ee23f6
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jun 30 23:56:57 2016

Enable under-invalidation checking in tests calling runAfterLayoutAndPaint()

These tests often change dom/style after a complete paint and test how
the rendering pipeline handles the changes. They are good candidate
for under-invalidation checking.

BUG=619103

Review-Url: https://codereview.chromium.org/2092953002
Cr-Commit-Position: refs/heads/master@{#403355}

[modify] https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/86f41e76c78effe2493b639354696530a5ee23f6/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Blockedon: 626748
Yes.
Does that mean the bug caused the failure?  Or is the message being displayed many places and its appearance by the failure likely unimportant?
Yes the message means this real bug. It's important.
Cc: wangxianzhu@chromium.org
 Issue 629303  has been merged into this issue.
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eaf2aebd0b16710e3495d3448bcdbe3dab4a78d

commit 4eaf2aebd0b16710e3495d3448bcdbe3dab4a78d
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Sat Jul 23 18:04:40 2016

compositing/iframes/become-composited-nested-iframes.html under invalidation

BUG=619103
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2179663002
Cr-Commit-Position: refs/heads/master@{#407368}

[modify] https://crrev.com/4eaf2aebd0b16710e3495d3448bcdbe3dab4a78d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e615407319a0aa91de9166e653ad341e7681033

commit 0e615407319a0aa91de9166e653ad341e7681033
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Jul 29 03:28:25 2016

Handle removed display items in under-invalidation checking in cached subsequences

When we see a mismatched display item when checking under-invalidation
in a cached subsequence, if the item might be removed later, we
temporarily skip the display item and look forward.
- If the item is finally removed, the mismatch will be ignored;
- If the item is not removed, report the mismatch as under-invalidation.

Also added unit tests for under-invalidation.

BUG=619103

Review-Url: https://codereview.chromium.org/2184363002
Cr-Commit-Position: refs/heads/master@{#408569}

[modify] https://crrev.com/0e615407319a0aa91de9166e653ad341e7681033/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/0e615407319a0aa91de9166e653ad341e7681033/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/0e615407319a0aa91de9166e653ad341e7681033/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/0e615407319a0aa91de9166e653ad341e7681033/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcbb5c0cc4f958677efd66226b2611414a804895

commit bcbb5c0cc4f958677efd66226b2611414a804895
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Jul 29 17:15:52 2016

Auto-rebaseline for r408543

https://chromium.googlesource.com/chromium/src/+/e704a3c06

BUG=619103
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2196783002 .

Cr-Commit-Position: refs/heads/master@{#408671}

[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/linux-precise/compositing/overflow/updating-scrolling-container-and-content-expected.png
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[add] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/overflow/updating-scrolling-container-and-content-expected.png
[add] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/updating-scrolling-container-and-content-expected.png
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[add] https://crrev.com/bcbb5c0cc4f958677efd66226b2611414a804895/third_party/WebKit/LayoutTests/platform/win7/compositing/overflow/updating-scrolling-container-and-content-expected.png

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886c47e07620987f5dbe8c2824e45b82de17433a

commit 886c47e07620987f5dbe8c2824e45b82de17433a
Author: tapted <tapted@chromium.org>
Date: Mon Aug 01 03:41:53 2016

Mark LayoutTest updating-scrolling-container-and-content as FLAKY

BUG= 633026 , 619103
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2194123002
Cr-Commit-Position: refs/heads/master@{#408906}

[modify] https://crrev.com/886c47e07620987f5dbe8c2824e45b82de17433a/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 635034
Blockedon: 633026
Having all these tests marked as Failing or flaky means we aren't getting any test coverage on them to catch regressions etc. I want to rebaseline the results since we have an open bug (this one) to track the problems that references the tests.

For the record, the set of tests marked under this bug is:

crbug.com/619103 fast/repaint/background-resize-width.html [ Failure ]
crbug.com/619103 fast/repaint/hover-invalidation-table.html [ Failure ]
crbug.com/619103 fast/repaint/selected-replaced.html [ Failure ]
crbug.com/619103 paint/invalidation/invalidate-after-composited-scroll-of-window.html [ Failure ]
crbug.com/619103 paint/invalidation/animated-gif.html [ Pass Failure ]
crbug.com/619103 paint/invalidation/animated-gif-background.html [ Pass Failure ]
crbug.com/619103 paint/invalidation/animated-gif-background-offscreen.html [ Pass Failure ]
crbug.com/619103 [ Win ] svg/text/text-viewbox-rescale.html [ Pass Failure ]
crbug.com/619103 paint/overflow/interest-rect-change-scroll-down.html [ Failure ]
crbug.com/619103 paint/selection/text-selection-newline-mixed-ltr-rtl.html [ Failure ]
crbug.com/619103 paint/selection/text-selection-newline-rtl-double-linebreak.html [ Failure ]
crbug.com/619103 fast/layers/remove-layer-with-nested-stacking.html [ Pass Crash Timeout ]
crbug.com/619103 compositing/iframes/become-composited-nested-iframes.html [ Pass Crash Timeout ]

The flakyness is not obviously related to the bug information.
Blockedon: 640245
Labels: -Hotlist-Fixit-PE2016
SGTM. Would like to check them after flakiness dashboard is fixed. 
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e01747a312617a0088b94f2e7cc55092d50975e

commit 1e01747a312617a0088b94f2e7cc55092d50975e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Sep 01 21:27:38 2016

Compile under-invalidation checking in all builds

This will let the tests having under-invalidation issues produce the
same result on all builds, so enable us to rebaseline the tests with
failure results. In this way we can track either regressions and
progressions instead of ignoring the tests.

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2299223002
Cr-Commit-Position: refs/heads/master@{#416060}

[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82

commit c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Sep 01 23:08:03 2016

Revert of Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2299223002/ )

Reason for revert:
On Mac and Windows strange pixel under invalidations are reported, e.g.: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/14277/layout-test-results/results.html

Original issue's description:
> Compile under-invalidation checking in all builds
>
> This will let the tests having under-invalidation issues produce the
> same result on all builds, so enable us to rebaseline the tests with
> failure results. In this way we can track either regressions and
> progressions instead of ignoring the tests.
>
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/1e01747a312617a0088b94f2e7cc55092d50975e
> Cr-Commit-Position: refs/heads/master@{#416060}

TBR=pdr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619103

Review-Url: https://codereview.chromium.org/2306783002
Cr-Commit-Position: refs/heads/master@{#416109}

[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/c5a2b6ef93e0720952cc95e7e3c6e7f4de13fb82/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/730c50d75791af41558efece2aa560a0c2fc97e9

commit 730c50d75791af41558efece2aa560a0c2fc97e9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Sep 02 15:59:15 2016

Reland Compile under-invalidation checking in all builds

This relands https://codereview.chromium.org/2299223002 which was
reverted because of random pixel under-invalidations.

Now clear the bitmaps before drawing the pictures.

BTW changed the error indication color from solid red to translucent
magenta to distinguish from the normal red pixels in test results.

> This will let the tests having under-invalidation issues produce the
> same result on all builds, so enable us to rebaseline the tests with
> failure results. In this way we can track either regressions and
> progressions instead of ignoring the tests.
>
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2299223002
> Cr-Commit-Position: refs/heads/master@{#416060}

BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/2301303002 .

Cr-Commit-Position: refs/heads/master@{#416276}

[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/730c50d75791af41558efece2aa560a0c2fc97e9/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0cf2cd66981fa2bd63cf18c01b25841fca0c6c3

commit b0cf2cd66981fa2bd63cf18c01b25841fca0c6c3
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Sep 02 19:09:33 2016

compositing/overflow/updating-scrolling-container-and-content.html fail

BUG=619103
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2308743002
Cr-Commit-Position: refs/heads/master@{#416315}

[modify] https://crrev.com/b0cf2cd66981fa2bd63cf18c01b25841fca0c6c3/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2fd525fcd9ba4346658204ad2dfa62f9c7a807

commit df2fd525fcd9ba4346658204ad2dfa62f9c7a807
Author: mgiuca <mgiuca@chromium.org>
Date: Mon Sep 05 08:31:07 2016

Revert of Reland Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2301303002/ )

Reason for revert:
Causing failures on WebKit Mac 10.9:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9

updating-scrolling-container-and-content.html is hitting the new CHECK on
PaintController.cpp:662. It's not clear why this passed on build #36527; all
other builds since this landed failed.

Original issue's description:
> Reland Compile under-invalidation checking in all builds
>
> This relands https://codereview.chromium.org/2299223002 which was
> reverted because of random pixel under-invalidations.
>
> Now clear the bitmaps before drawing the pictures.
>
> BTW changed the error indication color from solid red to translucent
> magenta to distinguish from the normal red pixels in test results.
>
> > This will let the tests having under-invalidation issues produce the
> > same result on all builds, so enable us to rebaseline the tests with
> > failure results. In this way we can track either regressions and
> > progressions instead of ignoring the tests.
> >
> > BUG=619103
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Review-Url: https://codereview.chromium.org/2299223002
> > Cr-Commit-Position: refs/heads/master@{#416060}
>
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> R=pdr@chromium.org

TBR=pdr@chromium.org,wangxianzhu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=619103
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2309193002
Cr-Commit-Position: refs/heads/master@{#416516}

[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33

commit 5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Sep 07 00:41:30 2016

Reland of land Compile under-invalidation checking in all builds (patchset #2 id:300001 of https://codereview.chromium.org/2309193002/ )

Reason for revert:
This should be landed to discover under-invalidations. If any test hit this, we should mark the test fail instead of reverting this.

The failed test had been marked failure before the revert.

Original issue's description:
> Revert of Reland Compile under-invalidation checking in all builds (patchset #4 id:60001 of https://codereview.chromium.org/2301303002/ )
>
> Reason for revert:
> Causing failures on WebKit Mac 10.9:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9
>
> updating-scrolling-container-and-content.html is hitting the new CHECK on
> PaintController.cpp:662. It's not clear why this passed on build #36527; all
> other builds since this landed failed.
>
> Original issue's description:
> > Reland Compile under-invalidation checking in all builds
> >
> > This relands https://codereview.chromium.org/2299223002 which was
> > reverted because of random pixel under-invalidations.
> >
> > Now clear the bitmaps before drawing the pictures.
> >
> > BTW changed the error indication color from solid red to translucent
> > magenta to distinguish from the normal red pixels in test results.
> >
> > > This will let the tests having under-invalidation issues produce the
> > > same result on all builds, so enable us to rebaseline the tests with
> > > failure results. In this way we can track either regressions and
> > > progressions instead of ignoring the tests.
> > >
> > > BUG=619103
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Review-Url: https://codereview.chromium.org/2299223002
> > > Cr-Commit-Position: refs/heads/master@{#416060}
> >
> > BUG=619103
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > R=pdr@chromium.org
>
> TBR=pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=619103
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/df2fd525fcd9ba4346658204ad2dfa62f9c7a807
> Cr-Commit-Position: refs/heads/master@{#416516}

TBR=pdr@chromium.org,mgiuca@chromium.org
BUG=619103, 644358 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2314103002
Cr-Commit-Position: refs/heads/master@{#416800}

[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/compositing/repaint/page-scale-repaint.html
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/5d28b2b610719d4d1c4d1fd7f8a74e8dfeba0d33/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a91010926d8c5c77e395f2dab49b4e64f11e6c00

commit a91010926d8c5c77e395f2dab49b4e64f11e6c00
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Sep 09 18:27:36 2016

Deflake paint/invalidation/animated-gif*.html

- Replace timeouts with advanceImageAnimation()
- Don't start tracking paint invalidations before repaintTest to avoid
  extra paint invalidations sometimes. advanceImageAnimation() can
  ensure a new animation frame so we don't need to start tracking
  earlier which was required when we used the timeout.

BUG=619103

Review-Url: https://codereview.chromium.org/2319833002
Cr-Commit-Position: refs/heads/master@{#417641}

[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline-expected.txt
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-firstline.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-offscreen.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif.html
[modify] https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Blockedon: 646010
Blockedon: 646015
Blockedon: 646016
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3

commit d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon Sep 12 21:43:23 2016

Fix GraphicsLayer under-invalidation checking when interest rect changes

We should not check under-invalidation out of either the previous
interest rect or the current interest rect.

BUG=619103

Review-Url: https://codereview.chromium.org/2333513003
Cr-Commit-Position: refs/heads/master@{#418057}

[modify] https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/565d2b3d6515809f61b787111257a944bace23b3/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/invalidate-after-composited-scroll-of-window-expected.txt
[modify] https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-after-composited-scroll-of-window-expected.txt
[rename] https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/invalidate-after-composited-scroll-of-window-expected.txt
[copy] https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/invalidate-after-composited-scroll-of-window-expected.txt
[modify] https://crrev.com/d2a9d76a63ebc2b3660bd608e5f50619f73a9fc3/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Blockedon: 655005
Blockedon: 656172
Blockedon: 660530
Blockedon: 677201
Blockedon: 679717
Blockedon: 680211
Blockedon: 699480
Project Member

Comment 53 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5fdcafd9d072e041bc87c8ba8f8fb6f15eae00d

commit f5fdcafd9d072e041bc87c8ba8f8fb6f15eae00d
Author: schenney <schenney@chromium.org>
Date: Mon Apr 03 14:25:16 2017

Rebaseline paint/selection/text-selection-newline-mixed-ltr-rtl.html

The test is marked as failing, but it passes on Mac with no problems and
the linnux difs are insignificant. Rebaselining.

Another test under this bug is for invalidation and it's a ref test.
Moved it's expectations to a block for failing ref tests to simplify
triage, and delete the useless -expected.txt files.

TBR=wkorman@chromium.org
BUG=619103

Review-Url: https://codereview.chromium.org/2788193002
Cr-Commit-Position: refs/heads/master@{#461425}

[modify] https://crrev.com/f5fdcafd9d072e041bc87c8ba8f8fb6f15eae00d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-width-expected.txt
[delete] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/background-resize-width-expected.txt
[modify] https://crrev.com/f5fdcafd9d072e041bc87c8ba8f8fb6f15eae00d/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png
[modify] https://crrev.com/f5fdcafd9d072e041bc87c8ba8f8fb6f15eae00d/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.txt

Blockedon: 707807
Note that paint/selection/text-selection-newline-mixed-ltr-rtl.html still has problem: the dark red pixels are pixels that need raster invalidation but are not invalidated. The problem is related to glyph overflow calculation.

Filed bug 707807 for it.
Labels: BugSource-Team PaintTeamTriaged-20170424
Is this really P1. It seems we are steadily churning through them, but none are urgent enough to justify blocking a particular milestone.
Labels: -Pri-1 Pri-2
Blockedon: 755478
Blockedon: 764244

Sign in to add a comment