cros uprevchrome tool should update the chromium issue with relevant details |
||||
Issue descriptionThe cros uprevchrome tool should update the issue filed by the person running the cmd with 1)the actual cmd parameters run. for example: cros uprevchrome --pfq-build 892122 --cred-dir ./prod_cidb_readonly/ -- bug chromium:618830 2) The links to the CLs generated as a result example : https://chromium-review.googlesource.com/#/c/351229/ https://chrome-internal-review.googlesource.com/#/c/264045/ 3) The link to the PFQ build, the build ID and the snippet of the actual build where the build no exists https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/2997 build_id: 892122 Snippet/Link within the builder page: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/2997/steps/BuildStart BuildStart BuildStart database: prod, build_id: 892122 ( 5 secs ) stdio Builder documentation
,
Jun 15 2016
That's fair. Can we add the cmd parameters (i.e. 'cros uprevchrome --pfq-build...') to the CL descriptions instead? Then we will get that in the bug once the CLs land. It will also make it a bit more clear that the commit was triggered by cros uprevchrome.
,
Jun 15 2016
I can add the pfq-build id to the commit message, that's easy and people can find the corresponding build in the waterfall. The other parameters in the command aren't very meaningful. Right now there's a 'Note' in the commit log already as "Note: this commit was generated by cros_uprevchrome"
,
Jun 15 2016
I can add the build number as well.
,
Jun 15 2016
Personally I find having the entire command line copy/pasteable to be both convenient and readable (e.g. the note line does not stick out at all, whereas something that looks like a command will), but whatever seems most maintainable to you.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c4bfb43b6a4a975d41d65c7f11cfe203c254f05a commit c4bfb43b6a4a975d41d65c7f11cfe203c254f05a Author: Ningning Xia <nxia@chromium.org> Date: Thu Jun 16 00:57:20 2016 Add build_id and build_number to CL commit logs. Add build_id and build_number in public and private CLs commit logs. Update some comments. Raise exceptions from ValidatePFQBuild. BUG= chromium:619102 TEST=run tool locally Change-Id: Ife0ba4f906ca4c04d3bced1130af00feaab7b916 Reviewed-on: https://chromium-review.googlesource.com/352819 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/c4bfb43b6a4a975d41d65c7f11cfe203c254f05a/cli/cros/cros_uprevchrome.py [modify] https://crrev.com/c4bfb43b6a4a975d41d65c7f11cfe203c254f05a/cli/cros/cros_uprevchrome_unittest.py
,
Jun 22 2016
,
Jul 1 2016
bulk verified |
||||
►
Sign in to add a comment |
||||
Comment 1 by akes...@chromium.org
, Jun 15 2016