Issue metadata
Sign in to add a comment
|
Autotest pylint issue |
||||||||||||||||||||||||
Issue descriptionI try to "repo upload" inside autotest git repo and pylint choked on file autotest/files/frontend/afe/control_file.py. I had a conversation with Dan, here are some observations: - On ubuntu Trusty, the system pylint installed is version 1.1, which means /usr/bin/pylint and /usr/lib/python2.7/dist-packages/pylint are both 1.1. If you run "repo upload" outside chroot, it will run "utils/run_pylint.py", and it will use 1.1 vresion of pylint inside /usr/lib/python2.7/dist-packages/pylint. - If you run "repo upload" inside chroot, all the pylint code is at version 1.4. However, utils/run_pylint.py is still written based on pylint 1.1. It will fail on access PyLinter._messages.
,
Jun 10 2016
I suggest we move to pylint 1.4 since 1.1 seems to choke on parsing files like control_file.py. We should: - Update run_pylint.py code to 1.4 (add condition in the code) - Do repo upload inside chroot (avoid the ubuntu system 1.1)
,
Jun 10 2016
If we make run_pylint use the chroot, then do we really need to "add condition in the code" to support both? It seems fragile to try to support both.
,
Jun 10 2016
You are right it is hard to maintain the code for both 1.1 and 1.4. Actually, I just find out current 1.1 works fine outisde chroot after I fixed some docstring warnings inside existing control_file.py. So this bug is low prioirty for me now.
,
Jun 11 2016
,
Jun 13 2016
,
Sep 19 2016
,
Jan 12 2017
Instead of making any non-trivial change to run_pylint, we'd like to just move to `cros lint`. Why solve the same problem twice. :) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sbasi@chromium.org
, Jun 10 2016Components: Infra>Client>ChromeOS
Labels: -Pri-3 Pri-2