New issue
Advanced search Search tips

Issue 619092 link

Starred by 3 users
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Mar 2017
Cc:
feature-...@grotations.appspotmail.com
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug-Regression



Sign in to add a comment

OriginTrialEnabled IDL Attribute doesn't work on constants

Project Member Reported by iclell...@chromium.org, Jun 10 2016 
Since the bindings refactor, we've lost the ability for the [OriginTrialEnabled] IDL attribute to be added to constants.

This isn't used currently by any origin trial features, but we should add it back.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9500e40f0af7830f1024693b715d5abb6a7e37d4

commit 9500e40f0af7830f1024693b715d5abb6a7e37d4
Author: iclelland <iclelland@chromium.org>
Date: Fri Jun 17 07:43:59 2016

[OriginTrials] Support OriginTrialEnabled IDL attribute on constants

BUG= 619092 

Review-Url: https://codereview.chromium.org/2057273002
Cr-Commit-Position: refs/heads/master@{#400390}

[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/templates/constants.cpp
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/templates/interface.h
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/templates/interface_base.cpp
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/templates/partial_interface.h
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.idl
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.h
[modify] https://crrev.com/9500e40f0af7830f1024693b715d5abb6a7e37d4/third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.idl

Comment 2 by cha...@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
I don't think there's anything left to do here. If so, please re-open with details.
►

Sign in to add a comment