Provision Devices should not fail if device is unresponsive. |
||
Issue description
Provision devices currently can fail when a device is unresponsive and times out on an "adb shell getprop" call. In this case, provision devices should fail as expected (log the time out exception and potentially add to blacklist)
My guess is that this error is caused by the code used to get the reboot_timeout which isn't in a try block
def ProvisionDevice(device, blacklist, options):
if options.reboot_timeout:
reboot_timeout = options.reboot_timeout
elif device.build_version_sdk >= version_codes.LOLLIPOP:
reboot_timeout = _DEFAULT_TIMEOUTS.LOLLIPOP
else:
reboot_timeout = _DEFAULT_TIMEOUTS.PRE_LOLLIPOP
The call to device.build_version_sdk calls GetProp. If this times out, provision_devices.py will just fail.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39419395ebe93d10dde4107415decb81ae851eb4 commit 39419395ebe93d10dde4107415decb81ae851eb4 Author: mikecase <mikecase@chromium.org> Date: Fri Jun 10 21:20:02 2016 [Android] Fix provision devices failure getting timeout. Fixing provision devices script failing if timeout is not manually set and one of the devices is unresponsive. BUG= 619088 Review-Url: https://codereview.chromium.org/2059863002 Cr-Commit-Position: refs/heads/master@{#399270} [modify] https://crrev.com/39419395ebe93d10dde4107415decb81ae851eb4/build/android/provision_devices.py
,
Jun 10 2016
Should be fixed now.
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39419395ebe93d10dde4107415decb81ae851eb4 commit 39419395ebe93d10dde4107415decb81ae851eb4 Author: mikecase <mikecase@chromium.org> Date: Fri Jun 10 21:20:02 2016 [Android] Fix provision devices failure getting timeout. Fixing provision devices script failing if timeout is not manually set and one of the devices is unresponsive. BUG= 619088 Review-Url: https://codereview.chromium.org/2059863002 Cr-Commit-Position: refs/heads/master@{#399270} [modify] https://crrev.com/39419395ebe93d10dde4107415decb81ae851eb4/build/android/provision_devices.py |
||
►
Sign in to add a comment |
||
Comment 1 by jbudorick@chromium.org
, Jun 10 2016