New issue
Advanced search Search tips

Issue 619086 link

Starred by 1 user
Status: Fixed
Owner:
sebmarchand@chromium.org
Closed: Jul 2016
Cc:
chrisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

content_shell_syzyasan in missing in win/gn build

Project Member Reported by thakis@chromium.org, Jun 10 2016 
The target added in https://codereview.chromium.org/25061002 doesn't exist in the gn build.

Filing this so we'll add it if it's important. If it's added, it should be added to the chromium_browser_asan target I'm currently adding to the gn build.

Comment 1 by sebmarchand@chromium.org, Jun 10 2016 

Yes, this target is important for Clusterfuzz. I'm planning to fix the SyzyAsan GN build next week.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad249c727037a5e72cd29e270c99bba569841645

commit ad249c727037a5e72cd29e270c99bba569841645
Author: dpranke <dpranke@chromium.org>
Date: Sat Jun 11 18:01:22 2016

Add missing 'compiler.gni' import to //BUILD.gn.

TBR=thakis@chromium.org
BUG= 619086 

Review-Url: https://codereview.chromium.org/2058363002
Cr-Commit-Position: refs/heads/master@{#399377}

[modify] https://crrev.com/ad249c727037a5e72cd29e270c99bba569841645/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad249c727037a5e72cd29e270c99bba569841645

commit ad249c727037a5e72cd29e270c99bba569841645
Author: dpranke <dpranke@chromium.org>
Date: Sat Jun 11 18:01:22 2016

Add missing 'compiler.gni' import to //BUILD.gn.

TBR=thakis@chromium.org
BUG= 619086 

Review-Url: https://codereview.chromium.org/2058363002
Cr-Commit-Position: refs/heads/master@{#399377}

[modify] https://crrev.com/ad249c727037a5e72cd29e270c99bba569841645/BUILD.gn

Comment 6 by sebmarchand@chromium.org, Jun 15 2016 

I'm fixing the GN SyzyAsan config, so I can take care of this if you want.

Comment 7 by thakis@chromium.org, Jun 15 2016 

(I'm not working in this, if that note was for me :-) )

Comment 8 by sebmarchand@chromium.org, Jun 15 2016

Cc: -sebmarchand@chromium.org
Owner: sebmarchand@chromium.org
Status: Assigned (was: Untriaged)
Great, assigning to me then.

Comment 9 by dpranke@chromium.org, Jun 20 2016

Labels: -Pri-3 Pri-2

Comment 10 by dpranke@chromium.org, Jul 1 2016

Blocking: -354261
As suggested by laforge@ and a conversation w/ the monorail folks, I'm going to try tracking GN-Migration related issues by *just* using the Proj-GN-Migration label, and not using blocking/rollup bugs, so that we can use blocking for just tasks that truly need to be completed before other tasks can make progress.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a43cab53042f33d77fe8eebe8c2463a92f9758

commit 71a43cab53042f33d77fe8eebe8c2463a92f9758
Author: sebmarchand <sebmarchand@chromium.org>
Date: Fri Jul 08 22:03:35 2016

Move the Syzygy scripts out of //chrome/

Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).

BUG= 619086 

Review-Url: https://codereview.chromium.org/2126673002
Cr-Commit-Position: refs/heads/master@{#404503}

[modify] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/BUILD.gn
[add] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/BUILD.gn
[add] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/OWNERS
[rename] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/instrument.py
[rename] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/reorder.py
[rename] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/syzyasan-allocation-filter.txt
[rename] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/syzyasan-instrumentation-filter.txt
[add] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/build/win/syzygy/syzygy.gni
[modify] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/chrome/tools/build/win/syzygy/BUILD.gn
[modify] https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758/third_party/kasko/BUILD.gn
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6318d34b911380a6ebb3f1c8787024ba3e3400eb

commit 6318d34b911380a6ebb3f1c8787024ba3e3400eb
Author: sebmarchand <sebmarchand@chromium.org>
Date: Fri Jul 08 23:26:21 2016

Revert of Move the Syzygy scripts out of //chrome/ (patchset #5 id:80001 of https://codereview.chromium.org/2126673002/ )

Reason for revert:
It's breaking the Gyp Official build and I can't fix this right now.

BUG=626828

Original issue's description:
> Move the Syzygy scripts out of //chrome/
>
> Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).
>
> BUG= 619086 
>
> Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758
> Cr-Commit-Position: refs/heads/master@{#404503}

TBR=chrisha@chromium.org,dpranke@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 619086 

Review-Url: https://codereview.chromium.org/2129333002
Cr-Commit-Position: refs/heads/master@{#404530}

[modify] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/BUILD.gn
[delete] https://crrev.com/4d17020d9c377daa8c119aa4648dcf37b2b94490/build/win/syzygy/BUILD.gn
[delete] https://crrev.com/4d17020d9c377daa8c119aa4648dcf37b2b94490/build/win/syzygy/OWNERS
[delete] https://crrev.com/4d17020d9c377daa8c119aa4648dcf37b2b94490/build/win/syzygy/syzygy.gni
[modify] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/tools/build/win/syzygy/BUILD.gn
[rename] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/tools/build/win/syzygy/instrument.py
[rename] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/tools/build/win/syzygy/reorder.py
[rename] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt
[rename] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/chrome/tools/build/win/syzygy/syzyasan-instrumentation-filter.txt
[modify] https://crrev.com/6318d34b911380a6ebb3f1c8787024ba3e3400eb/third_party/kasko/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e9548c2068ea978a3ad882e6394cf3493b81dab

commit 3e9548c2068ea978a3ad882e6394cf3493b81dab
Author: sebmarchand <sebmarchand@chromium.org>
Date: Mon Jul 11 16:33:20 2016

Move the Syzygy scripts out of //chrome/

Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).

BUG= 619086 

Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758
Review-Url: https://codereview.chromium.org/2126673002
Cr-Original-Commit-Position: refs/heads/master@{#404503}
Cr-Commit-Position: refs/heads/master@{#404672}

[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/BUILD.gn
[add] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/BUILD.gn
[add] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/OWNERS
[rename] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/instrument.py
[rename] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/reorder.py
[rename] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/syzyasan-allocation-filter.txt
[rename] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/syzyasan-instrumentation-filter.txt
[add] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/build/win/syzygy/syzygy.gni
[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/chrome/chrome_syzygy.gypi
[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/chrome/tools/build/win/syzygy/BUILD.gn
[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/content/content_shell.gypi
[modify] https://crrev.com/3e9548c2068ea978a3ad882e6394cf3493b81dab/third_party/kasko/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2df33953c13491c7a0939f490aed6322fc5476f

commit a2df33953c13491c7a0939f490aed6322fc5476f
Author: sebmarchand <sebmarchand@chromium.org>
Date: Wed Jul 13 15:34:59 2016

Add the content_shell_syzyasan GN target.

BUG= 619086 

Review-Url: https://codereview.chromium.org/2140793002
Cr-Commit-Position: refs/heads/master@{#405161}

[modify] https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f/BUILD.gn
[modify] https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f/content/shell/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2df33953c13491c7a0939f490aed6322fc5476f

commit a2df33953c13491c7a0939f490aed6322fc5476f
Author: sebmarchand <sebmarchand@chromium.org>
Date: Wed Jul 13 15:34:59 2016

Add the content_shell_syzyasan GN target.

BUG= 619086 

Review-Url: https://codereview.chromium.org/2140793002
Cr-Commit-Position: refs/heads/master@{#405161}

[modify] https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f/BUILD.gn
[modify] https://crrev.com/a2df33953c13491c7a0939f490aed6322fc5476f/content/shell/BUILD.gn

Comment 16 by sebmarchand@chromium.org, Jul 14 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment