New issue
Advanced search Search tips

Issue 619076 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocking:
issue 616244



Sign in to add a comment

Split web_test.h into multiple parts

Project Member Reported by eugene...@chromium.org, Jun 10 2016

Issue description

ios/web/public/test/web_test.h
ios/web/public/test/web_test_with_web_state.h
ios/web/test/web_test_with_web_controller.h
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473b43dded65ff560a8f1c0336ac176b304556a2

commit 473b43dded65ff560a8f1c0336ac176b304556a2
Author: eugenebut <eugenebut@chromium.org>
Date: Sat Jun 11 02:10:38 2016

[ios] Extracted web_test.h classes into separate files.

web::WebTest, web::WebTestWithWebStates and
web::WebTestWithWebController are now separate classes
placed in separate files. Old web_test.h files is kept
temporary to switch all downstream files to use new includes.

BUG= 619076 

Review-Url: https://codereview.chromium.org/2060483003
Cr-Commit-Position: refs/heads/master@{#399351}

[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/BUILD.gn
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/ios_web.gyp
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test.mm
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test_with_web_state.h
[rename] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test_with_web_controller.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test_with_web_controller.mm
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/web_state/ui/crw_web_controller_unittest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/49b8611d4cc35c2b9a92b5980cce0fe5dd8ae384

commit 49b8611d4cc35c2b9a92b5980cce0fe5dd8ae384
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 15:56:03 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/adeaf42be7b79e14b4b2faf4e0e3b3f9d7f0db00

commit adeaf42be7b79e14b4b2faf4e0e3b3f9d7f0db00
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 16:23:44 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e6a8aaa90a135bba3c84376a5a76988a7b8956d3

commit e6a8aaa90a135bba3c84376a5a76988a7b8956d3
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 16:55:40 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/643a8630d8c7ffe903bdf02721755800696e2cc9

commit 643a8630d8c7ffe903bdf02721755800696e2cc9
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 16:55:49 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/65be25f87f7bf7f78667800bafe3bd36b617de86

commit 65be25f87f7bf7f78667800bafe3bd36b617de86
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 17:26:01 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6ab12dd3f722ae69e7a9b632ed75cda56a908d2a

commit 6ab12dd3f722ae69e7a9b632ed75cda56a908d2a
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 18:53:13 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6bee5298219e498e8b89707b69086dc9df403365

commit 6bee5298219e498e8b89707b69086dc9df403365
Author: eugenebut <eugenebut@google.com>
Date: Mon Jun 13 18:56:44 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deaa82317a3c0acb6357a65a51128cebbcf9c974

commit deaa82317a3c0acb6357a65a51128cebbcf9c974
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Jun 13 21:45:40 2016

[ios] Removed deprecated ios/web/test/web_test.h.

This header was split into 3 separate headers:
 ios/web/public/test/web_test.h
 ios/web/public/test/web_test_with_web_state.h
 ios/web/test/web_test_with_web_controller.h

BUG= 619076 

Review-Url: https://codereview.chromium.org/2063763002
Cr-Commit-Position: refs/heads/master@{#399554}

[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/BUILD.gn
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/active_state_manager_impl_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/ios_web.gyp
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/net/crw_cert_verification_controller_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/net/crw_ssl_status_updater_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/public/test/web_test_with_web_state.h
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/test/web_int_test.h
[delete] https://crrev.com/7408e40d8c92cf65401fece81a8c4b5c366e169a/ios/web/test/web_test.h
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/common_js_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/core_js_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/crw_js_injection_manager_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/crw_js_post_request_loader_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/page_script_util_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/web_view_js_utils_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/web_view_internal_creation_util_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/mojo_facade_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/web_ui_mojo_inttest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473b43dded65ff560a8f1c0336ac176b304556a2

commit 473b43dded65ff560a8f1c0336ac176b304556a2
Author: eugenebut <eugenebut@chromium.org>
Date: Sat Jun 11 02:10:38 2016

[ios] Extracted web_test.h classes into separate files.

web::WebTest, web::WebTestWithWebStates and
web::WebTestWithWebController are now separate classes
placed in separate files. Old web_test.h files is kept
temporary to switch all downstream files to use new includes.

BUG= 619076 

Review-Url: https://codereview.chromium.org/2060483003
Cr-Commit-Position: refs/heads/master@{#399351}

[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/BUILD.gn
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/ios_web.gyp
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test.mm
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test_with_web_state.h
[rename] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test_with_web_controller.h
[add] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/test/web_test_with_web_controller.mm
[modify] https://crrev.com/473b43dded65ff560a8f1c0336ac176b304556a2/ios/web/web_state/ui/crw_web_controller_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deaa82317a3c0acb6357a65a51128cebbcf9c974

commit deaa82317a3c0acb6357a65a51128cebbcf9c974
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Jun 13 21:45:40 2016

[ios] Removed deprecated ios/web/test/web_test.h.

This header was split into 3 separate headers:
 ios/web/public/test/web_test.h
 ios/web/public/test/web_test_with_web_state.h
 ios/web/test/web_test_with_web_controller.h

BUG= 619076 

Review-Url: https://codereview.chromium.org/2063763002
Cr-Commit-Position: refs/heads/master@{#399554}

[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/BUILD.gn
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/active_state_manager_impl_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/ios_web.gyp
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/net/crw_cert_verification_controller_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/net/crw_ssl_status_updater_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/public/test/web_test_with_web_state.h
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/test/web_int_test.h
[delete] https://crrev.com/7408e40d8c92cf65401fece81a8c4b5c366e169a/ios/web/test/web_test.h
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/common_js_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/core_js_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/crw_js_injection_manager_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/crw_js_post_request_loader_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/js/page_script_util_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_web_controller_observer_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/ui/web_view_js_utils_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/web_state/web_view_internal_creation_util_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/mojo_facade_unittest.mm
[modify] https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974/ios/web/webui/web_ui_mojo_inttest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77d64a13b85effe3275d7b53c6e552554628844

commit f77d64a13b85effe3275d7b53c6e552554628844
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Jun 21 16:05:39 2016

[ios] Removed CRWWebController from WebTestWithWebState interface.

CRWWebController should not be used in public web// headers.

BUG= 619076 

Review-Url: https://codereview.chromium.org/2086723002
Cr-Commit-Position: refs/heads/master@{#401003}

[modify] https://crrev.com/f77d64a13b85effe3275d7b53c6e552554628844/ios/web/public/test/web_test_with_web_state.h
[modify] https://crrev.com/f77d64a13b85effe3275d7b53c6e552554628844/ios/web/public/test/web_test_with_web_state.mm

Status: Fixed (was: Started)

Sign in to add a comment